github-actions[bot] commented on PR #12862:
URL: https://github.com/apache/lucene/pull/12862#issuecomment-2327675527
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
mikemccand commented on PR #12862:
URL: https://github.com/apache/lucene/pull/12862#issuecomment-2296974933
Hmm it looks like this change was nearly ready to be merged? But code has
since drifted and the PR now has some rust (conflicts)?
--
This is an automated message from the Apache Gi
github-actions[bot] commented on PR #12862:
URL: https://github.com/apache/lucene/pull/12862#issuecomment-2046235004
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
epotyom commented on code in PR #12862:
URL: https://github.com/apache/lucene/pull/12862#discussion_r1540090770
##
lucene/facet/src/java/org/apache/lucene/facet/Facets.java:
##
@@ -58,6 +58,9 @@ public abstract FacetResult getTopChildren(int topN, String
dim, String... path)
epotyom commented on code in PR #12862:
URL: https://github.com/apache/lucene/pull/12862#discussion_r1540089552
##
lucene/CHANGES.txt:
##
@@ -87,6 +87,10 @@ API Changes
* GITHUB#13146, GITHUB#13148: Remove ByteBufferIndexInput and only use
MemorySegment APIs
for MMapDirecto
gsmiller commented on code in PR #12862:
URL: https://github.com/apache/lucene/pull/12862#discussion_r1539340494
##
lucene/facet/src/java/org/apache/lucene/facet/Facets.java:
##
@@ -58,6 +58,9 @@ public abstract FacetResult getTopChildren(int topN, String
dim, String... path)
gsmiller commented on code in PR #12862:
URL: https://github.com/apache/lucene/pull/12862#discussion_r1539336428
##
lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java:
##
@@ -568,6 +568,12 @@ public Number getSpecificValue(String dim, String... path)
{
epotyom commented on PR #12862:
URL: https://github.com/apache/lucene/pull/12862#issuecomment-2010909252
Thank you for reviewing @gsmiller ! I've addressed your comments and updated
the branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
epotyom commented on code in PR #12862:
URL: https://github.com/apache/lucene/pull/12862#discussion_r1533045914
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyWriter.java:
##
@@ -32,8 +32,8 @@
import org.apache.lucene.document.Field;
impor
epotyom commented on code in PR #12862:
URL: https://github.com/apache/lucene/pull/12862#discussion_r1533045638
##
lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java:
##
@@ -568,6 +568,12 @@ public Number getSpecificValue(String dim, String... path)
{
github-actions[bot] commented on PR #12862:
URL: https://github.com/apache/lucene/pull/12862#issuecomment-2008388050
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
gsmiller commented on PR #12862:
URL: https://github.com/apache/lucene/pull/12862#issuecomment-1979641229
@epotyom I saw Mike already approved. I did my own pass anyway so I
understand the changes. They look good. Thanks! I left one small question for
you about a default implementation. Let
gsmiller commented on code in PR #12862:
URL: https://github.com/apache/lucene/pull/12862#discussion_r1513504689
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyWriter.java:
##
@@ -32,8 +32,8 @@
import org.apache.lucene.document.Field;
impo
gsmiller commented on code in PR #12862:
URL: https://github.com/apache/lucene/pull/12862#discussion_r1513502215
##
lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java:
##
@@ -568,6 +568,12 @@ public Number getSpecificValue(String dim, String... path)
{
epotyom commented on PR #12862:
URL: https://github.com/apache/lucene/pull/12862#issuecomment-1973648097
> [gsmiller](/gsmiller)
> @epotyom I'd be happy to do a pass on this and help get it merged if you
like. Would you mind resolving the current merge conflicts then I'll have
gsmiller commented on PR #12862:
URL: https://github.com/apache/lucene/pull/12862#issuecomment-1969991101
@epotyom I'd be happy to do a pass on this and help get it merged if you
like. Would you mind resolving the current merge conflicts then I'll have a
look?
--
This is an automated mes
github-actions[bot] commented on PR #12862:
URL: https://github.com/apache/lucene/pull/12862#issuecomment-1907129639
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
epotyom commented on PR #12862:
URL: https://github.com/apache/lucene/pull/12862#issuecomment-1882551314
@mikemccand oh I just realised that replying to code line comment doesn't
send a notification!
Thank you for reviewing, I listed some alternatives above, but I still think
that cu
github-actions[bot] commented on PR #12862:
URL: https://github.com/apache/lucene/pull/12862#issuecomment-1880899290
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
epotyom commented on code in PR #12862:
URL: https://github.com/apache/lucene/pull/12862#discussion_r1427718945
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyWriter.java:
##
@@ -32,8 +32,8 @@
import org.apache.lucene.document.Field;
impor
mikemccand commented on code in PR #12862:
URL: https://github.com/apache/lucene/pull/12862#discussion_r1426891701
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyWriter.java:
##
@@ -32,8 +32,8 @@
import org.apache.lucene.document.Field;
im
21 matches
Mail list logo
