Re: [I] Supporting both parentQuery and childQuery and adding childLimitPerParent in BlockJoin queries [lucene]

2025-05-02 Thread via GitHub
asimmahmood1 commented on issue #14565: URL: https://github.com/apache/lucene/issues/14565#issuecomment-2848314981 I think new query type is good idea, you're already mentioned new reasons like which score to use, and infact we used combination of parent and child score. For the short term

Re: [PR] Refactor doc values to expose a `DocIdSetIterator` instead of extending `DocIdSetIterator`. [lucene]

2025-05-02 Thread via GitHub
github-actions[bot] commented on PR #14475: URL: https://github.com/apache/lucene/pull/14475#issuecomment-2848311502 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] [Bug] Fix for postings force merge regression [lucene]

2025-05-02 Thread via GitHub
github-actions[bot] commented on PR #14513: URL: https://github.com/apache/lucene/pull/14513#issuecomment-2848311449 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [I] Supporting both parentQuery and childQuery in ToChildBlockJoinQuery and adding childLimitPerParent [lucene]

2025-05-02 Thread via GitHub
Jinny-Wang commented on issue #14565: URL: https://github.com/apache/lucene/issues/14565#issuecomment-2848301176 With more explorations in the code, I think it would be cleaner to just introduce a new query operator instead of trying to wrap both parentQuery and childQuery in ToChildBlockJo

Re: [PR] MultiRange query for SortedNumeric DocValues (#14404) [lucene]

2025-05-02 Thread via GitHub
mkhludnev merged PR #14605: URL: https://github.com/apache/lucene/pull/14605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

[PR] MultiRange query for SortedNumeric DocValues (#14404) [lucene]

2025-05-02 Thread via GitHub
mkhludnev opened a new pull request, #14605: URL: https://github.com/apache/lucene/pull/14605 * Numeric Multi-Range DocValues query (cherry picked from commit 2eeb71877da4cbbc3033fe9a2c0a18f03550a070) ### Description -- This is an automated message from the Apache

Re: [PR] MultiRange query for SortedNumeric DocValues [lucene]

2025-05-02 Thread via GitHub
mkhludnev merged PR #14404: URL: https://github.com/apache/lucene/pull/14404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

Re: [PR] OptimisticKnnVectorQuery [lucene]

2025-05-02 Thread via GitHub
benwtrent commented on PR #14226: URL: https://github.com/apache/lucene/pull/14226#issuecomment-2848006782 I did a run over 4M vectors. One with bit quantization. In both cases, this optimistic pattern beats the baseline (sharing). Consistently, it gives better recall at better latency.

Re: [PR] Reduce NeighborArray heap memory [lucene]

2025-05-02 Thread via GitHub
benwtrent commented on PR #14527: URL: https://github.com/apache/lucene/pull/14527#issuecomment-2847706746 @weizijun It should be fixed. Having an estimation that is more than 2x off is pretty bad. this estimation is used to determine how often flushes should occur, etc.

Re: [PR] Change uses of withReadAdvice to use hints instead [lucene]

2025-05-02 Thread via GitHub
thecoop commented on code in PR #14510: URL: https://github.com/apache/lucene/pull/14510#discussion_r2071769318 ## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene50/Lucene50CompoundReader.java: ## @@ -74,7 +74,7 @@ public Lucene50CompoundReader(Directory

Re: [PR] Change uses of withReadAdvice to use hints instead [lucene]

2025-05-02 Thread via GitHub
thecoop commented on code in PR #14510: URL: https://github.com/apache/lucene/pull/14510#discussion_r2071743905 ## lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java: ## @@ -277,6 +277,32 @@ public final long getMaxChunkSize() { return 1L << chunkSizePower;

Re: [PR] Change uses of withReadAdvice to use hints instead [lucene]

2025-05-02 Thread via GitHub
thecoop commented on code in PR #14510: URL: https://github.com/apache/lucene/pull/14510#discussion_r2071743905 ## lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java: ## @@ -277,6 +277,32 @@ public final long getMaxChunkSize() { return 1L << chunkSizePower;

Re: [PR] Change uses of withReadAdvice to use hints instead [lucene]

2025-05-02 Thread via GitHub
thecoop commented on code in PR #14510: URL: https://github.com/apache/lucene/pull/14510#discussion_r2071728838 ## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene101/Lucene101PostingsReader.java: ## @@ -149,9 +150,9 @@ public Lucene101PostingsReader(Segm

Re: [PR] Change uses of withReadAdvice to use hints instead [lucene]

2025-05-02 Thread via GitHub
jpountz commented on code in PR #14510: URL: https://github.com/apache/lucene/pull/14510#discussion_r2071603158 ## lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java: ## @@ -277,6 +277,32 @@ public final long getMaxChunkSize() { return 1L << chunkSizePower;

Re: [PR] Change uses of withReadAdvice to use hints instead [lucene]

2025-05-02 Thread via GitHub
thecoop commented on code in PR #14510: URL: https://github.com/apache/lucene/pull/14510#discussion_r2071537608 ## lucene/test-framework/src/java/org/apache/lucene/tests/store/SerialIOCountingDirectory.java: ## @@ -72,7 +72,7 @@ public ChecksumIndexInput openChecksumInput(String

Re: [PR] [Bug] Fix for stored fields force merge regression [lucene]

2025-05-02 Thread via GitHub
benwtrent commented on PR #14512: URL: https://github.com/apache/lucene/pull/14512#issuecomment-2847040963 I don't like the read-advice update, even for vectors (I am talking about the referenced PR). It seems we are trying to fix a self-inflicted bug. This has been an incredibly trap

Re: [I] gradle-wrapper.jar will not be updated when its sha/version changes [lucene]

2025-05-02 Thread via GitHub
ChrisHegarty commented on issue #14598: URL: https://github.com/apache/lucene/issues/14598#issuecomment-2846847520 I noticed problems with the gradle wrapper also, e.g. ``` ./gradlew check no main manifest attribute, in /Users/chegar/git/lucene/gradle/wrapper/gradle-wrapper.jar `

[PR] Add a preload hint for preloading mmap data on specific open calls [lucene]

2025-05-02 Thread via GitHub
thecoop opened a new pull request, #14604: URL: https://github.com/apache/lucene/pull/14604 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] Change uses of withReadAdvice to use hints instead [lucene]

2025-05-02 Thread via GitHub
thecoop commented on code in PR #14510: URL: https://github.com/apache/lucene/pull/14510#discussion_r2071325241 ## lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java: ## @@ -277,6 +277,32 @@ public final long getMaxChunkSize() { return 1L << chunkSizePower;

Re: [PR] Change uses of withReadAdvice to use hints instead [lucene]

2025-05-02 Thread via GitHub
ChrisHegarty commented on code in PR #14510: URL: https://github.com/apache/lucene/pull/14510#discussion_r2071306868 ## lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java: ## @@ -277,6 +277,32 @@ public final long getMaxChunkSize() { return 1L << chunkSizePower

Re: [PR] Speed up flush of softdelete by intoBitset [lucene]

2025-05-02 Thread via GitHub
jpountz commented on code in PR #14552: URL: https://github.com/apache/lucene/pull/14552#discussion_r2071284659 ## lucene/core/src/java/org/apache/lucene/index/SingletonSortedNumericDocValues.java: ## @@ -57,6 +58,16 @@ public int advance(int target) throws IOException { re

Re: [PR] Remove RANDOM_PRELOAD read advice, which is not actually used [lucene]

2025-05-02 Thread via GitHub
ChrisHegarty merged PR #14593: URL: https://github.com/apache/lucene/pull/14593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen