benwtrent commented on PR #14512: URL: https://github.com/apache/lucene/pull/14512#issuecomment-2847040963
I don't like the read-advice update, even for vectors (I am talking about the referenced PR). It seems we are trying to fix a self-inflicted bug. This has been an incredibly trappy API that has (it seems) provided nothing but woe. I have yet to see any prevailing evidence that changing read-advice for MMAP has provided any benefit at all :(. The actual fix seems to be fixing the underlying APIs: https://github.com/apache/lucene/pull/14510 I do not like the idea of updating a very general format API (stored fields) to fix an esoteric bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
