thecoop commented on code in PR #14510:
URL: https://github.com/apache/lucene/pull/14510#discussion_r2071537608


##########
lucene/test-framework/src/java/org/apache/lucene/tests/store/SerialIOCountingDirectory.java:
##########
@@ -72,7 +72,7 @@ public ChecksumIndexInput openChecksumInput(String name) 
throws IOException {
 
   @Override
   public IndexInput openInput(String name, IOContext context) throws 
IOException {
-    ReadAdvice readAdvice = 
context.readAdvice().orElse(Constants.DEFAULT_READADVICE);
+    ReadAdvice readAdvice = MMapDirectory.toReadAdvice(context);

Review Comment:
   @jpountz Are these tests necessary as-is, or can they be removed & replaced 
with some other check?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to