Jinny-Wang commented on issue #14565: URL: https://github.com/apache/lucene/issues/14565#issuecomment-2848301176
With more explorations in the code, I think it would be cleaner to just introduce a new query operator instead of trying to wrap both parentQuery and childQuery in ToChildBlockJoinQuery. - The current ToChildBlockJoinQuery uses [FilterWeight](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/search/FilterWeight.java) which only support one contained weight. If we start introducing another query, we will need 2 contained weights. Which means a custom `Weight` class would be required that does not extend the `FilterWeight`. This would make it harder to be 100% backward compatible with current code behavior. - The current score uses just the parentQuery's score to score. Introduction of childQuery will open up the option to use childQuery score / childQuery combined with parentQuery score etc. If we want to make the scoring behavior configurable, that's even more customization on top of exiting ToChildBlockJoinQuery. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
