ChrisHegarty commented on code in PR #14510:
URL: https://github.com/apache/lucene/pull/14510#discussion_r2071306868
##########
lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java:
##########
@@ -277,6 +277,32 @@ public final long getMaxChunkSize() {
return 1L << chunkSizePower;
}
+ public static ReadAdvice toReadAdvice(IOContext context) {
Review Comment:
Actually, this seems more like it's a default implementation of a static
READ_ADVICE function, similar to other override-defaults pattern in this class.
Otherwise, the user cannot override with empty, since the chaining will
delegate.
##########
lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java:
##########
@@ -277,6 +277,32 @@ public final long getMaxChunkSize() {
return 1L << chunkSizePower;
}
+ public static ReadAdvice toReadAdvice(IOContext context) {
Review Comment:
Can you please add some javadoc for the public method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
