jainankitk commented on code in PR #13923:
URL: https://github.com/apache/lucene/pull/13923#discussion_r2038859997
##
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##
@@ -819,17 +819,11 @@ private void freezeTail(int prefixLenPlus1) throws
IOException {
vsop-479 commented on code in PR #13923:
URL: https://github.com/apache/lucene/pull/13923#discussion_r2038747491
##
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##
@@ -828,7 +828,8 @@ private void freezeTail(int prefixLenPlus1) throws
IOException {
/
stefanvodita commented on code in PR #14453:
URL: https://github.com/apache/lucene/pull/14453#discussion_r2033640237
##
lucene/core/src/java/org/apache/lucene/search/ConjunctionDISI.java:
##
@@ -127,6 +127,8 @@ static DocIdSetIterator createConjunction(
if (iterators.size()
github-actions[bot] commented on PR #14409:
URL: https://github.com/apache/lucene/pull/14409#issuecomment-2795484469
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
jainankitk commented on PR #14474:
URL: https://github.com/apache/lucene/pull/14474#issuecomment-2795420056
> Thank you for the prompt response! Could you also add an entry in
CHANGES.txt?
Thank you for a prompt review. Added the entry to CHANGES.txt
--
This is an automated message
stefanvodita commented on code in PR #14474:
URL: https://github.com/apache/lucene/pull/14474#discussion_r2038545565
##
lucene/core/src/java/org/apache/lucene/geo/ComponentTree.java:
##
@@ -26,6 +26,13 @@
* Construction takes {@code O(n log n)} time for sorting and tree
const
jainankitk commented on PR #14413:
URL: https://github.com/apache/lucene/pull/14413#issuecomment-2784727712
> It looks like it's trying to aggregate data differently for slice-level
operations vs. top-level operations, but we shouldn't do this anymore now that
we're breaking down by thread?
jpountz opened a new pull request, #14451:
URL: https://github.com/apache/lucene/pull/14451
This helps reduce pollymorphism of call sites to `DocIdSetIterator` methods.
Relates #14450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
jainankitk commented on code in PR #14413:
URL: https://github.com/apache/lucene/pull/14413#discussion_r2032069670
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/QueryProfilerTimingType.java:
##
@@ -21,16 +21,29 @@
/** This enum breaks down the query into differe
jpountz merged PR #14453:
URL: https://github.com/apache/lucene/pull/14453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
benwtrent commented on issue #14208:
URL: https://github.com/apache/lucene/issues/14208#issuecomment-2786605051
I was thinking more on this. What if we just wrote the "unoptimized" graph
(e.g. the full graph, with static connections) to a temporary file on disk,
then used OffHeap graph to b
jpountz commented on code in PR #14413:
URL: https://github.com/apache/lucene/pull/14413#discussion_r2031202618
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/QueryProfilerBreakdown.java:
##
@@ -17,46 +17,113 @@
package org.apache.lucene.sandbox.search;
+import
guojialiang92 commented on code in PR #14417:
URL: https://github.com/apache/lucene/pull/14417#discussion_r2032655178
##
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##
@@ -1427,6 +1427,25 @@ public synchronized void advanceSegmentInfosVersion(long
newVersion)
jainankitk commented on code in PR #14474:
URL: https://github.com/apache/lucene/pull/14474#discussion_r2038491526
##
lucene/core/src/java/org/apache/lucene/geo/ComponentTree.java:
##
@@ -26,6 +26,13 @@
* Construction takes {@code O(n log n)} time for sorting and tree
constru
jainankitk commented on code in PR #14474:
URL: https://github.com/apache/lucene/pull/14474#discussion_r2038470766
##
lucene/core/src/java/org/apache/lucene/geo/ComponentTree.java:
##
@@ -322,27 +317,7 @@ private static ComponentTree createTree(
}
final int mid = (low
jainankitk commented on code in PR #14474:
URL: https://github.com/apache/lucene/pull/14474#discussion_r2038461725
##
lucene/core/src/java/org/apache/lucene/geo/ComponentTree.java:
##
@@ -92,11 +99,9 @@ public boolean contains(double x, double y) {
}
}
if
stefanvodita commented on code in PR #14474:
URL: https://github.com/apache/lucene/pull/14474#discussion_r2038390465
##
lucene/core/src/java/org/apache/lucene/geo/ComponentTree.java:
##
@@ -92,11 +99,9 @@ public boolean contains(double x, double y) {
}
}
i
jpountz opened a new pull request, #14475:
URL: https://github.com/apache/lucene/pull/14475
This should help reduce polymorphism of `DocIdSetIterator` as doc values
would then only expose 2 classes as `DocIdSetIterator`s: dense iterators and
`IndexedDISI` for the sparse case.
This ch
rmuir merged PR #14473:
URL: https://github.com/apache/lucene/pull/14473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir merged PR #14472:
URL: https://github.com/apache/lucene/pull/14472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
jainankitk opened a new pull request, #14474:
URL: https://github.com/apache/lucene/pull/14474
### Description
Minor refactoring of `Comparator` in `ComponentTree`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
stefanvodita commented on PR #14369:
URL: https://github.com/apache/lucene/pull/14369#issuecomment-2795203223
I have been looking into this on my end as well. Agree that the issue arises
when we have a PR straddling different forks and it sounds like you have a good
theory about the underly
jpountz commented on code in PR #14448:
URL: https://github.com/apache/lucene/pull/14448#discussion_r2031962886
##
lucene/test-framework/src/java/org/apache/lucene/tests/search/AssertingScorable.java:
##
@@ -44,7 +44,7 @@ public void setMinCompetitiveScore(float minScore) throws
alecko85 closed pull request #117: Update spanish_stop.txt
URL: https://github.com/apache/lucene/pull/117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
jpountz opened a new pull request, #14453:
URL: https://github.com/apache/lucene/pull/14453
This introduces a new `AbstractDocIdSetIterator` abstract class that tracks
the current doc IDs and refactors several `DocIdSetIterator` implementations to
extend either this `AbstractDocIdSetIterato
jpountz opened a new issue, #14450:
URL: https://github.com/apache/lucene/issues/14450
Megamorphism of call sites to `DocIdSetIterator#nextDoc` and
`DocIdSetIterator#advance` hurts search performance. See e.g. annotation HJ at
https://benchmarks.mikemccandless.com/OrHighHigh.html where redu
guojialiang92 commented on issue #14423:
URL: https://github.com/apache/lucene/issues/14423#issuecomment-2785901346
Hi @benwtrent
Can I invite you to review this PR?
(I saw that you have commented on issue
[[13552](https://github.com/apache/lucene/issues/13552)] before.)
--
This is
jpountz commented on code in PR #14448:
URL: https://github.com/apache/lucene/pull/14448#discussion_r2031612400
##
lucene/test-framework/src/java/org/apache/lucene/tests/search/AssertingScorable.java:
##
@@ -44,7 +44,7 @@ public void setMinCompetitiveScore(float minScore) throws
jpountz merged PR #14451:
URL: https://github.com/apache/lucene/pull/14451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
rmuir opened a new pull request, #14473:
URL: https://github.com/apache/lucene/pull/14473
This should reduce noise and hassles as some packages such as pyright
release quite often.
I thought the dependencies would put up more of a fight, but it seems to be
in decent order.
--
This
rmuir merged PR #14468:
URL: https://github.com/apache/lucene/pull/14468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir commented on PR #14451:
URL: https://github.com/apache/lucene/pull/14451#issuecomment-2784489632
+1 to this idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
stefanvodita commented on PR #14453:
URL: https://github.com/apache/lucene/pull/14453#issuecomment-2790752699
Thank you for updating that comment!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
rmuir merged PR #14469:
URL: https://github.com/apache/lucene/pull/14469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
dsmiley commented on PR #14433:
URL: https://github.com/apache/lucene/pull/14433#issuecomment-2795033321
The need is to incorporate a field's position length in a
composable/flexible relevance formula. A LongValues is the way to do that. I
understand a Lucene user could write a custom Sim
pseudo-nymous commented on PR #14369:
URL: https://github.com/apache/lucene/pull/14369#issuecomment-2794977827
I think I have found the cause of the failure. It's related to fork
repository checkout. When we checkout a fork's repository, github api gets
linked to forked repo while github ev
jainankitk commented on PR #14439:
URL: https://github.com/apache/lucene/pull/14439#issuecomment-2794969733
> I didn't mean to imply that the two solutions are the same, apologies if
that's how it came across.
Not at all. Even I was initially confused with skipper logic, only after
s
rmuir commented on PR #14467:
URL: https://github.com/apache/lucene/pull/14467#issuecomment-2794958761
declined in favor of #14472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
dependabot[bot] commented on PR #14467:
URL: https://github.com/apache/lucene/pull/14467#issuecomment-2794958149
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, le
rmuir closed pull request #14467: build(deps): bump six from 1.16.0 to 1.17.0
in /dev-tools/scripts
URL: https://github.com/apache/lucene/pull/14467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
rmuir merged PR #14471:
URL: https://github.com/apache/lucene/pull/14471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir merged PR #14470:
URL: https://github.com/apache/lucene/pull/14470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir opened a new pull request, #14472:
URL: https://github.com/apache/lucene/pull/14472
None of the python 2 compatibility functions provided by this library are in
use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
rmuir commented on PR #14467:
URL: https://github.com/apache/lucene/pull/14467#issuecomment-2794904580
We're not using this dependency at all. I'll make a PR to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
rmuir commented on PR #14466:
URL: https://github.com/apache/lucene/pull/14466#issuecomment-2794864030
No reason to rush this one, several major versions update with breaking
changes... let's do it eventually but not break our bot.
--
This is an automated message from the Apache Git Servi
rmuir commented on PR #14468:
URL: https://github.com/apache/lucene/pull/14468#issuecomment-2794881126
We've fallen behind on this dependency. There are 3 major breaking changes
listed in the 2.0 version:
https://github.com/PyGithub/PyGithub/releases/tag/v2.1.0.post0
* Timestamps
* Ne
dependabot[bot] closed pull request #14464: ci: bump actions/stale from 5 to 9
in the actions group
URL: https://github.com/apache/lucene/pull/14464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
dependabot[bot] commented on PR #14465:
URL: https://github.com/apache/lucene/pull/14465#issuecomment-2794826768
The group that created this PR has been removed from your configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dependabot[bot] opened a new pull request, #14469:
URL: https://github.com/apache/lucene/pull/14469
Bumps [jira](https://github.com/pycontribs/jira) from 3.4.1 to 3.8.0.
Release notes
Sourced from https://github.com/pycontribs/jira/releases";>jira's releases.
v3.8.0
Minor
dependabot[bot] opened a new pull request, #14471:
URL: https://github.com/apache/lucene/pull/14471
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.9.10 to 0.11.5.
Release notes
Sourced from https://github.com/astral-sh/ruff/releases";>ruff's releases.
0.11.5
Releas
dependabot[bot] opened a new pull request, #14470:
URL: https://github.com/apache/lucene/pull/14470
Bumps [console-menu](https://github.com/aegirhall/console-menu) from 0.7.1
to 0.8.0.
Release notes
Sourced from https://github.com/aegirhall/console-menu/releases";>console-menu's
r
dependabot[bot] opened a new pull request, #14468:
URL: https://github.com/apache/lucene/pull/14468
Bumps [pygithub](https://github.com/pygithub/pygithub) from 1.59.1 to 2.6.1.
Release notes
Sourced from https://github.com/pygithub/pygithub/releases";>pygithub's
releases.
v2
dependabot[bot] opened a new pull request, #14467:
URL: https://github.com/apache/lucene/pull/14467
Bumps [six](https://github.com/benjaminp/six) from 1.16.0 to 1.17.0.
Changelog
Sourced from https://github.com/benjaminp/six/blob/main/CHANGES";>six's
changelog.
1.17.0
dependabot[bot] opened a new pull request, #14466:
URL: https://github.com/apache/lucene/pull/14466
Bumps [actions/stale](https://github.com/actions/stale) from 5 to 9.
Release notes
Sourced from https://github.com/actions/stale/releases";>actions/stale's
releases.
v9.0.0
dependabot[bot] closed pull request #14465: build(deps): bump the pip group in
/dev-tools/scripts with 5 updates
URL: https://github.com/apache/lucene/pull/14465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
dependabot[bot] commented on PR #14464:
URL: https://github.com/apache/lucene/pull/14464#issuecomment-2794826732
The group that created this PR has been removed from your configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rmuir commented on PR #14465:
URL: https://github.com/apache/lucene/pull/14465#issuecomment-2794814815
This is too much at once, I will take care of the configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
dependabot[bot] opened a new pull request, #14465:
URL: https://github.com/apache/lucene/pull/14465
Bumps the pip group in /dev-tools/scripts with 5 updates:
| Package | From | To |
| --- | --- | --- |
| [six](https://github.com/benjaminp/six) | `1.16.0` | `1.17.0` |
| [consol
benwtrent merged PR #14424:
URL: https://github.com/apache/lucene/pull/14424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
rmuir commented on PR #14464:
URL: https://github.com/apache/lucene/pull/14464#issuecomment-2794786889
I don't know how to test this one: don't want to break our stale PR bot, but
there are very likely breaking changes between all these major versions.
--
This is an automated message from
rmuir commented on PR #14464:
URL: https://github.com/apache/lucene/pull/14464#issuecomment-2794782017
> The following labels could not be found: `dependencies`. Please create it
before Dependabot can add it to a pull request.
Created the label.
--
This is an automated message from
vigyasharma closed issue #1: Add an IndexDeletion policy that retains the
last N commits
URL: https://github.com/apache/lucene/issues/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
dependabot[bot] opened a new pull request, #14464:
URL: https://github.com/apache/lucene/pull/14464
Bumps the actions group with 1 update:
[actions/stale](https://github.com/actions/stale).
Updates `actions/stale` from 5 to 9
Release notes
Sourced from https://github.com/act
dependabot[bot] commented on PR #14464:
URL: https://github.com/apache/lucene/pull/14464#issuecomment-2794775850
### Labels
The following labels could not be found: `dependencies`. Please create it
before Dependabot can add it to a pull request.
Please fix the above issues
rmuir merged PR #14462:
URL: https://github.com/apache/lucene/pull/14462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir commented on PR #14462:
URL: https://github.com/apache/lucene/pull/14462#issuecomment-2794769280
I will tune it and lower the frequency after we see it working, at least the
type checker releases quite frequently. So I expect a lot of noise at first,
but just want to get the kinks iro
stefanvodita commented on PR #14369:
URL: https://github.com/apache/lucene/pull/14369#issuecomment-2794729401
@pseudo-nymous, I'm curious if you had any new thoughts on this. I think to
test this properly, we would need two GitHub accounts each with their own fork
of a repo trying to open a
vigyasharma merged PR #14458:
URL: https://github.com/apache/lucene/pull/14458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene
hanbj commented on PR #14267:
URL: https://github.com/apache/lucene/pull/14267#issuecomment-2788396872
@gsmiller @jainankitk I haven't carefully studied the implementation of
benchmark sin Lucene too, which may take sometime.
--
This is an automated message from the Apache Git Service.
To
vigyasharma commented on PR #14443:
URL: https://github.com/apache/lucene/pull/14443#issuecomment-2784847156
> every 120 seconds, SearcherManager would pick the most recent commit that
differs by less than X GB
This is indeed how we anticipate it being used. In NRT style segment
repl
stefanvodita commented on PR #14439:
URL: https://github.com/apache/lucene/pull/14439#issuecomment-2794700870
I didn't mean to imply that the two solutions are the same, apologies if
that's how it came across.
> Need some inputs from the community on how it can be plugged correctly
i
dsmiley merged PR #14448:
URL: https://github.com/apache/lucene/pull/14448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
uschindler commented on PR #14457:
URL: https://github.com/apache/lucene/pull/14457#issuecomment-2792091824
I sit enough to only change that part so it affects all NRT tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
vigyasharma commented on code in PR #14458:
URL: https://github.com/apache/lucene/pull/14458#discussion_r2037483241
##
lucene/core/src/java/org/apache/lucene/index/KeepLastNCommitsDeletionPolicy.java:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
jainankitk commented on code in PR #13923:
URL: https://github.com/apache/lucene/pull/13923#discussion_r2037877322
##
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##
@@ -828,7 +828,8 @@ private void freezeTail(int prefixLenPlus1) throws
IOException {
guojialiang92 commented on PR #14424:
URL: https://github.com/apache/lucene/pull/14424#issuecomment-2791934887
Thank you @aoli-al, looking forward to the reviewer merging this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
rmuir commented on issue #14454:
URL: https://github.com/apache/lucene/issues/14454#issuecomment-2793452334
Thanks @uschindler this will definitely help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
0ctopus13prime commented on PR #11998:
URL: https://github.com/apache/lucene/pull/11998#issuecomment-2790785517
@rmuir
Hi Robert, just curious what is the contract of calling `close` of cloned
stored fields?
Codec reader gets stored fields in
[here](https://github.com/apache/lucene/b
gf2121 opened a new pull request, #14461:
URL: https://github.com/apache/lucene/pull/14461
It seems a concurrency issue occured :)
1. I raised #14460 to correct the generation of bwc indices.
2. @iverase generated bwc indices for 10.2 with old code.
3. I merged the PR.
Thi
0ctopus13prime commented on PR #11998:
URL: https://github.com/apache/lucene/pull/11998#issuecomment-2794392585
@rmuir
Thank you for sharing! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
bharath-techie opened a new issue, #14463:
URL: https://github.com/apache/lucene/issues/14463
### Description
We have observed force merge of stored fields opened with `MMAPDirectory` /
`MemorySegmentIndexInput` regressing between 50% and 100% in Lucene 10.0
compared to Lucene 9.12.
owaiskazi19 commented on code in PR #14458:
URL: https://github.com/apache/lucene/pull/14458#discussion_r2037737435
##
lucene/core/src/java/org/apache/lucene/index/KeepLastNCommitsDeletionPolicy.java:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
uschindler commented on issue #14454:
URL: https://github.com/apache/lucene/issues/14454#issuecomment-2793373807
I created a linux job for now. Maybe I will change the "normal" job later to
put "nightly" into the randomization to not have so many duplicates. But this
helps for now.
W
rmuir opened a new pull request, #14462:
URL: https://github.com/apache/lucene/pull/14462
These dependencies are not pinned which can cause lack of reproducibility.
Pin the direct dependencies and configure the dependabot. Clear up lint issues
with most recent versions of checkers.
H
jpountz commented on PR #14443:
URL: https://github.com/apache/lucene/pull/14443#issuecomment-2793132821
Sorry I'm still a bit confused: how is this approach better than just
committing more frequently, replicating commits as soon as they are created,
and refreshing searchers as soon as com
gf2121 merged PR #14461:
URL: https://github.com/apache/lucene/pull/14461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
rmuir commented on issue #14454:
URL: https://github.com/apache/lucene/issues/14454#issuecomment-2792808800
Yeah, that would be awesome! I'm not sure how much these tests are getting
exercised today... these problems seem to surface during release votes.
--
This is an automated message fr
uschindler commented on issue #14454:
URL: https://github.com/apache/lucene/issues/14454#issuecomment-2792782711
I will setup nightly runs on policeman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
uschindler commented on PR #14457:
URL: https://github.com/apache/lucene/pull/14457#issuecomment-2792554897
> > Is it enough to only change that part so it affects all NRT tests?
>
> Yes, this is the only place creating Sockets there. Also, I didn't touch
any ServerSocket as that's di
rmuir commented on issue #14454:
URL: https://github.com/apache/lucene/issues/14454#issuecomment-2792764676
I'm keeping this issue open as I'm not sure what the test will do, if it
encounters the same condition. I'm hoping it fails, and even better if that
reproduces... and then we can try
rmuir commented on PR #14433:
URL: https://github.com/apache/lucene/pull/14433#issuecomment-2792476458
I don't have any suggestion, I don't see the need for users to try to
reimplement Similarity with valuesources.
--
This is an automated message from the Apache Git Service.
To respond to
rmuir commented on issue #14454:
URL: https://github.com/apache/lucene/issues/14454#issuecomment-2792577247
I'm not sure if the test has killed all the JVMs yet in this case or not.
Not sure where the connections are going and coming, maybe the node is
attempting to search itself?
Al
rmuir commented on PR #14457:
URL: https://github.com/apache/lucene/pull/14457#issuecomment-2792564423
Yeah, we can look into it separately. It is different and is timeout for
`accept()` calls only IIRC. I haven't looked at the way these tests manage
connections, but it is not implicated in
rmuir merged PR #14457:
URL: https://github.com/apache/lucene/pull/14457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir commented on PR #14457:
URL: https://github.com/apache/lucene/pull/14457#issuecomment-2792522271
> Is it enough to only change that part so it affects all NRT tests?
Yes, this is the only place creating Sockets there.
Also, I didn't touch any ServerSocket as that's different a
benwtrent commented on PR #14424:
URL: https://github.com/apache/lucene/pull/14424#issuecomment-2792484703
I think this change is fine and prevents some flakiness :). I will merge and
backport to 10x.
--
This is an automated message from the Apache Git Service.
To respond to the message,
gf2121 merged PR #14460:
URL: https://github.com/apache/lucene/pull/14460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
gf2121 closed issue #14456: TestInt7HnswBackwardsCompatibility fails when new
codec introduced
URL: https://github.com/apache/lucene/issues/14456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gf2121 opened a new pull request, #14460:
URL: https://github.com/apache/lucene/pull/14460
https://github.com/apache/lucene/pull/14333 has included the zip and CI
passed.
I think we should backport to `branch_10x`, but not sure if it should be
port to `branch_10_1` / `branch_10_2` ?
uschindler commented on issue #14454:
URL: https://github.com/apache/lucene/issues/14454#issuecomment-2792089535
Thanks Robert, this are good investigations. It is still unclear why the
socket read hangs on a localhost connection, but indeed you never know. Out of
file handles, another VM d
1 - 100 of 101 matches
Mail list logo
