jainankitk commented on code in PR #13923:
URL: https://github.com/apache/lucene/pull/13923#discussion_r2037877322
##########
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##########
@@ -828,7 +828,8 @@ private void freezeTail(int prefixLenPlus1) throws
IOException {
// FSTEnum, Util, etc., have trouble w/ non-final
// dead-end states:
- // TODO: is node.numArcs == 0 always false? we no longer prune any
nodes from FST:
+ // node.numArcs == 0 happens on last node. But it is final, we still can
remove node.numArcs
+ // == 0.
final boolean isFinal = node.isFinal || node.numArcs == 0;
Review Comment:
Should we also remove `node.numArcs == 0` if removing TODO?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
