jainankitk commented on PR #14413:
URL: https://github.com/apache/lucene/pull/14413#issuecomment-2784727712
> It looks like it's trying to aggregate data differently for slice-level
operations vs. top-level operations, but we shouldn't do this anymore now that
we're breaking down by thread?
IMO, `QuerySliceProfilerBreakdown` and `sliceLevel` in
`QueryProfilerTimingType` just declare which metrics can be collected at
`sliceLevel` vs `queryLevel`. The specific implementation of
`QueryProfileBreakdown` we have, provides per thread aggregated view for these
slices. Tomorrow if we have separate implementation of `QueryProfileBreakdown`,
that does not aggregate slices together, that can continue to use the same
specifications. Maybe we can add thin layer like below to make things more
explicit and clear, not sure if it is needed though:
```
public class QueryThreadProfilerBreakdown extends
QuerySliceProfilerBreakdown {}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
