jainankitk commented on code in PR #14413:
URL: https://github.com/apache/lucene/pull/14413#discussion_r2032069670
##########
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/QueryProfilerTimingType.java:
##########
@@ -21,16 +21,29 @@
/** This enum breaks down the query into different sections to describe what
was timed. */
public enum QueryProfilerTimingType {
- CREATE_WEIGHT,
- COUNT,
- BUILD_SCORER,
- NEXT_DOC,
- ADVANCE,
- MATCH,
- SCORE,
- SHALLOW_ADVANCE,
- COMPUTE_MAX_SCORE,
- SET_MIN_COMPETITIVE_SCORE;
+ COUNT(true),
+ BUILD_SCORER(true),
+ NEXT_DOC(true),
+ ADVANCE(true),
+ MATCH(true),
+ SCORE(true),
+ SHALLOW_ADVANCE(true),
+ COMPUTE_MAX_SCORE(true),
+ SET_MIN_COMPETITIVE_SCORE(true),
+
+ // IMPORTANT: Global timer types must be defined after all the
+ // slice level timers to preserve the contiguous enum ordinals
+ CREATE_WEIGHT(false);
+
+ private boolean sliceLevel;
Review Comment:
We still share the `CREATE_WEIGHT` metrics across slice worker threads at
every query level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
