rmuir commented on PR #13825:
URL: https://github.com/apache/lucene/pull/13825#issuecomment-2379139038
i dont think we should add methods to DataInput when we are only "trying to
use elsewhere". The method is only used from one place: PostingsUtil, lets move
it out
--
This is an automate
cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778438135
##
lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java:
##
@@ -156,6 +196,55 @@ private TopDocs getLeafResults(
}
}
+ private DocId
msokolov opened a new issue, #13829:
URL: https://github.com/apache/lucene/issues/13829
### Description
I've noticed that some tests fail when `tests.iters` is set to a highish
value (like 20) because stdout grows above the allowed threshold. I assume this
is something we'd want to f
dweiss commented on PR #13825:
URL: https://github.com/apache/lucene/pull/13825#issuecomment-2379761858
Folks, if you'd like to do anything larger to this, please go ahead. I'm
with very limited access to the internet this week and I won't be able to track
your comments closely or make any
cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778462654
##
lucene/core/src/test/org/apache/lucene/document/TestManyKnnDocs.java:
##
@@ -46,27 +54,139 @@ public void testLargeSegment() throws Exception {
mp.setMaxMer
stefanvodita commented on PR #12547:
URL: https://github.com/apache/lucene/pull/12547#issuecomment-237933
I'm not sure either. Since the new aggregation engine is in sandbox, it
makes sense to keep developing the old aggregation engine. On the other hand,
that's not very productive if w
gsmiller commented on PR #12547:
URL: https://github.com/apache/lucene/pull/12547#issuecomment-2379648625
@stefanvodita do you think this change is still worth moving forward after
the new sandbox faceting implementation was added? Being able to compute an
arbitrary number of aggregations i
benwtrent commented on PR #13827:
URL: https://github.com/apache/lucene/pull/13827#issuecomment-2379478454
I wonder if this is much faster than auto-vectorization provided by the JVM
on AVX256 & 512
ARM does have an issue with vectorizing long values.
--
This is an automated messag
benwtrent commented on PR #13635:
URL: https://github.com/apache/lucene/pull/13635#issuecomment-2379026129
Thinking more and more, I do not like the idea of adding to the leaf
function definition.
But, this does seem useful. I think we can attach it to kNN collectors.
I don't
msokolov commented on issue #13829:
URL: https://github.com/apache/lucene/issues/13829#issuecomment-2379179445
Example failing test output:
```
org.apache.lucene.demo.TestDemo.classMethod (:lucene:demo)
cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778417770
##
lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java:
##
@@ -608,6 +614,94 @@ public void testRandomWithFilter() throws IOException {
cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778399477
##
lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java:
##
@@ -608,6 +614,94 @@ public void testRandomWithFilter() throws IOException {
msokolov commented on issue #13829:
URL: https://github.com/apache/lucene/issues/13829#issuecomment-2379202588
There is something about the way
`TestDocInverterPerFieldErrorInfo.testNoExtraNoise` captures the info-stream
that causes it to always fail when `test.iters` > 1. This whole situa
easyice commented on PR #13825:
URL: https://github.com/apache/lucene/pull/13825#issuecomment-2379114801
> the current readGroupVInts is also pretty specific to what the postings
are doing. And it just calls readVint() and readGroupVint() behind the scenes.
Seems like a good candidate to mo
cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778468665
##
lucene/core/src/test/org/apache/lucene/document/TestManyKnnDocs.java:
##
@@ -46,27 +54,139 @@ public void testLargeSegment() throws Exception {
mp.setMaxMer
cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778463376
##
lucene/core/src/test/org/apache/lucene/document/TestManyKnnDocs.java:
##
@@ -46,27 +54,139 @@ public void testLargeSegment() throws Exception {
mp.setMaxMer
cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778453629
##
lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java:
##
@@ -156,6 +196,49 @@ private TopDocs getLeafResults(
}
}
+ private DocId
easyice commented on code in PR #13828:
URL: https://github.com/apache/lucene/pull/13828#discussion_r1778298810
##
lucene/core/src/java/org/apache/lucene/util/bkd/DocIdsWriter.java:
##
@@ -205,12 +208,16 @@ void readInts(IndexInput in, int count, int[] docIDs)
throws IOExceptio
rmuir commented on PR #13825:
URL: https://github.com/apache/lucene/pull/13825#issuecomment-2379010887
the current readGroupVInts is also pretty specific to what the postings are
doing. And it just calls readVint() and readGroupVint() behind the scenes.
Seems like a good candidate to move t
cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778436381
##
lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java:
##
@@ -156,6 +196,55 @@ private TopDocs getLeafResults(
}
}
+ private DocId
cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778422918
##
lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java:
##
@@ -608,6 +614,94 @@ public void testRandomWithFilter() throws IOException {
cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778419593
##
lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java:
##
@@ -608,6 +614,94 @@ public void testRandomWithFilter() throws IOException {
cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778412763
##
lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java:
##
@@ -608,6 +614,94 @@ public void testRandomWithFilter() throws IOException {
seanmacavaney commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778379250
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/Lucene94HnswVectorsReader.java:
##
@@ -283,11 +289,17 @@ public void search(String
cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778218742
##
lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java:
##
@@ -156,6 +196,55 @@ private TopDocs getLeafResults(
}
}
+ private DocId
easyice commented on code in PR #13828:
URL: https://github.com/apache/lucene/pull/13828#discussion_r1778298810
##
lucene/core/src/java/org/apache/lucene/util/bkd/DocIdsWriter.java:
##
@@ -205,12 +208,16 @@ void readInts(IndexInput in, int count, int[] docIDs)
throws IOExceptio
easyice commented on code in PR #13828:
URL: https://github.com/apache/lucene/pull/13828#discussion_r1778291944
##
lucene/core/src/java/org/apache/lucene/util/bkd/DocIdsWriter.java:
##
@@ -205,12 +208,16 @@ void readInts(IndexInput in, int count, int[] docIDs)
throws IOExceptio
cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778283453
##
lucene/test-framework/src/java/org/apache/lucene/tests/index/MismatchedLeafReader.java:
##
@@ -68,6 +71,28 @@ public CacheHelper getReaderCacheHelper() {
re
cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778255372
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsReader.java:
##
@@ -247,7 +248,12 @@ public ByteVectorValues getByteVectorValues(String
cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778254222
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/Lucene94HnswVectorsReader.java:
##
@@ -283,11 +289,17 @@ public void search(String fie
cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778226954
##
lucene/core/src/java/org/apache/lucene/search/KnnByteVectorQuery.java:
##
@@ -133,4 +149,18 @@ public int hashCode() {
public byte[] getTargetCopy() {
re
cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778226954
##
lucene/core/src/java/org/apache/lucene/search/KnnByteVectorQuery.java:
##
@@ -133,4 +149,18 @@ public int hashCode() {
public byte[] getTargetCopy() {
re
gf2121 commented on code in PR #13828:
URL: https://github.com/apache/lucene/pull/13828#discussion_r1778204945
##
lucene/core/src/java/org/apache/lucene/util/bkd/DocIdsWriter.java:
##
@@ -36,6 +38,7 @@ final class DocIdsWriter {
private static final byte LEGACY_DELTA_VINT = (
cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778221739
##
lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java:
##
@@ -156,6 +196,55 @@ private TopDocs getLeafResults(
}
}
+ private DocId
cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778215992
##
lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java:
##
@@ -156,6 +196,55 @@ private TopDocs getLeafResults(
}
}
+ private DocId
cpoerschke commented on code in PR #13635:
URL: https://github.com/apache/lucene/pull/13635#discussion_r1778215267
##
lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java:
##
@@ -156,6 +196,55 @@ private TopDocs getLeafResults(
}
}
+ private DocId
36 matches
Mail list logo
