dweiss commented on code in PR #13142:
URL: https://github.com/apache/lucene/pull/13142#discussion_r1505502212
##
lucene/replicator/src/java/org/apache/lucene/replicator/nrt/PrimaryNode.java:
##
@@ -158,10 +158,7 @@ public long getPrimaryGen() {
*/
public boolean flushAnd
dweiss commented on code in PR #13142:
URL: https://github.com/apache/lucene/pull/13142#discussion_r1505494792
##
lucene/core/src/java/org/apache/lucene/util/VirtualMethod.java:
##
@@ -100,7 +98,7 @@ public VirtualMethod(Class baseClass, String method,
Class... parameters)
guojialiang92 commented on PR #13017:
URL: https://github.com/apache/lucene/pull/13017#issuecomment-1968390042
> Thanks! Could you also look at the CHANGES entry I had mentioned? We want
to record the fix and credit you for the work.
Thanks, I have add entry to CHANGES.txt.
--
This
guojialiang92 commented on code in PR #13017:
URL: https://github.com/apache/lucene/pull/13017#discussion_r1505452744
##
lucene/core/src/java/org/apache/lucene/index/ReadersAndUpdates.java:
##
@@ -782,13 +784,17 @@ synchronized MergePolicy.MergeReader
getReaderForMerge(IOContex
guojialiang92 commented on code in PR #13017:
URL: https://github.com/apache/lucene/pull/13017#discussion_r1505450205
##
lucene/core/src/test/org/apache/lucene/index/TestIndexWriterMergePolicy.java:
##
@@ -950,4 +957,354 @@ public void setMergeInfo(SegmentCommitInfo info) {
guojialiang92 commented on code in PR #13017:
URL: https://github.com/apache/lucene/pull/13017#discussion_r1505447216
##
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##
@@ -3935,7 +3935,11 @@ public void setMergeInfo(SegmentCommitInfo info) {
/
vsop-479 commented on PR #13072:
URL: https://github.com/apache/lucene/pull/13072#issuecomment-1968284534
> I think the optimization may be similar to the one done in
AutomatonTermsEnum?
Thanks for reminding that, I will dig into `AutomatonTermsEnum`'s
optimization.
--
This is an
rmuir commented on PR #13072:
URL: https://github.com/apache/lucene/pull/13072#issuecomment-1968087576
I think the optimization may be similar to the one done in
AutomatonTermsEnum?
https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/index/AutomatonTermsEnu
vsop-479 commented on PR #13072:
URL: https://github.com/apache/lucene/pull/13072#issuecomment-1968078407
@mikemccand Thanks for you suggestion, I am trying to implement it.
> Have you tried to measure any performance change with this? E.g. you could
run a luceneutil benchy with just Pre
dungba88 commented on PR #12985:
URL: https://github.com/apache/lucene/pull/12985#issuecomment-1968041186
I've updated to use temp IndexOutput and modify the test. It seems to be
working now. I'm open for suggestion of the default block heap threshold and
how to configure it.
--
This is
dungba88 commented on PR #12980:
URL: https://github.com/apache/lucene/pull/12980#issuecomment-1968037819
Thanks @mikemccand for the clarification!
Do you think we should still make this change? One benefit is that it can be
used for reference. Otherwise I'll close this PR
--
This
mrkm4ntr commented on PR #13066:
URL: https://github.com/apache/lucene/pull/13066#issuecomment-1968035921
Thanks. The result is here.
```
TaskQPS baseline StdDevQPS
my_modified_version StdDevPct diff p-value
AndM
dungba88 commented on PR #12985:
URL: https://github.com/apache/lucene/pull/12985#issuecomment-1967923651
Oh `Directory.deleteFile` is exactly what I needed! It's silly that I missed
that. I'll post another revision soon.
--
This is an automated message from the Apache Git Service.
To res
sabi0 opened a new pull request, #13142:
URL: https://github.com/apache/lucene/pull/13142
`ConcurrentHashMap.newKeySet()` provides better multi-threaded performance
thanks to judicious use of synchronization.
Also it does not require "external" synchronization for iteration.
--
Thi
dweiss commented on PR #13141:
URL: https://github.com/apache/lucene/pull/13141#issuecomment-1967491480
Ok. I think things can be improved but let's not make it too complicated at
the beginning. Everything seems to work:
 but I need to polish
a few things before it's worth of your time to review. Hopefully later tonight
or
dweiss commented on code in PR #13141:
URL: https://github.com/apache/lucene/pull/13141#discussion_r1504572039
##
dev-tools/scripts/smokeTestRelease.py:
##
@@ -158,9 +158,9 @@ def checkJARMetaData(desc, jarFile, gitRevision, version):
break
else:
if le
dweiss opened a new pull request, #13141:
URL: https://github.com/apache/lucene/pull/13141
This is an initial attempt to run a gh workflow to at least make sure these
two scripts work and things are building. For the time being, I've omitted the
tests entirely - nightly tests OOM on gh infr
sabi0 opened a new pull request, #13140:
URL: https://github.com/apache/lucene/pull/13140
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
mikemccand commented on issue #13116:
URL: https://github.com/apache/lucene/issues/13116#issuecomment-1966918485
I like that proposed solution @easyice! Exception handling is hard. Likely
many Lucene tests are missing/failing to catch `UncheckedIOException` now...
--
This is an automate
stefanvodita commented on PR #13017:
URL: https://github.com/apache/lucene/pull/13017#issuecomment-1966914429
Thanks! Could you also look at the CHANGES entry I had mentioned? We want to
record the fix and credit you for the work.
--
This is an automated message from the Apache Git Servic
mikemccand commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1504523798
##
lucene/core/src/java/org/apache/lucene/util/automaton/Automaton.java:
##
@@ -92,6 +93,7 @@ public Automaton() {
public Automaton(int numStates, int numTransit
mikemccand commented on PR #13072:
URL: https://github.com/apache/lucene/pull/13072#issuecomment-1966886223
I will have a look -- thanks for the ping @jpountz.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
mikemccand commented on PR #12985:
URL: https://github.com/apache/lucene/pull/12985#issuecomment-1966874257
And you can use the `IndexOutput.getName()` to get the `String` name of the
temp file, and delete that file (prolly in a `finally` clause in case disaster
strikes) using `Directory.de
mikemccand commented on PR #12985:
URL: https://github.com/apache/lucene/pull/12985#issuecomment-1966868122
Hmm, the `.tmp` file should never be part of the file set for the actual
segment? It should be transient, and then re-copied into the final result (the
actual block tree file that st
dungba88 commented on PR #12985:
URL: https://github.com/apache/lucene/pull/12985#issuecomment-1966740284
If there is a way to create temp file outside of the search index, then it
would work too, but I can't find it as all I/O are accessible from
`SegmentWriteState.directory`.
--
This i
dungba88 commented on PR #13054:
URL: https://github.com/apache/lucene/pull/13054#issuecomment-1966724748
I realized I also need the `saveMetadata` change for
https://github.com/apache/lucene/pull/12985. Do you think we should make it a
standalone PR and merge first? Otherwise I've cherry-p
rmuir commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1966604919
Thank you for merging!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
mkhludnev closed pull request #12157: Reproduce multi-word synonym regression
(SOLR-16652)
URL: https://github.com/apache/lucene/pull/12157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
dungba88 commented on PR #12985:
URL: https://github.com/apache/lucene/pull/12985#issuecomment-1966513989
@mikemccand I tried to use `createTempOutput` when the size is beyond some
threshold. The logic works, but I got this exception
```
java.lang.IllegalArgumentException: invalid
uschindler commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1966464023
Hi @rmuir @stefanvodita: I merged main branch into this and resolved the
conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
uschindler commented on code in PR #13139:
URL: https://github.com/apache/lucene/pull/13139#discussion_r1504141136
##
dev-tools/scripts/smokeTestRelease.py:
##
@@ -39,6 +39,8 @@
from collections import namedtuple
import scriptutil
+BASE_JAVA_VERSION = "17"
Review Comment:
uschindler commented on PR #13139:
URL: https://github.com/apache/lucene/pull/13139#issuecomment-1966429392
Thanks for merging this :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
uschindler commented on PR #13139:
URL: https://github.com/apache/lucene/pull/13139#issuecomment-1966427942
Sorry for last 2 commits. In 9.x the CONTRIBUTING.md was missing. All fine.
Sorry for this.
I compared both files, all is fine and minor changes are expected.
--
This is an a
uschindler commented on PR #13139:
URL: https://github.com/apache/lucene/pull/13139#issuecomment-1966421869
I will just push the change to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
uschindler commented on PR #13139:
URL: https://github.com/apache/lucene/pull/13139#issuecomment-1966420051
Thanks, I compared the 9.x and main branch smoke tester. The files are
identical with some minor differences:
- The 9.x checks for `CONTRIBUTING.md` to be available in root folder,
stefanvodita commented on PR #13139:
URL: https://github.com/apache/lucene/pull/13139#issuecomment-1966411565
Thanks all - merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
stefanvodita commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1966411059
I have. The diff looks correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
stefanvodita merged PR #13139:
URL: https://github.com/apache/lucene/pull/13139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
rmuir commented on code in PR #13139:
URL: https://github.com/apache/lucene/pull/13139#discussion_r1504126264
##
dev-tools/scripts/smokeTestRelease.py:
##
@@ -39,6 +39,8 @@
from collections import namedtuple
import scriptutil
+BASE_JAVA_VERSION = "17"
Review Comment:
Tha
dweiss commented on PR #13139:
URL: https://github.com/apache/lucene/pull/13139#issuecomment-1966405336
Please merge this, I'll just follow-up on top of that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
uschindler commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1966395258
The other PR looks straight-forward to me. Have you compared the two files
directly after merging? They should be mostly identical and only the
BASE_VERSION line should be different.
uschindler commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1966393719
> Here it is: #13139. I wasn't sure about the difficulties @dweiss was
encountering - I expect this to just work.
I think Dawid's problems were preexisting, not related to this
mkhludnev merged PR #13138:
URL: https://github.com/apache/lucene/pull/13138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
stefanvodita commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1966359649
Here it is: #13139.
I wasn't sure about the difficulties @dweiss was encountering - I expect
this to just work.
--
This is an automated message from the Apache Git Service.
To
stefanvodita opened a new pull request, #13139:
URL: https://github.com/apache/lucene/pull/13139
Like #13108, but targeting the `main` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
uschindler commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1966353181
Will you forward port the patch to main branch? I can help with that, have
some freetime.
This will allow us to make everything Java 21 ready tomorrow, so we have one
file less
stefanvodita merged PR #13108:
URL: https://github.com/apache/lucene/pull/13108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
mkhludnev opened a new pull request, #13138:
URL: https://github.com/apache/lucene/pull/13138
### Description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mkhludnev merged PR #13137:
URL: https://github.com/apache/lucene/pull/13137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
mkhludnev merged PR #13136:
URL: https://github.com/apache/lucene/pull/13136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
benwtrent commented on code in PR #13124:
URL: https://github.com/apache/lucene/pull/13124#discussion_r1503892704
##
lucene/core/src/java/org/apache/lucene/index/ConcurrentMergeScheduler.java:
##
@@ -910,4 +936,58 @@ public void setSuppressExceptions(ConcurrentMergeScheduler
cm
uschindler commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1966098725
> I don't think it's going to be so easy - some things just didn't work for
me with local artifacts. I'll follow up, perhaps tomorrow.
That was always a problem, I know. Therefo
mkhludnev commented on PR #13117:
URL: https://github.com/apache/lucene/pull/13117#issuecomment-1966091179
I think it doesn't need to be mentioned in CHANGES
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
mkhludnev merged PR #13117:
URL: https://github.com/apache/lucene/pull/13117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
mkhludnev opened a new pull request, #13137:
URL: https://github.com/apache/lucene/pull/13137
backport (#13077) #13136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
mkhludnev opened a new pull request, #13136:
URL: https://github.com/apache/lucene/pull/13136
move #13077 under 9.11.0
### Description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mkhludnev commented on PR #13077:
URL: https://github.com/apache/lucene/pull/13077#issuecomment-1966073356
aaahgg... wrong CHANGES.. going to move in unde 9.11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
mkhludnev merged PR #13077:
URL: https://github.com/apache/lucene/pull/13077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
61 matches
Mail list logo
