dweiss commented on code in PR #13142:
URL: https://github.com/apache/lucene/pull/13142#discussion_r1505494792
##########
lucene/core/src/java/org/apache/lucene/util/VirtualMethod.java:
##########
@@ -100,7 +98,7 @@ public VirtualMethod(Class<C> baseClass, String method,
Class<?>... parameters)
this.method = method;
this.parameters = parameters;
try {
- if (!singletonSet.add(baseClass.getDeclaredMethod(method, parameters)))
Review Comment:
This isn't enforced, but many people in this project prefer the verbose
comparison instead of the negation - please don't correct this, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
