dweiss commented on code in PR #13141:
URL: https://github.com/apache/lucene/pull/13141#discussion_r1504572039
##########
dev-tools/scripts/smokeTestRelease.py:
##########
@@ -158,9 +158,9 @@ def checkJARMetaData(desc, jarFile, gitRevision, version):
break
else:
if len(verify) == 1:
- raise RuntimeError('%s is missing "%s" inside its
META-INF/MANIFEST.MF' % (desc, verify[0]))
+ raise RuntimeError('%s is missing "%s" inside its
META-INF/MANIFEST.MF: %s' % (desc, verify[0], s))
Review Comment:
I added dumping manifest content here, since I had some trouble getting
X-Build-JDK to pass.
##########
dev-tools/scripts/smokeTestRelease.py:
##########
@@ -577,7 +577,7 @@ def verifyUnpacked(java, artifact, unpackPath, gitRevision,
version, testArgs):
# raise RuntimeError('lucene: file "%s" is missing from artifact %s' %
(fileName, artifact))
# in_root_folder.remove(fileName)
- expected_folders = ['analysis', 'analysis.tests', 'backward-codecs',
'benchmark', 'classification', 'codecs', 'core', 'core.tests',
+ expected_folders = ['analysis', 'analysis.tests', 'backward-codecs',
'benchmark', 'benchmark-jmh', 'classification', 'codecs', 'core', 'core.tests',
Review Comment:
Added benchmark-jmh, not present on branch_9x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
