dweiss commented on code in PR #13142:
URL: https://github.com/apache/lucene/pull/13142#discussion_r1505502212
##########
lucene/replicator/src/java/org/apache/lucene/replicator/nrt/PrimaryNode.java:
##########
@@ -158,10 +158,7 @@ public long getPrimaryGen() {
*/
public boolean flushAndRefresh() throws IOException {
message("top: now flushAndRefresh");
- Set<String> completedMergeFiles;
Review Comment:
I don't think this is semantically the same as iteration may be concurrent
to updates (while previously it was blocked for the time the set was cloned)...
I wonder whether it'll have an impact on runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
