gf2121 commented on PR #12775:
URL: https://github.com/apache/lucene/pull/12775#issuecomment-1797986285
Update:
* Make `MergeSorter` take advantage of `setPivot` to reduce decode.
* Fix the problem that `StringSorter#getFallBackSorter` did not use the
passed in comparator which can voi
dungba88 commented on issue #12771:
URL: https://github.com/apache/lucene/issues/12771#issuecomment-1797943566
I think
[nextInt(int)](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/random/RandomGenerator.html#nextInt(int))
and
[nextLong(long)](https://docs.oracle.co
dungba88 commented on code in PR #12778:
URL: https://github.com/apache/lucene/pull/12778#discussion_r1384477425
##
lucene/core/src/test/org/apache/lucene/util/TestByteBlockPool.java:
##
@@ -25,7 +24,34 @@
public class TestByteBlockPool extends LuceneTestCase {
- public vo
zhaih commented on code in PR #12767:
URL: https://github.com/apache/lucene/pull/12767#discussion_r1384459245
##
lucene/core/src/test/org/apache/lucene/search/TestRegexpQuery.java:
##
@@ -80,7 +80,10 @@ private long caseInsensitiveRegexQueryNrHits(String regex)
throws IOExcepti
dweiss commented on code in PR #12778:
URL: https://github.com/apache/lucene/pull/12778#discussion_r1384432877
##
lucene/core/src/test/org/apache/lucene/util/TestByteBlockPool.java:
##
@@ -25,7 +24,34 @@
public class TestByteBlockPool extends LuceneTestCase {
- public void
LuXugang commented on PR #12405:
URL: https://github.com/apache/lucene/pull/12405#issuecomment-1797551478
> Tests fail because the optimization kicks in in more cases than the test
expects, it's not clear to me yet if it's a bug or not.
You are correct @jpountz , the optimization kick
dungba88 opened a new pull request, #12778:
URL: https://github.com/apache/lucene/pull/12778
### Description
This fixes one of the TODO in https://github.com/apache/lucene/issues/12760
The random().nextInt is supposed to be banned, I'll use another API.
--
This is an automate
dungba88 commented on PR #12777:
URL: https://github.com/apache/lucene/pull/12777#issuecomment-1797338093
The test failed but it seems an intermittent error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
easyice commented on code in PR #12748:
URL: https://github.com/apache/lucene/pull/12748#discussion_r1384278875
##
lucene/core/src/java/org/apache/lucene/util/fst/FST.java:
##
@@ -96,6 +96,13 @@ public enum INPUT_TYPE {
*/
static final byte ARCS_FOR_DIRECT_ADDRESSING = 1
dungba88 opened a new pull request, #12777:
URL: https://github.com/apache/lucene/pull/12777
### Description
Closes #12759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
Tony-X commented on PR #12688:
URL: https://github.com/apache/lucene/pull/12688#issuecomment-1796863568
Just realized that we have lucene99 Codec out! I'll update the code to
reflect that as this posting format aims to work with the latest Codec.
--
This is an automated message from the A
twosom closed issue #12773: Resolve Duplicate CSVUtil Classes in Nori and
Kuromoji Analyzers (Backport)
URL: https://github.com/apache/lucene/issues/12773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
twosom commented on PR #12774:
URL: https://github.com/apache/lucene/pull/12774#issuecomment-1796532473
> `gradle check` passes for me locally ... I'll push this and not sort out
the Github actions. Thanks @twosom!
Thanks!
--
This is an automated message from the Apache Git Service
gsmiller commented on PR #181:
URL: https://github.com/apache/lucene/pull/181#issuecomment-1796392301
@mikemccand I'm going to close this out. I haven't worked on this in a while
now. Thanks for the ping!
--
This is an automated message from the Apache Git Service.
To respond to the messa
gsmiller closed pull request #181: LUCENE-10001: Make
CollectionTerminatedException handling in MultiCollector configurable
URL: https://github.com/apache/lucene/pull/181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
rmuir merged PR #12766:
URL: https://github.com/apache/lucene/pull/12766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
benwtrent commented on PR #12729:
URL: https://github.com/apache/lucene/pull/12729#issuecomment-1795961973
@jimczi thinking about it more, it seems to be a Flat* index format for
vector search will require a different API. Right now, kNN search assumes the
user provides pre-filters. However
dweiss commented on PR #12751:
URL: https://github.com/apache/lucene/pull/12751#issuecomment-1795953063
I pushed the requested changes, @s1monw . No rush, just wanted to let you
know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
slow-J opened a new pull request, #12776:
URL: https://github.com/apache/lucene/pull/12776
Minor javadoc changes to address the last comments from
https://github.com/apache/lucene/pull/12741
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
slow-J commented on code in PR #12741:
URL: https://github.com/apache/lucene/pull/12741#discussion_r1383744529
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99PostingsFormat.java:
##
@@ -0,0 +1,518 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
epotyom commented on PR #12769:
URL: https://github.com/apache/lucene/pull/12769#issuecomment-1795693861
Thank you for reviewing @mikemccand !
> I wonder what performance impact this might have for heavy Lucene facet
use cases... but we don't need to block this nice API with specific
epotyom commented on code in PR #12769:
URL: https://github.com/apache/lucene/pull/12769#discussion_r1383719431
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java:
##
@@ -312,6 +316,111 @@ public int getOrdinal(FacetLabel cp) throws
epotyom commented on code in PR #12769:
URL: https://github.com/apache/lucene/pull/12769#discussion_r1383719688
##
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestDirectoryTaxonomyReader.java:
##
@@ -476,6 +479,86 @@ public void testOpenIfChangedReplaceTaxon
mikemccand merged PR #12758:
URL: https://github.com/apache/lucene/pull/12758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
mikemccand commented on PR #12774:
URL: https://github.com/apache/lucene/pull/12774#issuecomment-1795590742
`gradle check` passes for me locally ... I'll push this and not sort out the
Github actions. Thanks @twosom!
--
This is an automated message from the Apache Git Service.
To respond
mikemccand merged PR #12774:
URL: https://github.com/apache/lucene/pull/12774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
mikemccand commented on PR #12774:
URL: https://github.com/apache/lucene/pull/12774#issuecomment-1795558334
Those failures were unrelated to this PR (I pushed a fix for them a short
while ago). I'll try to kick off the checks again.
--
This is an automated message from the Apache Git Ser
mikemccand commented on PR #12741:
URL: https://github.com/apache/lucene/pull/12741#issuecomment-1795532339
Thank you @slow-J!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
slow-J commented on PR #12741:
URL: https://github.com/apache/lucene/pull/12741#issuecomment-1795505918
Thanks Mike and all reviewers!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
gf2121 commented on code in PR #12748:
URL: https://github.com/apache/lucene/pull/12748#discussion_r1383631608
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/Lucene90BlockTreeTermsReader.java:
##
@@ -86,8 +86,11 @@ public final class Lucene90BlockTreeTermsRe
MarcusSorealheis commented on PR #940:
URL: https://github.com/apache/lucene/pull/940#issuecomment-1795346408
Is the idea for using `SimpleQQParser` that we would add another parse
method, maybe `parseWithMoreLikeThis` that combines mlt and quality query
parset to build a query or two separ
mikemccand commented on code in PR #12748:
URL: https://github.com/apache/lucene/pull/12748#discussion_r1383582139
##
lucene/core/src/java/org/apache/lucene/util/fst/FST.java:
##
@@ -96,6 +96,13 @@ public enum INPUT_TYPE {
*/
static final byte ARCS_FOR_DIRECT_ADDRESSING =
mikemccand commented on PR #12748:
URL: https://github.com/apache/lucene/pull/12748#issuecomment-1795259119
This might be a nice bump in `PKLookup` performance in the nightly
benchmarks -- it uses compact integers encoded as `BytesRef` in the `id` field.
--
This is an automated message fr
mikemccand commented on code in PR #12748:
URL: https://github.com/apache/lucene/pull/12748#discussion_r1383574616
##
lucene/core/src/java/org/apache/lucene/util/fst/FST.java:
##
@@ -96,6 +96,13 @@ public enum INPUT_TYPE {
*/
static final byte ARCS_FOR_DIRECT_ADDRESSING =
mikemccand closed issue #12696: Adding option to codec to disable patching in
Lucene's PFOR encoding
URL: https://github.com/apache/lucene/issues/12696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
mikemccand merged PR #12741:
URL: https://github.com/apache/lucene/pull/12741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
gf2121 opened a new pull request, #12775:
URL: https://github.com/apache/lucene/pull/12775
### Description
I noticed that we were seeing `StableRadixSorter` faster than `RadixSorter`
in [#91](https://github.com/apache/lucene/pull/91#issuecomment-823949164). And
the `StableRadixSorter
benwtrent commented on PR #12770:
URL: https://github.com/apache/lucene/pull/12770#issuecomment-1794951828
> I wonder if it helps with degenerate case where all scores are equal? EG
all zero vectors (see https://github.com/apache/lucene/issues/11626)
It would help by ending exploratio
mikemccand closed pull request #12772: #12271: ban possibly slow Random methods
URL: https://github.com/apache/lucene/pull/12772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
mikemccand commented on code in PR #12772:
URL: https://github.com/apache/lucene/pull/12772#discussion_r1383419161
##
gradle/validation/forbidden-apis/defaults.tests.txt:
##
@@ -21,3 +21,7 @@ java.lang.System#currentTimeMillis() @ Don't depend on wall
clock times
#java.lang.Sy
dungba88 commented on code in PR #12758:
URL: https://github.com/apache/lucene/pull/12758#discussion_r1383418076
##
lucene/core/src/java/org/apache/lucene/util/fst/FST.java:
##
@@ -1132,4 +1137,28 @@ public abstract static class BytesReader extends
DataInput {
/** Returns
msokolov commented on code in PR #12770:
URL: https://github.com/apache/lucene/pull/12770#discussion_r1383413699
##
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java:
##
@@ -174,8 +174,7 @@ private int[] findBestEntryPoint(RandomVectorScorer scorer,
HnswGr
msokolov commented on PR #12770:
URL: https://github.com/apache/lucene/pull/12770#issuecomment-1794932312
oh, good catch! I guess equality is unusual, but this should help in some
cases. I wonder if it helps with degenerate case where all scores are equal? EG
all zero vectors
--
This is
rmuir commented on code in PR #12772:
URL: https://github.com/apache/lucene/pull/12772#discussion_r1383410200
##
gradle/validation/forbidden-apis/defaults.tests.txt:
##
@@ -21,3 +21,7 @@ java.lang.System#currentTimeMillis() @ Don't depend on wall
clock times
#java.lang.System#
twosom opened a new pull request, #12774:
URL: https://github.com/apache/lucene/pull/12774
### Description
This PR moves the CSVUtil class that existed separately in the Analyzer Nori
and Kuromoji to the module :analysis:common. By consolidating the CSVUtil
class, we can prevent dupl
mikemccand commented on PR #12772:
URL: https://github.com/apache/lucene/pull/12772#issuecomment-1794914865
Woops -- I messed up the actual forbidden APIs -- working on correct fix (we
do use this API in many places!).
--
This is an automated message from the Apache Git Service.
To respon
rmuir commented on code in PR #12772:
URL: https://github.com/apache/lucene/pull/12772#discussion_r1383388421
##
gradle/validation/forbidden-apis/defaults.tests.txt:
##
@@ -21,3 +21,7 @@ java.lang.System#currentTimeMillis() @ Don't depend on wall
clock times
#java.lang.System#
twosom opened a new issue, #12773:
URL: https://github.com/apache/lucene/issues/12773
### Description
### Description
As seen in the previous issue https://github.com/apache/lucene/issues/12389
and https://github.com/apache/lucene/issues/12389, I have worked on moving the
`CSV
rmuir commented on code in PR #12772:
URL: https://github.com/apache/lucene/pull/12772#discussion_r1383365289
##
gradle/validation/forbidden-apis/defaults.tests.txt:
##
@@ -21,3 +21,7 @@ java.lang.System#currentTimeMillis() @ Don't depend on wall
clock times
#java.lang.System#
mikemccand opened a new pull request, #12772:
URL: https://github.com/apache/lucene/pull/12772
Just ban these possibly slow Random APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
mikemccand commented on issue #12771:
URL: https://github.com/apache/lucene/issues/12771#issuecomment-1794849299
@rmuir pointed out `nextLong(long, long)` has the same warning. I'll open a
PR to ban both.
--
This is an automated message from the Apache Git Service.
To respond to the mess
twosom commented on PR #12390:
URL: https://github.com/apache/lucene/pull/12390#issuecomment-1794844758
> I merged to main but there are quite a few conflicts on backport to 9.x --
any chance you could open a backport PR @twosom? Thanks!
OK! I'll open backport PR ASAP! Thanks!
--
T
mikemccand opened a new issue, #12771:
URL: https://github.com/apache/lucene/issues/12771
### Description
Spinoff from backporting #12506 which was using the [Random#nextInt(int,
int)
method](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/random/RandomGenerato
mikemccand closed issue #6675: ByteBlockPool's documentation is completely
useless [LUCENE-5613]
URL: https://github.com/apache/lucene/issues/6675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mikemccand merged PR #12506:
URL: https://github.com/apache/lucene/pull/12506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
rmuir commented on PR #12743:
URL: https://github.com/apache/lucene/pull/12743#issuecomment-1794797146
we should test more. I can test on more machines later too. Maybe good
motivation to get full automation going for doing that.
--
This is an automated message from the Apache Git Service
benwtrent commented on code in PR #12770:
URL: https://github.com/apache/lucene/pull/12770#discussion_r1383301063
##
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java:
##
@@ -174,8 +174,7 @@ private int[] findBestEntryPoint(RandomVectorScorer scorer,
HnswG
rmuir commented on PR #12767:
URL: https://github.com/apache/lucene/pull/12767#issuecomment-1794787497
I was thinking just to exercise it in TestRegexpRandom2 or similar test.
Maybe add TestRegexpRandom3.java?
Test is conceptually very simple but powerful. It has a lot of lines of cod
benwtrent opened a new pull request, #12770:
URL: https://github.com/apache/lucene/pull/12770
I noticed while testing lower dimensionality and quantization, we would
explore the HNSW graph way too much. I was stuck figuring out why until I
noticed the searcher checks for distance equality (
mikemccand commented on PR #414:
URL: https://github.com/apache/lucene/pull/414#issuecomment-1794726597
> That'a crazy Mike what you did here. ;)
LOL!! This is too crazy.
I admit to being a little too confident in GitHub's autosuggest when I `@`
someone. I'm not sure why on t
mikemccand commented on code in PR #12769:
URL: https://github.com/apache/lucene/pull/12769#discussion_r1383241368
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java:
##
@@ -312,6 +316,111 @@ public int getOrdinal(FacetLabel cp) thro
rmuir commented on PR #12767:
URL: https://github.com/apache/lucene/pull/12767#issuecomment-1794689085
There should be tests exercising this new boolean option. How do we know it
gives correct results to do this?
--
This is an automated message from the Apache Git Service.
To respond to t
mikemccand commented on code in PR #12741:
URL: https://github.com/apache/lucene/pull/12741#discussion_r1383233272
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99PostingsFormat.java:
##
@@ -0,0 +1,518 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
epotyom opened a new pull request, #12769:
URL: https://github.com/apache/lucene/pull/12769
Add TaxonomyReader#getBulkOrdinals method (#12180)
This is the first step for #12180 , next step will be to implement
`Facets#getSpecificValues` (bulk) that calls `getBulkOrdinals`, will do it
stefanvodita commented on PR #12506:
URL: https://github.com/apache/lucene/pull/12506#issuecomment-1794405194
@mikemccand @iverase - what do you think, is this PR ready?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ChrisHegarty merged PR #12761:
URL: https://github.com/apache/lucene/pull/12761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
66 matches
Mail list logo
