msokolov commented on code in PR #12770:
URL: https://github.com/apache/lucene/pull/12770#discussion_r1383413699
##########
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java:
##########
@@ -174,8 +174,7 @@ private int[] findBestEntryPoint(RandomVectorScorer scorer,
HnswGraph graph, lon
}
float friendSimilarity = scorer.score(friendOrd);
visitedCount++;
- if (friendSimilarity > currentScore
- || (friendSimilarity == currentScore && friendOrd < currentEp)) {
+ if (friendSimilarity > currentScore) {
Review Comment:
I see, nothing relies on this tiebreaking I think since we don't apply any
ordered iteration over ordinals. +1 to simplify
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
