mikemccand commented on code in PR #12748:
URL: https://github.com/apache/lucene/pull/12748#discussion_r1383574616
##########
lucene/core/src/java/org/apache/lucene/util/fst/FST.java:
##########
@@ -96,6 +96,13 @@ public enum INPUT_TYPE {
*/
static final byte ARCS_FOR_DIRECT_ADDRESSING = 1 << 6;
+ /**
+ * Value of the arc flags to declare a node with continuous arcs designed
for pos the arc directly
+ * with labelToPos - firstLabel. like {@link #ARCS_FOR_BINARY_SEARCH} we use
flag combinations
+ * that will not occur at the same time.
+ */
+ static final byte ARCS_FOR_CONTINUOUS = ARCS_FOR_DIRECT_ADDRESSING +
ARCS_FOR_BINARY_SEARCH;
+
// Increment version to change it
private static final String FILE_FORMAT_NAME = "FST";
private static final int VERSION_START = 6;
Review Comment:
Hmm I'd like to protect against an older version of Lucene (w/o this change)
trying to read an FST written with a newer version (with this change). If we
bump the version, that older version would throw an understandable error, but
if we don't, it'd be some strange assertion error or so?
I realize it'd be hard to even reach such a situation (you'd have to be
using FSTs directly or so), but still when we make such changes to our format I
think it's good practice to bump the version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
