benwtrent commented on code in PR #12770:
URL: https://github.com/apache/lucene/pull/12770#discussion_r1383301063
##########
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java:
##########
@@ -174,8 +174,7 @@ private int[] findBestEntryPoint(RandomVectorScorer scorer,
HnswGraph graph, lon
}
float friendSimilarity = scorer.score(friendOrd);
visitedCount++;
- if (friendSimilarity > currentScore
- || (friendSimilarity == currentScore && friendOrd < currentEp)) {
+ if (friendSimilarity > currentScore) {
Review Comment:
@msokolov I am not 100% sure if we want to do continue exploring if the
ordinal is less than the friend ordinal.
I originally made this change to make it more inline with what the typical
`results.collect` does, which is a tie breaker over ordinal collected. But, it
seems weird to explore the graph in two separate ways.
I will happily switch this back to tie break on ordinals as this isn't
really the bottle neck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
