zhaih commented on code in PR #12767:
URL: https://github.com/apache/lucene/pull/12767#discussion_r1384459245
##########
lucene/core/src/test/org/apache/lucene/search/TestRegexpQuery.java:
##########
@@ -80,7 +80,10 @@ private long caseInsensitiveRegexQueryNrHits(String regex)
throws IOException {
newTerm(regex),
RegExp.ALL,
RegExp.ASCII_CASE_INSENSITIVE,
- Operations.DEFAULT_DETERMINIZE_WORK_LIMIT);
+ RegexpQuery.DEFAULT_PROVIDER,
+ Operations.DEFAULT_DETERMINIZE_WORK_LIMIT,
+ MultiTermQuery.CONSTANT_SCORE_BLENDED_REWRITE,
+ random().nextBoolean());
Review Comment:
@rmuir I added this line so it will be tested randomly, and this method
actually is widely used in the RegexpQuery's tests.
But for sure I can (will) add a dedicated test to test NFA with random regex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
