[GitHub] [lucene] jpountz commented on pull request #790: LUCENE-10436: Remove deprecated DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery

2022-04-05 Thread GitBox
jpountz commented on PR #790: URL: https://github.com/apache/lucene/pull/790#issuecomment-1089886965 > For the change entry, I assume this should go into version 10.0.0? Yes, we need a CHANGES entry under 10.0.0 and a new entry in `lucene/MIGRATE.txt` that recommends replacing `DocVal

[GitHub] [lucene] jpountz commented on a diff in pull request #790: LUCENE-10436: Remove deprecated DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery

2022-04-05 Thread GitBox
jpountz commented on code in PR #790: URL: https://github.com/apache/lucene/pull/790#discussion_r843530787 ## lucene/core/src/java/org/apache/lucene/search/UsageTrackingQueryCachingPolicy.java: ## @@ -58,12 +58,6 @@ private static boolean shouldNeverCache(Query query) { r

[GitHub] [lucene] zacharymorn commented on pull request #790: LUCENE-10436: Remove deprecated DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery

2022-04-05 Thread GitBox
zacharymorn commented on PR #790: URL: https://github.com/apache/lucene/pull/790#issuecomment-1089864280 For the change entry, I assume this should go into version `10.0.0`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [lucene] zacharymorn opened a new pull request, #790: LUCENE-10436: Remove deprecated DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery

2022-04-05 Thread GitBox
zacharymorn opened a new pull request, #790: URL: https://github.com/apache/lucene/pull/790 # Description Remove deprecated DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery # Tests Passed existing tests. # Checklist Please revi

[jira] [Commented] (LUCENE-10436) Combine DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery into a single FieldExistsQuery?

2022-04-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517860#comment-17517860 ] ASF subversion and git services commented on LUCENE-10436: -- Co

[GitHub] [lucene] zacharymorn merged pull request #767: LUCENE-10436: Deprecate DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery with FieldExistsQuery

2022-04-05 Thread GitBox
zacharymorn merged PR #767: URL: https://github.com/apache/lucene/pull/767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[jira] [Commented] (LUCENE-9625) Benchmark KNN search with ann-benchmarks

2022-04-05 Thread Balmukund Mandal (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517825#comment-17517825 ] Balmukund Mandal commented on LUCENE-9625: -- Thank you Michael, it works. I thin

[GitHub] [lucene] gautamworah96 commented on a diff in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch d

2022-04-05 Thread GitBox
gautamworah96 commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r843363466 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache

[GitHub] [lucene] gautamworah96 commented on a diff in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch d

2022-04-05 Thread GitBox
gautamworah96 commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r843363466 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache

[jira] [Updated] (LUCENE-10292) AnalyzingInfixSuggester thread safety: lookup() fails during (re)build()

2022-04-05 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated LUCENE-10292: Attachment: LUCENE-10292.patch Assignee: Chris M. Hostetter Status:

[GitHub] [lucene] zhaih commented on a diff in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch decide

2022-04-05 Thread GitBox
zhaih commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r843318155 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (LUCENE-10482) Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch decide

2022-04-05 Thread Gautam Worah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gautam Worah updated LUCENE-10482: -- Status: Patch Available (was: Open) > Allow users to create their own DirectoryTaxonomyReade

[GitHub] [lucene] gautamworah96 commented on a diff in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch d

2022-04-05 Thread GitBox
gautamworah96 commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r843312709 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache

[jira] [Updated] (LUCENE-10501) StackOverflow when RegExp encounters a very large string

2022-04-05 Thread Kartik Ganesh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kartik Ganesh updated LUCENE-10501: --- Description: When RegExp encounters a very large string, it hits a Stack Overflow exception

[GitHub] [lucene] gsmiller commented on pull request #788: LUCENE-10500: StringValueFacetCounts to not rely on sequential collection

2022-04-05 Thread GitBox
gsmiller commented on PR #788: URL: https://github.com/apache/lucene/pull/788#issuecomment-1089423815 Oh no. Good find and thanks for fixing! (and apologies for slipping that bug in) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Created] (LUCENE-10501) StackOverflow when RegExp encounters a very large string

2022-04-05 Thread Kartik Ganesh (Jira)
Kartik Ganesh created LUCENE-10501: -- Summary: StackOverflow when RegExp encounters a very large string Key: LUCENE-10501 URL: https://issues.apache.org/jira/browse/LUCENE-10501 Project: Lucene - Core

[GitHub] [lucene] gautamworah96 commented on a diff in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch d

2022-04-05 Thread GitBox
gautamworah96 commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r843272398 ## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java: ## @@ -78,10 +78,20 @@ private volatile TaxonomyIndexArrays taxoA

[GitHub] [lucene] gautamworah96 commented on a diff in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch d

2022-04-05 Thread GitBox
gautamworah96 commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r843275500 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache

[GitHub] [lucene] gautamworah96 commented on a diff in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch d

2022-04-05 Thread GitBox
gautamworah96 commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r843275500 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache

[GitHub] [lucene] gautamworah96 commented on a diff in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch d

2022-04-05 Thread GitBox
gautamworah96 commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r843272398 ## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java: ## @@ -78,10 +78,20 @@ private volatile TaxonomyIndexArrays taxoA

[GitHub] [lucene] gautamworah96 commented on a diff in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch d

2022-04-05 Thread GitBox
gautamworah96 commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r843272080 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache

[GitHub] [lucene] gautamworah96 commented on a diff in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch d

2022-04-05 Thread GitBox
gautamworah96 commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r843271841 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache

[GitHub] [lucene] zhaih commented on a diff in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch decide

2022-04-05 Thread GitBox
zhaih commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r843265236 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene] jtibshirani commented on pull request #789: Add release wizard step around build failures

2022-04-05 Thread GitBox
jtibshirani commented on PR #789: URL: https://github.com/apache/lucene/pull/789#issuecomment-1089323655 This was inspired by my experience releasing Lucene 9.1, where addressing build failures early would've helped save us time. -- This is an automated message from the Apache Git Service

[GitHub] [lucene] jtibshirani opened a new pull request, #789: Add release wizard step around build failures

2022-04-05 Thread GitBox
jtibshirani opened a new pull request, #789: URL: https://github.com/apache/lucene/pull/789 This PR proposes adding a preparation step to look at bui...@lucene.apache.org and address recurring failures. This helps make sure we catch and fix known bugs before spinning the release candid

[jira] [Commented] (LUCENE-10500) StringValueFacetCounts relies on sequential collection

2022-04-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517693#comment-17517693 ] ASF subversion and git services commented on LUCENE-10500: -- Co

[jira] [Commented] (LUCENE-10500) StringValueFacetCounts relies on sequential collection

2022-04-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517694#comment-17517694 ] ASF subversion and git services commented on LUCENE-10500: -- Co

[GitHub] [lucene] jpountz merged pull request #788: LUCENE-10500: StringValueFacetCounts to not rely on sequential collection

2022-04-05 Thread GitBox
jpountz merged PR #788: URL: https://github.com/apache/lucene/pull/788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.

[GitHub] [lucene] javanna opened a new pull request, #788: LUCENE-10500: StringValueFacetCounts to not rely on sequential collection

2022-04-05 Thread GitBox
javanna opened a new pull request, #788: URL: https://github.com/apache/lucene/pull/788 StringValueFacetCounts should use the segment ordinal instead of the current index when looping through the matching hits, as when search is multi-threaded the order of the matching hits (one per segment

[jira] [Created] (LUCENE-10500) StringValueFacetCounts relies on sequential collection

2022-04-05 Thread Luca Cavanna (Jira)
Luca Cavanna created LUCENE-10500: - Summary: StringValueFacetCounts relies on sequential collection Key: LUCENE-10500 URL: https://issues.apache.org/jira/browse/LUCENE-10500 Project: Lucene - Core

[jira] [Commented] (LUCENE-10085) Implement Weight#count on DocValuesFieldExistsQuery

2022-04-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517607#comment-17517607 ] ASF subversion and git services commented on LUCENE-10085: -- Co

[jira] [Commented] (LUCENE-10085) Implement Weight#count on DocValuesFieldExistsQuery

2022-04-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517595#comment-17517595 ] ASF subversion and git services commented on LUCENE-10085: -- Co

[GitHub] [lucene] jtibshirani merged pull request #784: LUCENE-10085: Fix flaky test by always deleting docs

2022-04-05 Thread GitBox
jtibshirani merged PR #784: URL: https://github.com/apache/lucene/pull/784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] gsmiller commented on a diff in pull request #778: LUCENE-10495: Fix bug in TaxonomyFacets

2022-04-05 Thread GitBox
gsmiller commented on code in PR #778: URL: https://github.com/apache/lucene/pull/778#discussion_r843051837 ## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacets.java: ## @@ -109,7 +109,7 @@ public boolean childrenLoaded() { * @lucene.experimental */

[jira] [Resolved] (LUCENE-10467) Throws IllegalArgumentException for getAllDims and getTopChildren if topN <= 0

2022-04-05 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller resolved LUCENE-10467. -- Fix Version/s: 9.2 Resolution: Fixed Merged and backported. Thanks [~yutinggan]! > Th

[jira] [Commented] (LUCENE-10467) Throws IllegalArgumentException for getAllDims and getTopChildren if topN <= 0

2022-04-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517557#comment-17517557 ] ASF subversion and git services commented on LUCENE-10467: -- Co

[jira] [Commented] (LUCENE-10467) Throws IllegalArgumentException for getAllDims and getTopChildren if topN <= 0

2022-04-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517545#comment-17517545 ] ASF subversion and git services commented on LUCENE-10467: -- Co

[jira] [Commented] (LUCENE-10467) Throws IllegalArgumentException for getAllDims and getTopChildren if topN <= 0

2022-04-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517542#comment-17517542 ] ASF subversion and git services commented on LUCENE-10467: -- Co

[GitHub] [lucene] gsmiller merged pull request #751: LUCENE-10467: Throws IllegalArgumentException for getAllDims and getTopChildren if topN <= 0

2022-04-05 Thread GitBox
gsmiller merged PR #751: URL: https://github.com/apache/lucene/pull/751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache

[GitHub] [lucene] iverase commented on pull request #756: LUCENE-10470: [Tessellator] Prevent bridges that introduce collinear edges

2022-04-05 Thread GitBox
iverase commented on PR #756: URL: https://github.com/apache/lucene/pull/756#issuecomment-1088873741 Thanks @yinux! your dataset is very interesting because it seems your geometries have many parallel edges which are challenging the tessellator. In order to fix that I went back to the

[jira] [Commented] (LUCENE-9625) Benchmark KNN search with ann-benchmarks

2022-04-05 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517495#comment-17517495 ] Michael Sokolov commented on LUCENE-9625: - So, clearly it's not finding KnnGraph

[jira] [Commented] (LUCENE-9625) Benchmark KNN search with ann-benchmarks

2022-04-05 Thread Balmukund Mandal (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517488#comment-17517488 ] Balmukund Mandal commented on LUCENE-9625: -- Thank you Michael for your response

[jira] [Commented] (LUCENE-9625) Benchmark KNN search with ann-benchmarks

2022-04-05 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517471#comment-17517471 ] Michael Sokolov commented on LUCENE-9625: - > As you've mentioned that jars shoul

[GitHub] [lucene] javanna commented on a diff in pull request #787: LUCENE-10002: replace more usages of search(Query, Collector) in tests

2022-04-05 Thread GitBox
javanna commented on code in PR #787: URL: https://github.com/apache/lucene/pull/787#discussion_r842786871 ## lucene/queryparser/src/test/org/apache/lucene/queryparser/surround/query/BooleanQueryTestFacade.java: ## @@ -121,14 +125,24 @@ public void doTest() throws Exception {

[GitHub] [lucene] javanna commented on a diff in pull request #787: LUCENE-10002: replace more usages of search(Query, Collector) in tests

2022-04-05 Thread GitBox
javanna commented on code in PR #787: URL: https://github.com/apache/lucene/pull/787#discussion_r842785447 ## lucene/core/src/test/org/apache/lucene/search/TestTotalHitCountCollector.java: ## @@ -38,10 +38,10 @@ public void testBasics() throws Exception { IndexReader reader

[GitHub] [lucene] javanna commented on a diff in pull request #787: LUCENE-10002: replace more usages of search(Query, Collector) in tests

2022-04-05 Thread GitBox
javanna commented on code in PR #787: URL: https://github.com/apache/lucene/pull/787#discussion_r842783772 ## lucene/core/src/test/org/apache/lucene/search/TestMultiCollector.java: ## @@ -99,7 +100,7 @@ public void testCollectionTerminatedExceptionHandling() throws IOException

[GitHub] [lucene] javanna opened a new pull request, #787: LUCENE-10002: replace more usages of search(Query, Collector) in tests

2022-04-05 Thread GitBox
javanna opened a new pull request, #787: URL: https://github.com/apache/lucene/pull/787 This commit replaces more usages of search(Query, Collector) with calling the corresponding search(Query, CollectorManager) instead. This round focuses on tests that implement custom collector, that need

[jira] [Commented] (LUCENE-7522) Make the Lucene jar an OSGi bundle

2022-04-05 Thread Alexander Kurtakov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517425#comment-17517425 ] Alexander Kurtakov commented on LUCENE-7522: Is there hope for this one? >

[GitHub] [lucene] jpountz commented on pull request #649: LUCENE-10408 Better encoding of doc Ids in vectors

2022-04-05 Thread GitBox
jpountz commented on PR #649: URL: https://github.com/apache/lucene/pull/649#issuecomment-1088641170 Yes, something like that sounds like a good fit to store the ordToDoc mapping indeed :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [lucene] wjp719 commented on pull request #786: LUCENE-10499: reduce unnecessary copy data overhead when growing array size

2022-04-05 Thread GitBox
wjp719 commented on PR #786: URL: https://github.com/apache/lucene/pull/786#issuecomment-1088618967 > Can we instead add a new method to `ArrayUtil`, with a different name than `grow`, that doesn't copy data? > > I don't think we should add a boolean parameter to grow that gives it r

[jira] [Commented] (LUCENE-10497) Unify "Token" interface in Kuromoji and Nori

2022-04-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517386#comment-17517386 ] ASF subversion and git services commented on LUCENE-10497: -- Co

[GitHub] [lucene] mocobeta merged pull request #783: LUCENE-10497: add a base Token class to analysis-common

2022-04-05 Thread GitBox
mocobeta merged PR #783: URL: https://github.com/apache/lucene/pull/783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache

[GitHub] [lucene] mocobeta commented on pull request #783: LUCENE-10497: add a base Token class to analysis-common

2022-04-05 Thread GitBox
mocobeta commented on PR #783: URL: https://github.com/apache/lucene/pull/783#issuecomment-1088582275 I checked that this preserves the current behavior. I'd merge this (only in main) now and will refine it in the following PRs. -- This is an automated message from the Apache Git Service.

[GitHub] [lucene] rmuir commented on pull request #786: LUCENE-10499: reduce unnecessary copy data overhead when growing array size

2022-04-05 Thread GitBox
rmuir commented on PR #786: URL: https://github.com/apache/lucene/pull/786#issuecomment-1088581156 Can we instead add a new method to `ArrayUtil`, with a different name than `grow`, that doesn't copy data? I don't think we should add a boolean parameter to grow that gives it radical

[jira] [Updated] (LUCENE-10499) reduce unnecessary copy data overhead when grow array size

2022-04-05 Thread jianping weng (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jianping weng updated LUCENE-10499: --- Description: ArrayUtil#grow will copy origin array data to the new array after growing size

[jira] [Updated] (LUCENE-10499) reduce unnecessary copy data overhead when grow array size

2022-04-05 Thread jianping weng (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jianping weng updated LUCENE-10499: --- Summary: reduce unnecessary copy data overhead when grow array size (was: eliminate unnece

[GitHub] [lucene] wjp719 opened a new pull request, #786: LUCENE-10499: eliminate unnecessary copy data overhead when growing array size

2022-04-05 Thread GitBox
wjp719 opened a new pull request, #786: URL: https://github.com/apache/lucene/pull/786 ArrayUtil#grow will copy origin array data to the new array after growing size in default, but in many places, the new array needn't the origin data. This PR eliminates the extra copy data overhead.

[jira] [Created] (LUCENE-10499) eliminate unnecessary copy data overhead when grow array size

2022-04-05 Thread jianping weng (Jira)
jianping weng created LUCENE-10499: -- Summary: eliminate unnecessary copy data overhead when grow array size Key: LUCENE-10499 URL: https://issues.apache.org/jira/browse/LUCENE-10499 Project: Lucene -

[GitHub] [lucene] LuXugang commented on pull request #649: LUCENE-10408 Better encoding of doc Ids in vectors

2022-04-05 Thread GitBox
LuXugang commented on PR #649: URL: https://github.com/apache/lucene/pull/649#issuecomment-1088480302 > I wonder if it would be a better trade-off to keep ints uncompressed, but read them from disk directly instead of loading giant arrays in memory? Or possibly switch to something like Dire

[jira] [Commented] (LUCENE-9625) Benchmark KNN search with ann-benchmarks

2022-04-05 Thread Balmukund Mandal (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517325#comment-17517325 ] Balmukund Mandal commented on LUCENE-9625: -- [~sokolov]  As you've mentioned th

[GitHub] [lucene] javanna opened a new pull request, #785: LUCENE-10002: move MemoryIndex to search(Query, CollectorManager)

2022-04-05 Thread GitBox
javanna opened a new pull request, #785: URL: https://github.com/apache/lucene/pull/785 MemoryIndex exposes a search method that returns the score of the matching doc if it does match, otherwise 0.0f. It internally uses a custom collector and calls IndexSearcher#search(Query, Collector). We

[GitHub] [lucene] jpountz merged pull request #761: LUCENE-10002: replace TopFieldCollector usages in tests with collector manager

2022-04-05 Thread GitBox
jpountz merged PR #761: URL: https://github.com/apache/lucene/pull/761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.

[jira] [Commented] (LUCENE-10456) Implement Weight#count for MultiRangeQuery

2022-04-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517290#comment-17517290 ] ASF subversion and git services commented on LUCENE-10456: -- Co

[GitHub] [lucene] zacharymorn commented on pull request #767: LUCENE-10436: Deprecate DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery with FieldExistsQuery

2022-04-05 Thread GitBox
zacharymorn commented on PR #767: URL: https://github.com/apache/lucene/pull/767#issuecomment-1088372398 > Thank you! No problem, thanks @jpountz for all the reviews and suggestions as well! I'll open a follow-up PR after merging this as you suggested to remove the deprecated classes

[GitHub] [lucene] zacharymorn commented on a diff in pull request #767: LUCENE-10436: Deprecate DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery with FieldExistsQuery

2022-04-05 Thread GitBox
zacharymorn commented on code in PR #767: URL: https://github.com/apache/lucene/pull/767#discussion_r842463582 ## lucene/core/src/test/org/apache/lucene/search/TestFieldExistsQuery.java: ## @@ -65,20 +65,21 @@ public void testDocValuesRewriteWithTermsPresent() throws IOExceptio

[GitHub] [lucene] pquentin opened a new pull request, #784: LUCENE-10085: Fix flaky test by always deleting docs

2022-04-05 Thread GitBox
pquentin opened a new pull request, #784: URL: https://github.com/apache/lucene/pull/784 As noticed by @jtibshirani in https://issues.apache.org/jira/browse/LUCENE-10085?focusedCommentId=17516122&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17516122 -- T

[jira] [Resolved] (LUCENE-10456) Implement Weight#count for MultiRangeQuery

2022-04-05 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10456. --- Fix Version/s: 9.2 Resolution: Fixed > Implement Weight#count for MultiRangeQuery >

[jira] [Commented] (LUCENE-10456) Implement Weight#count for MultiRangeQuery

2022-04-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517272#comment-17517272 ] ASF subversion and git services commented on LUCENE-10456: -- Co

[GitHub] [lucene] jpountz merged pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

2022-04-05 Thread GitBox
jpountz merged PR #731: URL: https://github.com/apache/lucene/pull/731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.

[GitHub] [lucene] wjp719 commented on a diff in pull request #780: LUCENE-10496: avoid unnecessary attempts to evaluate skipping doc if index sort and search sort are in opposite direction

2022-04-05 Thread GitBox
wjp719 commented on code in PR #780: URL: https://github.com/apache/lucene/pull/780#discussion_r842438315 ## lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java: ## @@ -94,6 +95,7 @@ public void disableSkipping() { private long iteratorCost;

[GitHub] [lucene] wjp719 closed pull request #780: LUCENE-10496: avoid unnecessary attempts to evaluate skipping doc if index sort and search sort are in opposite direction

2022-04-05 Thread GitBox
wjp719 closed pull request #780: LUCENE-10496: avoid unnecessary attempts to evaluate skipping doc if index sort and search sort are in opposite direction URL: https://github.com/apache/lucene/pull/780 -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [lucene] jpountz commented on a diff in pull request #780: LUCENE-10496: avoid unnecessary attempts to evaluate skipping doc if index sort and search sort are in opposite direction

2022-04-05 Thread GitBox
jpountz commented on code in PR #780: URL: https://github.com/apache/lucene/pull/780#discussion_r842434529 ## lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java: ## @@ -94,6 +95,7 @@ public void disableSkipping() { private long iteratorCost;

[GitHub] [lucene] wjp719 commented on a diff in pull request #780: LUCENE-10496: avoid unnecessary attempts to evaluate skipping doc if index sort and search sort are in opposite direction

2022-04-05 Thread GitBox
wjp719 commented on code in PR #780: URL: https://github.com/apache/lucene/pull/780#discussion_r842427168 ## lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java: ## @@ -94,6 +95,7 @@ public void disableSkipping() { private long iteratorCost;