zacharymorn commented on code in PR #767: URL: https://github.com/apache/lucene/pull/767#discussion_r842463582
########## lucene/core/src/test/org/apache/lucene/search/TestFieldExistsQuery.java: ########## @@ -65,20 +65,21 @@ public void testDocValuesRewriteWithTermsPresent() throws IOException { dir.close(); } - public void testDocValuesRewriteWithPointValuesPresent() throws IOException { + public void testDocValuesRewriteWithDocValuesPresent() throws IOException { Directory dir = newDirectory(); RandomIndexWriter iw = new RandomIndexWriter(random(), dir); final int numDocs = atLeast(100); for (int i = 0; i < numDocs; ++i) { Document doc = new Document(); - doc.add(new BinaryPoint("dim", new byte[4], new byte[4])); + doc.add(new DoubleDocValuesField("f", 2.0)); + doc.add(new StringField("f", random().nextBoolean() ? "yes" : "no", Store.NO)); Review Comment: Updated in https://github.com/apache/lucene/pull/767/commits/61fedf349fd56d0a49cbb076bdbc7f13919d30f1 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org