javanna commented on code in PR #787:
URL: https://github.com/apache/lucene/pull/787#discussion_r842785447
##########
lucene/core/src/test/org/apache/lucene/search/TestTotalHitCountCollector.java:
##########
@@ -38,10 +38,10 @@ public void testBasics() throws Exception {
IndexReader reader = writer.getReader();
writer.close();
- IndexSearcher searcher = newSearcher(reader);
- TotalHitCountCollector c = new TotalHitCountCollector();
- searcher.search(new MatchAllDocsQuery(), c);
- assertEquals(5, c.getTotalHits());
+ IndexSearcher searcher = newSearcher(reader, true, true,
random().nextBoolean());
+ TotalHitCountCollectorManager collectorManager = new
TotalHitCountCollectorManager();
+ int totalHits = searcher.search(new MatchAllDocsQuery(), collectorManager);
+ assertEquals(5, totalHits);
Review Comment:
here, instead of having a separate test class for the collector manager, I
merged the two and used a collector manager in the test class for the collector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
