gautamworah96 commented on code in PR #762:
URL: https://github.com/apache/lucene/pull/762#discussion_r843272398
##########
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java:
##########
@@ -78,10 +78,20 @@
private volatile TaxonomyIndexArrays taxoArrays;
/**
- * Called only from {@link #doOpenIfChanged()}. If the taxonomy has been
recreated, you should
- * pass {@code null} as the caches and parent/children arrays.
+ * Expert: Use this method to explicitly force the {@link
DirectoryTaxonomyReader} to use specific
+ * parent/children arrays and caches.
+ *
+ * <p>Called from {@link #doOpenIfChanged()}. If the taxonomy has been
recreated, you should pass
+ * {@code null} as the caches and parent/children arrays.
+ *
+ * @param indexReader An indexReader that is opened in the desired Directory
+ * @param taxoWriter The {@link DirectoryTaxonomyWriter} from which to
obtain newly added
+ * categories, in real-time.
+ * @param ordinalCache a FacetLabel to Integer ordinal mapping if it already
exists
+ * @param categoryCache an ordinal to FacetLabel mapping if it already exists
+ * @param taxoArrays taxonomy arrays that store the parent, siblings,
children information
*/
- DirectoryTaxonomyReader(
+ public DirectoryTaxonomyReader(
Review Comment:
Changed it to protected to enable subclasses to be able to customize their
usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
