iverase commented on PR #756: URL: https://github.com/apache/lucene/pull/756#issuecomment-1088873741
Thanks @yinux! your dataset is very interesting because it seems your geometries have many parallel edges which are challenging the tessellator. In order to fix that I went back to the PR that changed the behaviour of the tessellator. In that PR we added the capability of labelling the edges of the triangles to know if they belong to the original polygon or they have been introduced by the tessellation process. One side effect is that the method `filterPoints` which removes collinear points is more picky now because it can only remove collinear points when they have the same label (belonging to the original polygon or not). In this case the issue was a collinear edge where one of the edges was returning over the previous edge and had a point on top of that edge. We can actually remove that collinearity as well so we end up with only one edge. I added that change in line 1306 and now all test are passing. I run this version over my dataset (over 400 million polygons) and all passed too. Let me know if you find more issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
