[jira] [Commented] (LUCENE-10022) Empty DisjunctionMaxQuery can rewrite to MatchNoDocsQuery

2021-07-08 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377790#comment-17377790 ] Julie Tibshirani commented on LUCENE-10022: --- Thanks [~davishmcclurg], the pat

[jira] [Commented] (LUCENE-10023) Multi-token post-analysis DocValues

2021-07-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377769#comment-17377769 ] Robert Muir commented on LUCENE-10023: -- {quote} I guess the essence of the questio

[jira] [Commented] (LUCENE-10023) Multi-token post-analysis DocValues

2021-07-08 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377681#comment-17377681 ] Michael Gibney commented on LUCENE-10023: - {quote}I'm not seeing this looking a

[jira] [Commented] (LUCENE-10023) Multi-token post-analysis DocValues

2021-07-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377639#comment-17377639 ] Robert Muir commented on LUCENE-10023: -- {quote} In contrast, the current PR only r

[jira] [Commented] (LUCENE-10023) Multi-token post-analysis DocValues

2021-07-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377636#comment-17377636 ] Robert Muir commented on LUCENE-10023: -- {quote} In contrast, the current PR only r

[jira] [Commented] (LUCENE-10023) Multi-token post-analysis DocValues

2021-07-08 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377594#comment-17377594 ] Michael Gibney commented on LUCENE-10023: - {quote}pushing the trappiness onto t

[GitHub] [lucene] msokolov commented on a change in pull request #207: LUCENE-9855: Rename nn search vector format

2021-07-08 Thread GitBox
msokolov commented on a change in pull request #207: URL: https://github.com/apache/lucene/pull/207#discussion_r666474279 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -2284,28 +2284,28 @@ static void checkImpacts(Impacts impacts, int lastTar

[GitHub] [lucene] sonatype-lift[bot] commented on a change in pull request #207: LUCENE-9855: Rename nn search vector format

2021-07-08 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #207: URL: https://github.com/apache/lucene/pull/207#discussion_r666468744 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java ## @@ -247,12 +246,12 @@ public TopDocs searc

[GitHub] [lucene] msokolov commented on a change in pull request #207: LUCENE-9855: Rename nn search vector format

2021-07-08 Thread GitBox
msokolov commented on a change in pull request #207: URL: https://github.com/apache/lucene/pull/207#discussion_r666468712 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java ## @@ -247,12 +246,12 @@ public TopDocs search(String f

[jira] [Commented] (LUCENE-10021) Upgrade HPPC to 0.9.0

2021-07-08 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377573#comment-17377573 ] Michael McCandless commented on LUCENE-10021: - I think it's fine to just do

[jira] [Commented] (LUCENE-10023) Multi-token post-analysis DocValues

2021-07-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377541#comment-17377541 ] Robert Muir commented on LUCENE-10023: -- I actually think it is useful for the user

[GitHub] [lucene] magibney commented on a change in pull request #208: LUCENE-10023: Add support for multi-token post-analysis DocValues

2021-07-08 Thread GitBox
magibney commented on a change in pull request #208: URL: https://github.com/apache/lucene/pull/208#discussion_r666393344 ## File path: lucene/core/src/java/org/apache/lucene/index/DocValuesIterator.java ## @@ -19,7 +19,13 @@ import java.io.IOException; import org.apache.luce

[GitHub] [lucene] rmuir commented on a change in pull request #208: LUCENE-10023: Add support for multi-token post-analysis DocValues

2021-07-08 Thread GitBox
rmuir commented on a change in pull request #208: URL: https://github.com/apache/lucene/pull/208#discussion_r666386423 ## File path: lucene/core/src/java/org/apache/lucene/index/DocValuesIterator.java ## @@ -19,7 +19,13 @@ import java.io.IOException; import org.apache.lucene.

[GitHub] [lucene] magibney commented on a change in pull request #208: LUCENE-10023: Add support for multi-token post-analysis DocValues

2021-07-08 Thread GitBox
magibney commented on a change in pull request #208: URL: https://github.com/apache/lucene/pull/208#discussion_r666384638 ## File path: lucene/core/src/java/org/apache/lucene/index/DocValuesIterator.java ## @@ -19,7 +19,13 @@ import java.io.IOException; import org.apache.luce

[GitHub] [lucene] rmuir commented on a change in pull request #208: LUCENE-10023: Add support for multi-token post-analysis DocValues

2021-07-08 Thread GitBox
rmuir commented on a change in pull request #208: URL: https://github.com/apache/lucene/pull/208#discussion_r666381585 ## File path: lucene/core/src/java/org/apache/lucene/index/DocValuesIterator.java ## @@ -19,7 +19,13 @@ import java.io.IOException; import org.apache.lucene.

[GitHub] [lucene] sonatype-lift[bot] commented on a change in pull request #207: LUCENE-9855: Rename nn search vector format

2021-07-08 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #207: URL: https://github.com/apache/lucene/pull/207#discussion_r666280195 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java ## @@ -247,12 +246,12 @@ public TopDocs searc

[jira] [Commented] (LUCENE-9855) Reconsider names for ANN related format and APIs

2021-07-08 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377435#comment-17377435 ] Tomoko Uchida commented on LUCENE-9855: --- Hi, I opened [https://github.com/apache/

[GitHub] [lucene] mocobeta commented on pull request #207: LUCENE-9855: Rename nn search vector format

2021-07-08 Thread GitBox
mocobeta commented on pull request #207: URL: https://github.com/apache/lucene/pull/207#issuecomment-876495952 Most changes were done by IDE's refactoring function, besides I manually modified some comments/javadocs that were figured out by `git grep`. -- This is an automated message fro

[GitHub] [lucene] dsmiley commented on a change in pull request #205: LUCENE-9959: Rename TermVectorsReader to TermVectorsReaderBase

2021-07-08 Thread GitBox
dsmiley commented on a change in pull request #205: URL: https://github.com/apache/lucene/pull/205#discussion_r666242176 ## File path: lucene/core/src/java/org/apache/lucene/index/SegmentCoreReaders.java ## @@ -57,7 +57,7 @@ final NormsProducer normsProducer; final Stor

[GitHub] [lucene] dsmiley commented on pull request #180: LUCENE-9959: Add non thread local based API for term vector reader usage

2021-07-08 Thread GitBox
dsmiley commented on pull request #180: URL: https://github.com/apache/lucene/pull/180#issuecomment-876482149 I think my preference is for you to commit this PR as-is after all. It introduces a new TermVectors interface (not great usability) but I think in LUCENE-10018 it would be reasona

[GitHub] [lucene] magibney opened a new pull request #208: LUCENE-10023: Add support for multi-token post-analysis DocValues

2021-07-08 Thread GitBox
magibney opened a new pull request #208: URL: https://github.com/apache/lucene/pull/208 See: [LUCENE-10023](https://issues.apache.org/jira/browse/LUCENE-10023) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [lucene] mocobeta opened a new pull request #207: LUCENE-9855: Rename nn search vector format

2021-07-08 Thread GitBox
mocobeta opened a new pull request #207: URL: https://github.com/apache/lucene/pull/207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-uns

[jira] [Commented] (LUCENE-10023) Multi-token post-analysis DocValues

2021-07-08 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377413#comment-17377413 ] Michael Gibney commented on LUCENE-10023: - In contrast to "naive word cloud" fa

[jira] [Created] (LUCENE-10023) Multi-token post-analysis DocValues

2021-07-08 Thread Michael Gibney (Jira)
Michael Gibney created LUCENE-10023: --- Summary: Multi-token post-analysis DocValues Key: LUCENE-10023 URL: https://issues.apache.org/jira/browse/LUCENE-10023 Project: Lucene - Core Issue Typ

[jira] [Commented] (LUCENE-10003) Disallow C-style array declarations

2021-07-08 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377217#comment-17377217 ] Dawid Weiss commented on LUCENE-10003: -- This said, I think your github PR should g

[jira] [Commented] (LUCENE-9127) index migration from 7 to 8 failing

2021-07-08 Thread samuel ma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377204#comment-17377204 ] samuel ma commented on LUCENE-9127: --- [~erickerickson], We have some 5/6x version inde

[GitHub] [lucene] zacharymorn commented on a change in pull request #205: LUCENE-9959: Rename TermVectorsReader to TermVectorsReaderBase

2021-07-08 Thread GitBox
zacharymorn commented on a change in pull request #205: URL: https://github.com/apache/lucene/pull/205#discussion_r665966533 ## File path: lucene/core/src/java/org/apache/lucene/index/SegmentCoreReaders.java ## @@ -57,7 +57,7 @@ final NormsProducer normsProducer; final