rmuir commented on a change in pull request #208: URL: https://github.com/apache/lucene/pull/208#discussion_r666386423
########## File path: lucene/core/src/java/org/apache/lucene/index/DocValuesIterator.java ########## @@ -19,7 +19,13 @@ import java.io.IOException; import org.apache.lucene.search.DocIdSetIterator; -abstract class DocValuesIterator extends DocIdSetIterator { +/** TODO: flesh this out since we made this class public */ +public abstract class DocValuesIterator extends DocIdSetIterator { Review comment: Thanks, my opinion is still the same as it was ~ 2 weeks ago: https://github.com/apache/lucene/pull/192#issuecomment-865739432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org