msokolov commented on a change in pull request #207:
URL: https://github.com/apache/lucene/pull/207#discussion_r666474279
##########
File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
##########
@@ -2284,28 +2284,28 @@ static void checkImpacts(Impacts impacts, int
lastTarget) {
*
* @lucene.experimental
*/
- public static Status.VectorValuesStatus testVectors(
+ public static Status.NnVectorsStatus testVectors(
CodecReader reader, PrintStream infoStream, boolean failFast) throws
IOException {
if (infoStream != null) {
infoStream.print(" test: vectors..............");
Review comment:
should we change the text here? "nn vectors"?
##########
File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
##########
@@ -2284,28 +2284,28 @@ static void checkImpacts(Impacts impacts, int
lastTarget) {
*
* @lucene.experimental
*/
- public static Status.VectorValuesStatus testVectors(
+ public static Status.NnVectorsStatus testVectors(
CodecReader reader, PrintStream infoStream, boolean failFast) throws
IOException {
if (infoStream != null) {
infoStream.print(" test: vectors..............");
}
long startNS = System.nanoTime();
FieldInfos fieldInfos = reader.getFieldInfos();
- Status.VectorValuesStatus status = new Status.VectorValuesStatus();
+ Status.NnVectorsStatus status = new Status.NnVectorsStatus();
try {
- if (fieldInfos.hasVectorValues()) {
+ if (fieldInfos.hasNnVectors()) {
for (FieldInfo fieldInfo : fieldInfos) {
- if (fieldInfo.hasVectorValues()) {
- int dimension = fieldInfo.getVectorDimension();
+ if (fieldInfo.hasNnVectors()) {
+ int dimension = fieldInfo.getNnVectorDimension();
if (dimension <= 0) {
throw new RuntimeException(
"Field \""
+ fieldInfo.name
+ "\" has vector values but dimension is "
Review comment:
"vector values" -> "nearest-neighbor vector values"?
##########
File path: lucene/core/src/java/org/apache/lucene/index/NnVectorsConsumer.java
##########
@@ -34,7 +34,7 @@
*
* @lucene.experimental
*/
-class VectorValuesWriter {
+class NnVectorsConsumer {
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
