magibney commented on a change in pull request #208: URL: https://github.com/apache/lucene/pull/208#discussion_r666393344
########## File path: lucene/core/src/java/org/apache/lucene/index/DocValuesIterator.java ########## @@ -19,7 +19,13 @@ import java.io.IOException; import org.apache.lucene.search.DocIdSetIterator; -abstract class DocValuesIterator extends DocIdSetIterator { +/** TODO: flesh this out since we made this class public */ +public abstract class DocValuesIterator extends DocIdSetIterator { Review comment: reverted in 75339d6; yeah, this was an incidental change; serves no purpose in this PR, and iirc was not essential to the Solr-side changes either (not that that's necessarily relevant here, but still). Thanks for pointing out #192, that had escaped my notice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org