dsmiley commented on pull request #180:
URL: https://github.com/apache/lucene/pull/180#issuecomment-876482149
I think my preference is for you to commit this PR as-is after all. It
introduces a new TermVectors interface (not great usability) but I think in
LUCENE-10018 it would be reasonable to have TermVectors abstraction change to
*be* what Fields is today for the TV use-case, with some modifications. TV
would look like:
````
interface TermVectors {
Collection<String> termVectorFields(int docId) throws IOException;
Terms termVectorTerms(int docId, String fieldName) throws IOException;
}
````
Since TermVectorsReader will be a thread-safe clone of the original (unlike
8x), it's then reasonable for it to cache the current TV info for the most
recently accessed doc. So if you get the Terms for all fields for the current
doc, it won't have to re-read anything. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
