[jira] [Commented] (LUCENE-9455) ExitableTermsEnum (in ExitableDirectoryReader) should sample next()

2020-10-21 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218810#comment-17218810 ] Bruno Roustant commented on LUCENE-9455: Your investigation revealed something I

[GitHub] [lucene-solr] bruno-roustant commented on pull request #1998: LUCENE-9455: ExitableTermsEnum should sample timeout and interruption check before calling next()

2020-10-21 Thread GitBox
bruno-roustant commented on pull request #1998: URL: https://github.com/apache/lucene-solr/pull/1998#issuecomment-714274227 So thanks to MultiTermQueryConstantScoreWrapper.BOOLEAN_REWRITE_TERM_COUNT_THRESHOLD we actually don't need to sample ExitableTermsEnum constructor. ---

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1998: LUCENE-9455: ExitableTermsEnum should sample timeout and interruption check before calling next()

2020-10-21 Thread GitBox
bruno-roustant commented on a change in pull request #1998: URL: https://github.com/apache/lucene-solr/pull/1998#discussion_r509919492 ## File path: lucene/core/src/test/org/apache/lucene/index/TestExitableDirectoryReader.java ## @@ -163,6 +163,17 @@ public void testExitableFi

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1998: LUCENE-9455: ExitableTermsEnum should sample timeout and interruption check before calling next()

2020-10-21 Thread GitBox
bruno-roustant commented on a change in pull request #1998: URL: https://github.com/apache/lucene-solr/pull/1998#discussion_r509912132 ## File path: lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ## @@ -496,35 +496,38 @@ public TermsEnum iterator() t

[GitHub] [lucene-solr] gunasekhardora commented on pull request #1048: SOLR-13806: change type of QueryResponse._explainMap

2020-10-21 Thread GitBox
gunasekhardora commented on pull request #1048: URL: https://github.com/apache/lucene-solr/pull/1048#issuecomment-714196452 Closing it @sigram This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [lucene-solr] gunasekhardora closed pull request #1048: SOLR-13806: change type of QueryResponse._explainMap

2020-10-21 Thread GitBox
gunasekhardora closed pull request #1048: URL: https://github.com/apache/lucene-solr/pull/1048 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Commented] (LUCENE-9455) ExitableTermsEnum (in ExitableDirectoryReader) should sample next()

2020-10-21 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218706#comment-17218706 ] Zach Chen commented on LUCENE-9455: --- Thanks Bruno. I thought about the proposal above

[jira] [Comment Edited] (LUCENE-9455) ExitableTermsEnum (in ExitableDirectoryReader) should sample next()

2020-10-21 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218706#comment-17218706 ] Zach Chen edited comment on LUCENE-9455 at 10/22/20, 2:56 AM:

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #1998: LUCENE-9455: ExitableTermsEnum should sample timeout and interruption check before calling next()

2020-10-21 Thread GitBox
zacharymorn commented on a change in pull request #1998: URL: https://github.com/apache/lucene-solr/pull/1998#discussion_r509847243 ## File path: lucene/core/src/test/org/apache/lucene/index/TestExitableDirectoryReader.java ## @@ -163,6 +163,17 @@ public void testExitableFilte

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #1998: LUCENE-9455: ExitableTermsEnum should sample timeout and interruption check before calling next()

2020-10-21 Thread GitBox
zacharymorn commented on a change in pull request #1998: URL: https://github.com/apache/lucene-solr/pull/1998#discussion_r509844706 ## File path: lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ## @@ -496,35 +496,38 @@ public TermsEnum iterator() thro

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #1998: LUCENE-9455: ExitableTermsEnum should sample timeout and interruption check before calling next()

2020-10-21 Thread GitBox
zacharymorn commented on a change in pull request #1998: URL: https://github.com/apache/lucene-solr/pull/1998#discussion_r509844747 ## File path: lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ## @@ -496,35 +496,38 @@ public TermsEnum iterator() thro

[GitHub] [lucene-solr] muse-dev[bot] commented on a change in pull request #2010: SOLR-12182: Store URL scheme as replaceable parameter in state.json

2020-10-21 Thread GitBox
muse-dev[bot] commented on a change in pull request #2010: URL: https://github.com/apache/lucene-solr/pull/2010#discussion_r509829039 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkController.java ## @@ -448,6 +447,11 @@ public boolean isClosed() { return cc.

[jira] [Created] (SOLR-14959) Getting an error trying to web crawl a website

2020-10-21 Thread Ravisher Singh (Jira)
Ravisher Singh created SOLR-14959: - Summary: Getting an error trying to web crawl a website Key: SOLR-14959 URL: https://issues.apache.org/jira/browse/SOLR-14959 Project: Solr Issue Type: Bug

[jira] [Updated] (SOLR-14903) SolrCloud tests should use the jetty.xml that we ship with

2020-10-21 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-14903: -- Attachment: SOLR-14903.patch Assignee: Chris M. Hostetter Status: Open (w

[GitHub] [lucene-solr] msokolov opened a new pull request #2018: LUCENE-9582: rename VectorValues.ScoreFunction to SearchStrategy

2020-10-21 Thread GitBox
msokolov opened a new pull request #2018: URL: https://github.com/apache/lucene-solr/pull/2018 This is - renaming as the title says, plus a light refactoring, and adding `o.a.l.util.VectorUtil` to house the score function implementations. --

[jira] [Commented] (SOLR-14067) Deprecate StatelessScriptUpdateProcessor and disabled by default

2020-10-21 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218643#comment-17218643 ] Chris M. Hostetter commented on SOLR-14067: --- IIRC the naming was chosen to try

[jira] [Commented] (SOLR-14958) zkHost sys prop requirement prevents sane/safe cloud test usage

2020-10-21 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218640#comment-17218640 ] Chris M. Hostetter commented on SOLR-14958: ---   Straw man proposal for improvem

[jira] [Commented] (LUCENE-8183) HyphenationCompoundWordTokenFilter creates overlapping tokens with onlyLongestMatch enabled

2020-10-21 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218638#comment-17218638 ] Uwe Schindler commented on LUCENE-8183: --- Hi, thanks Martin! Let me get uptodate w

[jira] [Created] (SOLR-14958) zkHost sys prop requirement prevents sane/safe cloud test usage

2020-10-21 Thread Chris M. Hostetter (Jira)
Chris M. Hostetter created SOLR-14958: - Summary: zkHost sys prop requirement prevents sane/safe cloud test usage Key: SOLR-14958 URL: https://issues.apache.org/jira/browse/SOLR-14958 Project: Solr

[jira] [Updated] (LUCENE-9582) Rename VectorValues.ScoreFunction to SearchStrategy

2020-10-21 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Sokolov updated LUCENE-9582: Summary: Rename VectorValues.ScoreFunction to SearchStrategy (was: Make VectorValues' sc

[GitHub] [lucene-solr] HoustonPutman opened a new pull request #2017: SOLR-14957: Add Prometheus Exporter to docker PATH. Fix classpath issues.

2020-10-21 Thread GitBox
HoustonPutman opened a new pull request #2017: URL: https://github.com/apache/lucene-solr/pull/2017 https://issues.apache.org/jira/browse/SOLR-14957 While testing this out, I was unable to make the `solr-exporter` run without fixing classpath issues. I think this pr, https://github.

[GitHub] [lucene-solr] epugh commented on pull request #2016: SOLR-14067 v2 Move Stateless Scripting Update Process to /contrib

2020-10-21 Thread GitBox
epugh commented on pull request #2016: URL: https://github.com/apache/lucene-solr/pull/2016#issuecomment-713865669 I put this as Draft as I'm still working on cleaning up refguide. This is an automated message from the Apac

[jira] [Commented] (SOLR-14067) Deprecate StatelessScriptUpdateProcessor and disabled by default

2020-10-21 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218583#comment-17218583 ] David Eric Pugh commented on SOLR-14067: Hey [~hoss...@fucit.org], Mr [~dsmiley]

[GitHub] [lucene-solr] magibney commented on pull request #751: SOLR-13132: single sweep iteration over base, foreground, and background sets for "relatedness" calculation

2020-10-21 Thread GitBox
magibney commented on pull request #751: URL: https://github.com/apache/lucene-solr/pull/751#issuecomment-713865188 Yes, it can be closed; sorry for the delayed response. (this was squash-merged as 40e2122b5a5b89f446e51692ef0d72e48c7b71e5) -

[GitHub] [lucene-solr] magibney closed pull request #751: SOLR-13132: single sweep iteration over base, foreground, and background sets for "relatedness" calculation

2020-10-21 Thread GitBox
magibney closed pull request #751: URL: https://github.com/apache/lucene-solr/pull/751 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Assigned] (SOLR-14067) Deprecate StatelessScriptUpdateProcessor and disabled by default

2020-10-21 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh reassigned SOLR-14067: -- Assignee: David Eric Pugh > Deprecate StatelessScriptUpdateProcessor and disabled by d

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2016: SOLR-14067 v2 Move Stateless Scripting Update Process to /contrib

2020-10-21 Thread GitBox
dweiss commented on a change in pull request #2016: URL: https://github.com/apache/lucene-solr/pull/2016#discussion_r509676888 ## File path: gradle/documentation/render-javadoc.gradle ## @@ -278,6 +278,13 @@ configure(project(":solr:contrib:langid")) { } } +configure(proj

[GitHub] [lucene-solr] epugh opened a new pull request #2016: SOLR-14067 v2 Move Stateless Scripting Update Process to /contrib

2020-10-21 Thread GitBox
epugh opened a new pull request #2016: URL: https://github.com/apache/lucene-solr/pull/2016 _Once more, with feeling_ # Description The scripting update processor is both powerful but also potentially dangerous, and shouldn't ship with Solr by default. # Solution

[jira] [Created] (LUCENE-9582) Make VectorValues' scoring/search API more extensible

2020-10-21 Thread Michael Sokolov (Jira)
Michael Sokolov created LUCENE-9582: --- Summary: Make VectorValues' scoring/search API more extensible Key: LUCENE-9582 URL: https://issues.apache.org/jira/browse/LUCENE-9582 Project: Lucene - Core

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1996: SOLR-14907: Adding V2 API for ConfigSet Upload.

2020-10-21 Thread GitBox
dsmiley commented on a change in pull request #1996: URL: https://github.com/apache/lucene-solr/pull/1996#discussion_r509667053 ## File path: solr/core/src/java/org/apache/solr/handler/ClusterAPI.java ## @@ -133,6 +134,62 @@ public void create(PayloadObj obj) throws Exception

[jira] [Updated] (SOLR-14957) Add Prometheus Exporter bin to PATH in docker image

2020-10-21 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-14957: -- Description: Currently the Solr docker image contains the prometheus exporter script {{bin/sol

[jira] [Created] (SOLR-14957) Add Prometheus Exporter bin to PATH in docker image

2020-10-21 Thread Houston Putman (Jira)
Houston Putman created SOLR-14957: - Summary: Add Prometheus Exporter bin to PATH in docker image Key: SOLR-14957 URL: https://issues.apache.org/jira/browse/SOLR-14957 Project: Solr Issue Type

[jira] [Updated] (SOLR-14955) Add env var options for the Prometheus Exporter bin scripts

2020-10-21 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-14955: -- Description: The prometheus exporter bin scripts get the job done, but are quite lean and don'

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1996: SOLR-14907: Adding V2 API for ConfigSet Upload.

2020-10-21 Thread GitBox
murblanc commented on a change in pull request #1996: URL: https://github.com/apache/lucene-solr/pull/1996#discussion_r509629741 ## File path: solr/core/src/java/org/apache/solr/handler/ClusterAPI.java ## @@ -133,6 +134,62 @@ public void create(PayloadObj obj) throws Exception

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1996: SOLR-14907: Adding V2 API for ConfigSet Upload.

2020-10-21 Thread GitBox
murblanc commented on a change in pull request #1996: URL: https://github.com/apache/lucene-solr/pull/1996#discussion_r509629741 ## File path: solr/core/src/java/org/apache/solr/handler/ClusterAPI.java ## @@ -133,6 +134,62 @@ public void create(PayloadObj obj) throws Exception

[GitHub] [lucene-solr] epugh closed pull request #2015: SOLR-14067 move Stateless Script Update Processor to contrib

2020-10-21 Thread GitBox
epugh closed pull request #2015: URL: https://github.com/apache/lucene-solr/pull/2015 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [lucene-solr] epugh commented on pull request #2015: SOLR-14067 move Stateless Script Update Processor to contrib

2020-10-21 Thread GitBox
epugh commented on pull request #2015: URL: https://github.com/apache/lucene-solr/pull/2015#issuecomment-713805550 Not sure what the heck is happening.I'm going to delete my fork of solr, and then refork, and then reapply. Something is busted! ---

[jira] [Created] (SOLR-14956) Wrong case of parameters in example for "Configuring the ShardHandlerFactory"

2020-10-21 Thread Yevhen Tienkaiev (Jira)
Yevhen Tienkaiev created SOLR-14956: --- Summary: Wrong case of parameters in example for "Configuring the ShardHandlerFactory" Key: SOLR-14956 URL: https://issues.apache.org/jira/browse/SOLR-14956 Pro

[GitHub] [lucene-solr] dsmiley commented on pull request #2015: SOLR-14067 move Stateless Script Update Processor to contrib

2020-10-21 Thread GitBox
dsmiley commented on pull request #2015: URL: https://github.com/apache/lucene-solr/pull/2015#issuecomment-713792171 I completely agree on the name. Raise that on the JIRA issue side and at-mention hossman, whom I believe gave it the original name. ---

[GitHub] [lucene-solr] dsmiley commented on pull request #2015: SOLR-14067 move Stateless Script Update Processor to contrib

2020-10-21 Thread GitBox
dsmiley commented on pull request #2015: URL: https://github.com/apache/lucene-solr/pull/2015#issuecomment-713790414 I'm sure this PR is messed up; 491 commits?! Most likely you just need to edit the base branch or something. Granted master branch is what we *should* be targeting, and th

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1996: SOLR-14907: Adding V2 API for ConfigSet Upload.

2020-10-21 Thread GitBox
dsmiley commented on a change in pull request #1996: URL: https://github.com/apache/lucene-solr/pull/1996#discussion_r509562901 ## File path: solr/core/src/java/org/apache/solr/handler/ClusterAPI.java ## @@ -133,6 +134,62 @@ public void create(PayloadObj obj) throws Exception

[jira] [Comment Edited] (SOLR-14954) Heavily edit reindexing.adoc

2020-10-21 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218478#comment-17218478 ] Erick Erickson edited comment on SOLR-14954 at 10/21/20, 6:23 PM: -

[jira] [Commented] (SOLR-14954) Heavily edit reindexing.adoc

2020-10-21 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218478#comment-17218478 ] Erick Erickson commented on SOLR-14954: --- A, crap. I made a new PR 2010, that ap

[GitHub] [lucene-solr] epugh opened a new pull request #2015: SOLR-14067 move Stateless Script Update Processor to contrib

2020-10-21 Thread GitBox
epugh opened a new pull request #2015: URL: https://github.com/apache/lucene-solr/pull/2015 # Description The scripting update processor is both powerful but also potentially dangerous, and shouldn't ship with Solr by default. # Solution Move the Stateless Script Update

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1996: SOLR-14907: Adding V2 API for ConfigSet Upload.

2020-10-21 Thread GitBox
HoustonPutman commented on a change in pull request #1996: URL: https://github.com/apache/lucene-solr/pull/1996#discussion_r509536901 ## File path: solr/core/src/java/org/apache/solr/handler/ClusterAPI.java ## @@ -133,6 +134,62 @@ public void create(PayloadObj obj) throws Exce

[jira] [Commented] (SOLR-14749) Provide a clean API for cluster-level event processing

2020-10-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218444#comment-17218444 ] ASF subversion and git services commented on SOLR-14749: Commit 6

[jira] [Comment Edited] (LUCENE-8183) HyphenationCompoundWordTokenFilter creates overlapping tokens with onlyLongestMatch enabled

2020-10-21 Thread Martin Demberger (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218239#comment-17218239 ] Martin Demberger edited comment on LUCENE-8183 at 10/21/20, 5:28 PM: -

[jira] [Commented] (SOLR-14954) Heavily edit reindexing.adoc

2020-10-21 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218421#comment-17218421 ] Cassandra Targett commented on SOLR-14954: -- The PR linked here has been closed w

[jira] [Commented] (LUCENE-9455) ExitableTermsEnum (in ExitableDirectoryReader) should sample next()

2020-10-21 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218367#comment-17218367 ] Bruno Roustant commented on LUCENE-9455: I propose to also sample the call to Qu

[GitHub] [lucene-solr] bruno-roustant commented on pull request #1998: LUCENE-9455: ExitableTermsEnum should sample timeout and interruption check before calling next()

2020-10-21 Thread GitBox
bruno-roustant commented on pull request #1998: URL: https://github.com/apache/lucene-solr/pull/1998#issuecomment-713674928 I have an idea to sample the timeout check in ExitableTermsEnum constructor. Obviously not based on the counter which is always 0 at that point, but rather based on p

[GitHub] [lucene-solr] madrob closed pull request #1974: SOLR-14914: Add option to disable metrics collection

2020-10-21 Thread GitBox
madrob closed pull request #1974: URL: https://github.com/apache/lucene-solr/pull/1974 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] madrob commented on a change in pull request #1993: .gitignore clean up

2020-10-21 Thread GitBox
madrob commented on a change in pull request #1993: URL: https://github.com/apache/lucene-solr/pull/1993#discussion_r509401433 ## File path: .gitignore ## @@ -1,42 +1,33 @@ -# . -/eclipse-build -/maven-build -/classes -build -/idea-build -dist -lib -test-lib -/*~ -/build.proper

[jira] [Commented] (SOLR-14935) Solr can forward request ( remoteQuery ) even if there are local cores present

2020-10-21 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218359#comment-17218359 ] Mike Drob commented on SOLR-14935: -- Is there an additional gain to be had by checking al

[GitHub] [lucene-solr] vpranckaitis closed pull request #426: SOLR-12595: CloudSolrClient.Builder accepts ZK connection strings

2020-10-21 Thread GitBox
vpranckaitis closed pull request #426: URL: https://github.com/apache/lucene-solr/pull/426 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (SOLR-14940) ReplicationHandler memory leak through SolrCore.closeHooks

2020-10-21 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218322#comment-17218322 ] Mike Drob commented on SOLR-14940: -- So I _think_ the patch you have is good, but I'd rea

[GitHub] [lucene-solr] thelabdude commented on pull request #2010: SOLR-12182: Store URL scheme as replaceable parameter in state.json

2020-10-21 Thread GitBox
thelabdude commented on pull request #2010: URL: https://github.com/apache/lucene-solr/pull/2010#issuecomment-713631088 Switched this to draft as we need a better solution for migrating from using `http` -> `https` using a rolling restart where some nodes will still be using `http` and oth

[jira] [Commented] (LUCENE-9455) ExitableTermsEnum (in ExitableDirectoryReader) should sample next()

2020-10-21 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218292#comment-17218292 ] Bruno Roustant commented on LUCENE-9455: Thanks [~zacharymorn]. I added comments

[GitHub] [lucene-solr] thelabdude commented on pull request #2010: SOLR-12182: Store URL scheme as replaceable parameter in state.json

2020-10-21 Thread GitBox
thelabdude commented on pull request #2010: URL: https://github.com/apache/lucene-solr/pull/2010#issuecomment-713573260 @murblanc right, using `${scheme}://` doesn't matter at all except for making it clear that gets replaced at runtime, at least to me, it makes it clear that is a variable

[GitHub] [lucene-solr] bruno-roustant commented on pull request #1998: LUCENE-9455: ExitableTermsEnum should sample timeout and interruption check before calling next()

2020-10-21 Thread GitBox
bruno-roustant commented on pull request #1998: URL: https://github.com/apache/lucene-solr/pull/1998#issuecomment-713568936 Overall I wonder if we can do better with the sampling. The goal is to avoid doing numerous repetitive calls to QueryTimeout.shouldExit(). This is essentially the cas

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1998: LUCENE-9455: ExitableTermsEnum should sample timeout and interruption check before calling next()

2020-10-21 Thread GitBox
bruno-roustant commented on a change in pull request #1998: URL: https://github.com/apache/lucene-solr/pull/1998#discussion_r509144461 ## File path: lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ## @@ -496,35 +496,38 @@ public TermsEnum iterator() t

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1998: LUCENE-9455: ExitableTermsEnum should sample timeout and interruption check before calling next()

2020-10-21 Thread GitBox
bruno-roustant commented on a change in pull request #1998: URL: https://github.com/apache/lucene-solr/pull/1998#discussion_r509142656 ## File path: lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ## @@ -496,35 +496,38 @@ public TermsEnum iterator() t

[GitHub] [lucene-solr] MartinDemberger opened a new pull request #2014: LUCENE-4434: Added the abbility to get noSubMatches and noOverlapping Matches

2020-10-21 Thread GitBox
MartinDemberger opened a new pull request #2014: URL: https://github.com/apache/lucene-solr/pull/2014 # Description This is the solution for LUCENE-4434. The change is taken form the patch in the workitem. # Solution ## New Parameters: noSubMatches: t

[GitHub] [lucene-solr] Hronom closed pull request #1864: SOLR-14850 ExactStatsCache NullPointerException when shards.tolerant=true

2020-10-21 Thread GitBox
Hronom closed pull request #1864: URL: https://github.com/apache/lucene-solr/pull/1864 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] Hronom commented on pull request #1864: SOLR-14850 ExactStatsCache NullPointerException when shards.tolerant=true

2020-10-21 Thread GitBox
Hronom commented on pull request #1864: URL: https://github.com/apache/lucene-solr/pull/1864#issuecomment-713514040 Ok This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Resolved] (SOLR-14445) Add documentation about the DIH Entity Caching

2020-10-21 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-14445. Resolution: Fixed Thanks Tobias. You may be interested in [https://github.com/rohitbemax/dataimpor

[jira] [Updated] (SOLR-14445) Add documentation about the DIH Entity Caching

2020-10-21 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-14445: --- Fix Version/s: 8.8 > Add documentation about the DIH Entity Caching > ---

[jira] [Commented] (SOLR-14445) Add documentation about the DIH Entity Caching

2020-10-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218249#comment-17218249 ] ASF subversion and git services commented on SOLR-14445: Commit 3

[GitHub] [lucene-solr] janhoy merged pull request #2013: SOLR-14445: Add Entity Caching documentation

2020-10-21 Thread GitBox
janhoy merged pull request #2013: URL: https://github.com/apache/lucene-solr/pull/2013 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] yonik closed pull request #987: SOLR-13884: add ConcurrentCreateCollectionTest test

2020-10-21 Thread GitBox
yonik closed pull request #987: URL: https://github.com/apache/lucene-solr/pull/987 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene-solr] janhoy opened a new pull request #2013: SOLR-14445: Add Entity Caching documentation

2020-10-21 Thread GitBox
janhoy opened a new pull request #2013: URL: https://github.com/apache/lucene-solr/pull/2013 PR against branch_8x. Superseeds #1466 which was for master. @tkaessmann This is an automated message from the Apache Git Ser

[GitHub] [lucene-solr] janhoy closed pull request #1466: SOLR-14445: Add Entity Caching documentation

2020-10-21 Thread GitBox
janhoy closed pull request #1466: URL: https://github.com/apache/lucene-solr/pull/1466 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] sigram commented on pull request #1048: SOLR-13806: change type of QueryResponse._explainMap

2020-10-21 Thread GitBox
sigram commented on pull request #1048: URL: https://github.com/apache/lucene-solr/pull/1048#issuecomment-713505547 @gunasekhardora this has been merged manually, can you please close this PR? Thanks! This is an automated me

[GitHub] [lucene-solr] sigram commented on pull request #987: SOLR-13884: add ConcurrentCreateCollectionTest test

2020-10-21 Thread GitBox
sigram commented on pull request #987: URL: https://github.com/apache/lucene-solr/pull/987#issuecomment-713504871 @yonik this has been merged manually, can you close the PR? Thanks! This is an automated message from the Apach

[jira] [Reopened] (SOLR-14445) Add documentation about the DIH Entity Caching

2020-10-21 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reopened SOLR-14445: Assignee: Jan Høydahl Even if DIH is gone in 9.x we can still accept doc patches for 8.x, reopeni

[GitHub] [lucene-solr] sigram commented on pull request #1864: SOLR-14850 ExactStatsCache NullPointerException when shards.tolerant=true

2020-10-21 Thread GitBox
sigram commented on pull request #1864: URL: https://github.com/apache/lucene-solr/pull/1864#issuecomment-713504160 @Hronom this has been merged manually, please close this PR - thanks! This is an automated message from the A

[jira] [Commented] (LUCENE-8183) HyphenationCompoundWordTokenFilter creates overlapping tokens with onlyLongestMatch enabled

2020-10-21 Thread Martin Demberger (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218239#comment-17218239 ] Martin Demberger commented on LUCENE-8183: -- Hi [~uschindler], if it's OK for y

[GitHub] [lucene-solr] janhoy closed pull request #1667: SOLR-14645 Make FileListEntityProcessor streaming to prevent OOM

2020-10-21 Thread GitBox
janhoy closed pull request #1667: URL: https://github.com/apache/lucene-solr/pull/1667 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] janhoy commented on pull request #8: Do not log error messages, if client has been interrupted

2020-10-21 Thread GitBox
janhoy commented on pull request #8: URL: https://github.com/apache/lucene-solr/pull/8#issuecomment-713491394 @markus-s24 This is a small PR - does it have a corresponding JIRA issue? Would you like to attempt to get it merged by resolving the conflict? ---

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1996: SOLR-14907: Adding V2 API for ConfigSet Upload.

2020-10-21 Thread GitBox
murblanc commented on a change in pull request #1996: URL: https://github.com/apache/lucene-solr/pull/1996#discussion_r509145391 ## File path: solr/core/src/java/org/apache/solr/handler/ClusterAPI.java ## @@ -133,6 +134,62 @@ public void create(PayloadObj obj) throws Exception

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1996: SOLR-14907: Adding V2 API for ConfigSet Upload.

2020-10-21 Thread GitBox
murblanc commented on a change in pull request #1996: URL: https://github.com/apache/lucene-solr/pull/1996#discussion_r509145391 ## File path: solr/core/src/java/org/apache/solr/handler/ClusterAPI.java ## @@ -133,6 +134,62 @@ public void create(PayloadObj obj) throws Exception

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1996: SOLR-14907: Adding V2 API for ConfigSet Upload.

2020-10-21 Thread GitBox
murblanc commented on a change in pull request #1996: URL: https://github.com/apache/lucene-solr/pull/1996#discussion_r509146710 ## File path: solr/core/src/java/org/apache/solr/handler/ClusterAPI.java ## @@ -133,6 +134,62 @@ public void create(PayloadObj obj) throws Exception

[jira] [Updated] (SOLR-14907) Support single file upload/overwrite in configSet API

2020-10-21 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-14907: -- Description: After SOLR-10391 was implemented, users are now able to overwrite existing configSets usi

[GitHub] [lucene-solr] murblanc commented on pull request #2010: SOLR-12182: Store URL scheme as replaceable parameter in state.json

2020-10-21 Thread GitBox
murblanc commented on pull request #2010: URL: https://github.com/apache/lucene-solr/pull/2010#issuecomment-713418066 Why store `${scheme}://` in Zookeeper? We could store the rest of the URL (`host:port/path`) given we'll rebuild the URL from configuration available elsewhere. For exis

[jira] [Commented] (SOLR-14948) Autoscaling maxComputeOperations override causes exceptions

2020-10-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218174#comment-17218174 ] ASF subversion and git services commented on SOLR-14948: Commit 6