epugh opened a new pull request #2015: URL: https://github.com/apache/lucene-solr/pull/2015
# Description The scripting update processor is both powerful but also potentially dangerous, and shouldn't ship with Solr by default. # Solution Move the Stateless Script Update Processor out of `/core` and into `/contrib` so you need to install it. I have not yet tried to make it a Solr Package. Also, I am not happy with the word `Stateless` in the name of the update processor. I'd love to see what others thought on just renaming `StatelessScriptUpdateProcessorFactory` to just `ScriptUpdateProcessorFactory`. There is not `Stateful` equivalent, and it seems to me to obscure what this update processor is all about! # Tests I've run the existing tests and they pass. # Checklist Please review the following and check all that apply: - [ X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ X] I have created a Jira issue and added the issue ID to my pull request title. - [ X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ X] I have developed this patch against the `master` branch. - [ ] I have run `./gradlew check`. - [ X] I have added tests for my changes. - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
