bruno-roustant commented on pull request #1998: URL: https://github.com/apache/lucene-solr/pull/1998#issuecomment-713568936
Overall I wonder if we can do better with the sampling. The goal is to avoid doing numerous repetitive calls to QueryTimeout.shouldExit(). This is essentially the case for multi-terms queries. But actually for multi-terms queries, a new TermsEnum is created for each matching term (to get doc ids). So we end up only sampling half of the calls to QueryTimeout.shouldExit() since the other half is done by the ExitableTermsEnum constructor which is not sampled. It would be better to also sample the ExitableTermsEnum constructor, but I don't know yet how to do that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
