zacharymorn commented on a change in pull request #1998:
URL: https://github.com/apache/lucene-solr/pull/1998#discussion_r509844706
##########
File path:
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java
##########
@@ -496,35 +496,38 @@ public TermsEnum iterator() throws IOException {
* exitable enumeration of terms.
*/
public static class ExitableTermsEnum extends FilterTermsEnum {
-
+ private static final int MAX_CALLS_BEFORE_QUERY_TIMEOUT_CHECK = (1 << 4) -
1; // 15
Review comment:
Renamed to `NUM_CALLS_PER_TIMEOUT_CHECK`
For
> this value must be a power of two
Which value are you referring to, as "15" is not power of two? I've added
this comment to clarify the purpose of computation:
```
// Create bit mask in the form of 0000 1111 for efficient checking
```
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
