Re: [PR] fix: speficy the version of munge for msrv check [iceberg-rust]

2025-02-23 Thread via GitHub
xxchan commented on code in PR #987: URL: https://github.com/apache/iceberg-rust/pull/987#discussion_r1966723174 ## .github/workflows/ci.yml: ## @@ -152,6 +152,8 @@ jobs: # Some dependencies don't correctly specify a minimal version for their dependencies and will fa

Re: [PR] fix: speficy the version of munge for msrv check [iceberg-rust]

2025-02-23 Thread via GitHub
ZENOTME commented on code in PR #987: URL: https://github.com/apache/iceberg-rust/pull/987#discussion_r1966725077 ## .github/workflows/ci.yml: ## @@ -152,6 +152,8 @@ jobs: # Some dependencies don't correctly specify a minimal version for their dependencies and will f

Re: [I] RUSTSEC-2025-0007: *ring* is unmaintained [iceberg-rust]

2025-02-23 Thread via GitHub
xxchan commented on issue #985: URL: https://github.com/apache/iceberg-rust/issues/985#issuecomment-2676745851 This is withdrawn https://github.com/rustsec/advisory-db/pull/2230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] HTTPRequest: don't remove trailing slash from absolute paths [iceberg]

2025-02-23 Thread via GitHub
ajantha-bhat commented on code in PR #12389: URL: https://github.com/apache/iceberg/pull/12389#discussion_r1966767782 ## core/src/main/java/org/apache/iceberg/rest/HTTPRequest.java: ## @@ -53,13 +53,16 @@ enum HTTPMethod { */ @Value.Lazy default URI requestUri() { -

Re: [I] Implement size-based task planning [iceberg-rust]

2025-02-23 Thread via GitHub
xxchan commented on issue #344: URL: https://github.com/apache/iceberg-rust/issues/344#issuecomment-2676846121 duplicate with #128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] HTTPRequest: don't remove trailing slash from absolute paths [iceberg]

2025-02-23 Thread via GitHub
ajantha-bhat commented on PR #12389: URL: https://github.com/apache/iceberg/pull/12389#issuecomment-2676845372 @adutra: Thanks for the quick fix. Once, nit is handled, please raise the same PR against branch 1.8.x https://github.com/apache/iceberg/tree/1.8.x -- This is an automated mes

[PR] chore(deps): Bump anyhow from 1.0.95 to 1.0.96 [iceberg-rust]

2025-02-23 Thread via GitHub
dependabot[bot] opened a new pull request, #996: URL: https://github.com/apache/iceberg-rust/pull/996 Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.95 to 1.0.96. Release notes Sourced from https://github.com/dtolnay/anyhow/releases";>anyhow's releases. 1.0.96

[PR] chore(deps): Bump crate-ci/typos from 1.29.7 to 1.29.9 [iceberg-rust]

2025-02-23 Thread via GitHub
dependabot[bot] opened a new pull request, #988: URL: https://github.com/apache/iceberg-rust/pull/988 Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.29.7 to 1.29.9. Release notes Sourced from https://github.com/crate-ci/typos/releases";>crate-ci/typos's releases.

[PR] refactor: Split schema module to multi file module [iceberg-rust]

2025-02-23 Thread via GitHub
xxchan opened a new pull request, #989: URL: https://github.com/apache/iceberg-rust/pull/989 close #981 - `Schema` and `SchemaBuilder` are kept in `schema/mod.rs` - All other individual functions (along with the tests) are moved into a new file. -- This is an automated message f

Re: [PR] fix: speficy the version of munge for msrv check [iceberg-rust]

2025-02-23 Thread via GitHub
xxchan commented on code in PR #987: URL: https://github.com/apache/iceberg-rust/pull/987#discussion_r1966767492 ## .github/workflows/ci.yml: ## @@ -152,6 +152,8 @@ jobs: # Some dependencies don't correctly specify a minimal version for their dependencies and will fa

[PR] chore(deps): Bump rand from 0.8.5 to 0.9.0 [iceberg-rust]

2025-02-23 Thread via GitHub
dependabot[bot] opened a new pull request, #992: URL: https://github.com/apache/iceberg-rust/pull/992 Bumps [rand](https://github.com/rust-random/rand) from 0.8.5 to 0.9.0. Changelog Sourced from https://github.com/rust-random/rand/blob/master/CHANGELOG.md";>rand's changelog.

[PR] chore(deps): Bump itertools from 0.13.0 to 0.14.0 [iceberg-rust]

2025-02-23 Thread via GitHub
dependabot[bot] opened a new pull request, #990: URL: https://github.com/apache/iceberg-rust/pull/990 Bumps [itertools](https://github.com/rust-itertools/itertools) from 0.13.0 to 0.14.0. Changelog Sourced from https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md";>

[PR] chore(deps): Bump log from 0.4.25 to 0.4.26 [iceberg-rust]

2025-02-23 Thread via GitHub
dependabot[bot] opened a new pull request, #991: URL: https://github.com/apache/iceberg-rust/pull/991 Bumps [log](https://github.com/rust-lang/log) from 0.4.25 to 0.4.26. Release notes Sourced from https://github.com/rust-lang/log/releases";>log's releases. 0.4.26 What's C

Re: [PR] refactor: Split schema module to multi file module [iceberg-rust]

2025-02-23 Thread via GitHub
xxchan commented on PR #989: URL: https://github.com/apache/iceberg-rust/pull/989#issuecomment-2676839168 cc @liurenjie1024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] chore(deps): Bump zstd from 0.13.2 to 0.13.3 [iceberg-rust]

2025-02-23 Thread via GitHub
dependabot[bot] opened a new pull request, #994: URL: https://github.com/apache/iceberg-rust/pull/994 Bumps [zstd](https://github.com/gyscos/zstd-rs) from 0.13.2 to 0.13.3. Commits https://github.com/gyscos/zstd-rs/commit/52e9d41a645fb49edcf1ed3df765f380dbcf13b2";>52e9d41 zstd

[PR] chore(deps): Bump serde from 1.0.217 to 1.0.218 [iceberg-rust]

2025-02-23 Thread via GitHub
dependabot[bot] opened a new pull request, #993: URL: https://github.com/apache/iceberg-rust/pull/993 Bumps [serde](https://github.com/serde-rs/serde) from 1.0.217 to 1.0.218. Release notes Sourced from https://github.com/serde-rs/serde/releases";>serde's releases. v1.0.218

[PR] chore(deps): Bump serde_json from 1.0.138 to 1.0.139 [iceberg-rust]

2025-02-23 Thread via GitHub
dependabot[bot] opened a new pull request, #995: URL: https://github.com/apache/iceberg-rust/pull/995 Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.138 to 1.0.139. Release notes Sourced from https://github.com/serde-rs/json/releases";>serde_json's releases. v

[PR] chore(deps): Bump uuid from 1.13.2 to 1.14.0 [iceberg-rust]

2025-02-23 Thread via GitHub
dependabot[bot] opened a new pull request, #997: URL: https://github.com/apache/iceberg-rust/pull/997 Bumps [uuid](https://github.com/uuid-rs/uuid) from 1.13.2 to 1.14.0. Release notes Sourced from https://github.com/uuid-rs/uuid/releases";>uuid's releases. v1.14.0 What's

Re: [PR] HTTPRequest: don't remove trailing slash from absolute paths [iceberg]

2025-02-23 Thread via GitHub
adutra commented on PR #12389: URL: https://github.com/apache/iceberg/pull/12389#issuecomment-2676847699 @ajantha-bhat here is the 1.8.x PR: #12390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [I] Proposal to refactor some large individual files into modules [iceberg-rust]

2025-02-23 Thread via GitHub
xxchan commented on issue #298: URL: https://github.com/apache/iceberg-rust/issues/298#issuecomment-2676846912 Seems we can close this one in favor of concrete tasks #981 #980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [I] Add example for document [iceberg-rust]

2025-02-23 Thread via GitHub
xxchan commented on issue #986: URL: https://github.com/apache/iceberg-rust/issues/986#issuecomment-2676855461 perhaps duplicate with #429 :p -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Docs: Fix lifecycle and versions in multi-engine-support [iceberg]

2025-02-23 Thread via GitHub
ajantha-bhat commented on code in PR #12370: URL: https://github.com/apache/iceberg/pull/12370#discussion_r1966783913 ## site/docs/multi-engine-support.md: ## @@ -67,7 +67,7 @@ Each engine version undergoes the following lifecycle stages: | 3.0| End of Life| 0.9

Re: [PR] Docs: Fix lifecycle and versions in multi-engine-support [iceberg]

2025-02-23 Thread via GitHub
manuzhang commented on code in PR #12370: URL: https://github.com/apache/iceberg/pull/12370#discussion_r1966786480 ## site/docs/multi-engine-support.md: ## @@ -67,7 +67,7 @@ Each engine version undergoes the following lifecycle stages: | 3.0| End of Life| 0.9.0

Re: [PR] Docs: Fix lifecycle and versions in multi-engine-support [iceberg]

2025-02-23 Thread via GitHub
ajantha-bhat commented on code in PR #12370: URL: https://github.com/apache/iceberg/pull/12370#discussion_r1966788144 ## site/docs/multi-engine-support.md: ## @@ -67,7 +67,7 @@ Each engine version undergoes the following lifecycle stages: | 3.0| End of Life| 0.9

[PR] chore: fix edition 2024 compile errors [iceberg-rust]

2025-02-23 Thread via GitHub
xxchan opened a new pull request, #998: URL: https://github.com/apache/iceberg-rust/pull/998 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] chore: fix edition 2024 compile errors [iceberg-rust]

2025-02-23 Thread via GitHub
xxchan commented on code in PR #998: URL: https://github.com/apache/iceberg-rust/pull/998#discussion_r1966793025 ## crates/iceberg/src/scan.rs: ## @@ -733,7 +733,7 @@ impl PlanContext { manifest_list: Arc, tx_data: Sender, delete_file_idx_and_tx: Optio

Re: [PR] chore: fix edition 2024 compile errors [iceberg-rust]

2025-02-23 Thread via GitHub
xxchan commented on code in PR #998: URL: https://github.com/apache/iceberg-rust/pull/998#discussion_r1966792744 ## crates/iceberg/src/arrow/record_batch_transformer.rs: ## @@ -140,8 +140,8 @@ impl RecordBatchTransformer { Ok(match &self.batch_transform { S

Re: [PR] Docs: Fix lifecycle and versions in multi-engine-support [iceberg]

2025-02-23 Thread via GitHub
manuzhang commented on code in PR #12370: URL: https://github.com/apache/iceberg/pull/12370#discussion_r1966792270 ## site/docs/multi-engine-support.md: ## @@ -67,7 +67,7 @@ Each engine version undergoes the following lifecycle stages: | 3.0| End of Life| 0.9.0

Re: [I] Delete Files in Table Scans [iceberg-rust]

2025-02-23 Thread via GitHub
sdd commented on issue #630: URL: https://github.com/apache/iceberg-rust/issues/630#issuecomment-2676912068 I've worked on an improved design for loading and parsing of delete files by the `DeleteFileManager`. The code for this can be seen in https://github.com/apache/iceberg-rust/pull/982.

Re: [PR] Build: Bump junit from 5.11.4 to 5.12.0 [iceberg]

2025-02-23 Thread via GitHub
manuzhang commented on PR #12378: URL: https://github.com/apache/iceberg/pull/12378#issuecomment-2676910167 Tests failed with following exception ``` org.gradle.api.internal.tasks.testing.TestSuiteExecutionException: Could not complete execution for Gradle Test Executor 2. at

Re: [PR] Arrow: Suppress warning and cache bucket location [iceberg-python]

2025-02-23 Thread via GitHub
hussein-awala commented on code in PR #1709: URL: https://github.com/apache/iceberg-python/pull/1709#discussion_r1966816889 ## pyiceberg/io/pyarrow.py: ## @@ -414,19 +421,19 @@ def _initialize_oss_fs(self) -> FileSystem: return S3FileSystem(**client_kwargs) def _

Re: [PR] fix: speficy the version of munge for msrv check [iceberg-rust]

2025-02-23 Thread via GitHub
ZENOTME commented on code in PR #987: URL: https://github.com/apache/iceberg-rust/pull/987#discussion_r1966816961 ## .github/workflows/ci.yml: ## @@ -152,6 +152,8 @@ jobs: # Some dependencies don't correctly specify a minimal version for their dependencies and will f

Re: [PR] Build: Bump junit from 5.11.4 to 5.12.0 [iceberg]

2025-02-23 Thread via GitHub
manuzhang commented on PR #12378: URL: https://github.com/apache/iceberg/pull/12378#issuecomment-2676935863 I tried upgrading `junit-platform` to 1.12.0 at the same time (as in #12381) but still seeing the same error. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Spec additions for encryption [iceberg]

2025-02-23 Thread via GitHub
smaheshwar-pltr commented on code in PR #12162: URL: https://github.com/apache/iceberg/pull/12162#discussion_r1966823087 ## format/spec.md: ## @@ -975,6 +978,23 @@ The unified partition type looks like `Struct`. and then the table has evolved into `spec#1` which has just one fi

Re: [PR] Spec additions for encryption [iceberg]

2025-02-23 Thread via GitHub
smaheshwar-pltr commented on code in PR #12162: URL: https://github.com/apache/iceberg/pull/12162#discussion_r1966827127 ## format/spec.md: ## @@ -975,6 +978,23 @@ The unified partition type looks like `Struct`. and then the table has evolved into `spec#1` which has just one fi

Re: [I] Add example for document [iceberg-rust]

2025-02-23 Thread via GitHub
jonathanc-n commented on issue #986: URL: https://github.com/apache/iceberg-rust/issues/986#issuecomment-2677061604 i can probably write out some datafusion examples -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Split transaction mod to multi files mod. [iceberg-rust]

2025-02-23 Thread via GitHub
jonathanc-n commented on issue #980: URL: https://github.com/apache/iceberg-rust/issues/980#issuecomment-2677064517 I'll work on this after #960 gets merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[PR] ci(golangci-lint) :Add golangci linter [iceberg-go]

2025-02-23 Thread via GitHub
dttung2905 opened a new pull request, #315: URL: https://github.com/apache/iceberg-go/pull/315 From the feedback https://github.com/apache/iceberg-go/pull/306#discussion_r1960205322, I'm adding golangci-lint in GIthub Action CI. There are many different linters but I'm just adding the most

Re: [PR] Feature: Write to branches [iceberg-python]

2025-02-23 Thread via GitHub
vinjai commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1966875880 ## pyiceberg/table/update/__init__.py: ## @@ -609,11 +609,14 @@ class AssertRefSnapshotId(ValidatableTableRequirement): type: Literal["assert-ref-snapshot-id

Re: [PR] Feature: Write to branches [iceberg-python]

2025-02-23 Thread via GitHub
vinjai commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1966876035 ## tests/integration/test_writes/test_writes.py: ## @@ -1570,3 +1572,158 @@ def test_abort_table_transaction_on_exception( # Validate the transaction is abor

[PR] Build: Bump junit to v5.12.0 [iceberg]

2025-02-23 Thread via GitHub
iProdigy opened a new pull request, #12391: URL: https://github.com/apache/iceberg/pull/12391 Closes #12378 Closes #12381 As of Gradle 8, not explicitly depending upon `junit-platform-launcher` is [deprecated](https://docs.gradle.org/8.12/userguide/upgrading_version_8.html#test_fra

[PR] fix: refine doc for write support [iceberg-rust]

2025-02-23 Thread via GitHub
ZENOTME opened a new pull request, #999: URL: https://github.com/apache/iceberg-rust/pull/999 Part of #986. This PR adds more examples to refine the doc of writer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Handling no coordinator and data loss in current design in icr mode [iceberg]

2025-02-23 Thread via GitHub
bryanck commented on PR #12372: URL: https://github.com/apache/iceberg/pull/12372#issuecomment-2677156270 We should add some comments, and also tests if feasible. Also looks like there are some code formatting issues. -- This is an automated message from the Apache Git Service. To respond

Re: [I] Clean up TODOs in the codebase [iceberg-python]

2025-02-23 Thread via GitHub
github-actions[bot] commented on issue #1052: URL: https://github.com/apache/iceberg-python/issues/1052#issuecomment-2677208877 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the A

Re: [PR] V3: Introduce `timestamp_ns` and `timestamptz_ns` [iceberg-python]

2025-02-23 Thread via GitHub
sungwy commented on PR #1632: URL: https://github.com/apache/iceberg-python/pull/1632#issuecomment-2677291293 I think it would make sense to break this PR up into two separate items: 1. one to introduce timestamp_ns and timestamptz_ns support 2. one to introduce parsing NS timestamps fr

Re: [PR] Data: Handle case where partition location is missing for `TableMigrationUtil` [iceberg]

2025-02-23 Thread via GitHub
jshmchenxi commented on PR #12212: URL: https://github.com/apache/iceberg/pull/12212#issuecomment-2677323705 @RussellSpitzer Hi, does anything else need to be updated for this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] fix: speficy the version of munge for msrv check [iceberg-rust]

2025-02-23 Thread via GitHub
xxchan commented on code in PR #987: URL: https://github.com/apache/iceberg-rust/pull/987#discussion_r1967056759 ## .github/workflows/ci.yml: ## @@ -152,6 +152,8 @@ jobs: # Some dependencies don't correctly specify a minimal version for their dependencies and will fa

Re: [PR] fix: speficy the version of munge for msrv check [iceberg-rust]

2025-02-23 Thread via GitHub
xxchan commented on code in PR #987: URL: https://github.com/apache/iceberg-rust/pull/987#discussion_r1967057444 ## .github/workflows/ci.yml: ## @@ -152,6 +152,8 @@ jobs: # Some dependencies don't correctly specify a minimal version for their dependencies and will fa

Re: [PR] fix: speficy the version of munge for msrv check [iceberg-rust]

2025-02-23 Thread via GitHub
Xuanwo commented on code in PR #987: URL: https://github.com/apache/iceberg-rust/pull/987#discussion_r1967067929 ## .github/workflows/ci.yml: ## @@ -152,6 +152,8 @@ jobs: # Some dependencies don't correctly specify a minimal version for their dependencies and will fa

Re: [PR] fix: speficy the version of munge for msrv check [iceberg-rust]

2025-02-23 Thread via GitHub
Xuanwo commented on code in PR #987: URL: https://github.com/apache/iceberg-rust/pull/987#discussion_r1967067929 ## .github/workflows/ci.yml: ## @@ -152,6 +152,8 @@ jobs: # Some dependencies don't correctly specify a minimal version for their dependencies and will fa

Re: [PR] fix: speficy the version of munge for msrv check [iceberg-rust]

2025-02-23 Thread via GitHub
ZENOTME commented on code in PR #987: URL: https://github.com/apache/iceberg-rust/pull/987#discussion_r1967070437 ## .github/workflows/ci.yml: ## @@ -152,6 +152,8 @@ jobs: # Some dependencies don't correctly specify a minimal version for their dependencies and will f

Re: [PR] fix: speficy the version of munge for msrv check [iceberg-rust]

2025-02-23 Thread via GitHub
xxchan commented on code in PR #987: URL: https://github.com/apache/iceberg-rust/pull/987#discussion_r1967073476 ## .github/workflows/ci.yml: ## @@ -152,6 +152,8 @@ jobs: # Some dependencies don't correctly specify a minimal version for their dependencies and will fa

Re: [I] [bug] unnecessary calls to `resolve_s3_region` [iceberg-python]

2025-02-23 Thread via GitHub
Fokko commented on issue #1708: URL: https://github.com/apache/iceberg-python/issues/1708#issuecomment-2677506529 Hey @kevinjqliu I think that's a fair approach. Also, looking at the Java implementation, for the multi-region setups, they use a different approach: https://iceberg.apache.org

Re: [I] [bug] unnecessary calls to `resolve_s3_region` [iceberg-python]

2025-02-23 Thread via GitHub
Fokko commented on issue #1708: URL: https://github.com/apache/iceberg-python/issues/1708#issuecomment-2677517305 I've also enabled the region to be resolved when it isn't set. Based on https://github.com/apache/iceberg-python/issues/1705#issue-2870476675 it looks like the region was not s

Re: [PR] fix: speficy the version of munge for msrv check [iceberg-rust]

2025-02-23 Thread via GitHub
Xuanwo commented on code in PR #987: URL: https://github.com/apache/iceberg-rust/pull/987#discussion_r1967084652 ## .github/workflows/ci.yml: ## @@ -152,6 +152,8 @@ jobs: # Some dependencies don't correctly specify a minimal version for their dependencies and will fa

Re: [PR] fix: speficy the version of munge for msrv check [iceberg-rust]

2025-02-23 Thread via GitHub
Xuanwo commented on code in PR #987: URL: https://github.com/apache/iceberg-rust/pull/987#discussion_r1967084652 ## .github/workflows/ci.yml: ## @@ -152,6 +152,8 @@ jobs: # Some dependencies don't correctly specify a minimal version for their dependencies and will fa

[PR] Hive:Fix Hive table creation syntax errors [iceberg]

2025-02-23 Thread via GitHub
qining-mj opened a new pull request, #12393: URL: https://github.com/apache/iceberg/pull/12393 iceberg/docs/docs/hive.md In the document Hive table creation statement word error, STORED BY written as STORED AS. **Incorrect statement** ![e1](https://github.com/user-attachments/

Re: [PR] Hive:Fix Hive table creation syntax errors [iceberg]

2025-02-23 Thread via GitHub
qining-mj closed pull request #12393: Hive:Fix Hive table creation syntax errors URL: https://github.com/apache/iceberg/pull/12393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] fix: speficy the version of munge for msrv check [iceberg-rust]

2025-02-23 Thread via GitHub
ZENOTME commented on code in PR #987: URL: https://github.com/apache/iceberg-rust/pull/987#discussion_r1967114467 ## .github/workflows/ci.yml: ## @@ -152,6 +152,8 @@ jobs: # Some dependencies don't correctly specify a minimal version for their dependencies and will f

Re: [PR] fix: speficy the version of munge for msrv check [iceberg-rust]

2025-02-23 Thread via GitHub
ZENOTME commented on code in PR #987: URL: https://github.com/apache/iceberg-rust/pull/987#discussion_r1967114467 ## .github/workflows/ci.yml: ## @@ -152,6 +152,8 @@ jobs: # Some dependencies don't correctly specify a minimal version for their dependencies and will f

Re: [I] Add example for document [iceberg-rust]

2025-02-23 Thread via GitHub
ZENOTME commented on issue #986: URL: https://github.com/apache/iceberg-rust/issues/986#issuecomment-2677580156 > i can probably write out some datafusion examples Thanks! Feel free to send PR for this. -- This is an automated message from the Apache Git Service. To respond to the m

[PR] [hive]:Fix Hive table creation syntax errors [iceberg]

2025-02-23 Thread via GitHub
qining-mj opened a new pull request, #12394: URL: https://github.com/apache/iceberg/pull/12394 iceberg/docs/docs/hive.md In the document Hive table creation statement word error, STORED BY written as STORED AS. **Incorrect statement** ![e1](https://github.com/user-attachm

Re: [PR] HTTPRequest: don't remove trailing slash from absolute paths [1.8.x] [iceberg]

2025-02-23 Thread via GitHub
mwullink commented on PR #12390: URL: https://github.com/apache/iceberg/pull/12390#issuecomment-2677590076 Nice, thanks for the quick fix! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Backport #11702 to FLink1.19 and 1.18 [iceberg]

2025-02-23 Thread via GitHub
huyuanfeng2018 commented on PR #12080: URL: https://github.com/apache/iceberg/pull/12080#issuecomment-2677593994 Hi, @stevenzwu , The pr's been ready for a while. Have you had time to look at it? Thansk~ -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] [1.8.x] Fix versions in LICENSE/NOTICE [iceberg]

2025-02-23 Thread via GitHub
nastra commented on code in PR #12365: URL: https://github.com/apache/iceberg/pull/12365#discussion_r1967144485 ## aws-bundle/LICENSE: ## @@ -219,7 +219,7 @@ License: The Apache Software License, Version 2.0 - http://www.apache.org/licens ---

Re: [PR] [1.8.x] Fix versions in LICENSE/NOTICE [iceberg]

2025-02-23 Thread via GitHub
jbonofre commented on code in PR #12365: URL: https://github.com/apache/iceberg/pull/12365#discussion_r1967146075 ## aws-bundle/LICENSE: ## @@ -219,7 +219,7 @@ License: The Apache Software License, Version 2.0 - http://www.apache.org/licens -

[PR] build(deps): bump the gomod_updates group with 16 updates [iceberg-go]

2025-02-23 Thread via GitHub
dependabot[bot] opened a new pull request, #314: URL: https://github.com/apache/iceberg-go/pull/314 Bumps the gomod_updates group with 16 updates: | Package | From | To | | --- | --- | --- | | [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2) | `1.36.1` | `1.3

Re: [I] Iceberg 1.8.0 Breaking oauth2 authentication [iceberg]

2025-02-23 Thread via GitHub
adutra commented on issue #12373: URL: https://github.com/apache/iceberg/issues/12373#issuecomment-2676765354 Hi @mwullink thanks for reporting this issue. It's nice to see people using Authentik :-) I am not sure Iceberg 1.8.0 has changed anything wrt trailing slashes though.

Re: [PR] Spec additions for encryption [iceberg]

2025-02-23 Thread via GitHub
smaheshwar-pltr commented on code in PR #12162: URL: https://github.com/apache/iceberg/pull/12162#discussion_r1966828077 ## format/spec.md: ## @@ -975,6 +978,23 @@ The unified partition type looks like `Struct`. and then the table has evolved into `spec#1` which has just one fi

Re: [PR] Arrow: Suppress warning and cache bucket location [iceberg-python]

2025-02-23 Thread via GitHub
kevinjqliu commented on PR #1709: URL: https://github.com/apache/iceberg-python/pull/1709#issuecomment-2677145552 Thanks for the suggestion @hussein-awala I like this approach. My only question before proceeding is whether we want the `resolve_s3_region` behavior to be on by default.

Re: [PR] Handling no coordinator and data loss in current design in icr mode [iceberg]

2025-02-23 Thread via GitHub
bryanck commented on code in PR #12372: URL: https://github.com/apache/iceberg/pull/12372#discussion_r1966908971 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java: ## @@ -46,26 +45,31 @@ public String version() { @Override public

Re: [PR] Handling no coordinator and data loss in current design in icr mode [iceberg]

2025-02-23 Thread via GitHub
bryanck commented on code in PR #12372: URL: https://github.com/apache/iceberg/pull/12372#discussion_r1966909662 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/ResourceType.java: ## @@ -0,0 +1,27 @@ +/* + * + * * Licensed to the Apache Software Foundati

Re: [PR] Handling no coordinator and data loss in current design in icr mode [iceberg]

2025-02-23 Thread via GitHub
bryanck commented on code in PR #12372: URL: https://github.com/apache/iceberg/pull/12372#discussion_r1966910819 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CommitterImpl.java: ## @@ -57,49 +83,67 @@ public int compare(TopicPartition o1, Topic

Re: [PR] Handling no coordinator and data loss in current design in icr mode [iceberg]

2025-02-23 Thread via GitHub
bryanck commented on code in PR #12372: URL: https://github.com/apache/iceberg/pull/12372#discussion_r1966910314 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CommitterImpl.java: ## @@ -57,49 +83,67 @@ public int compare(TopicPartition o1, Topic

Re: [PR] Handling no coordinator and data loss in current design in icr mode [iceberg]

2025-02-23 Thread via GitHub
bryanck commented on code in PR #12372: URL: https://github.com/apache/iceberg/pull/12372#discussion_r1966910314 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CommitterImpl.java: ## @@ -57,49 +83,67 @@ public int compare(TopicPartition o1, Topic

Re: [PR] Handling no coordinator and data loss in current design in icr mode [iceberg]

2025-02-23 Thread via GitHub
bryanck commented on code in PR #12372: URL: https://github.com/apache/iceberg/pull/12372#discussion_r1966911457 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CommitterImpl.java: ## @@ -57,49 +83,67 @@ public int compare(TopicPartition o1, Topic

Re: [PR] Handling no coordinator and data loss in current design in icr mode [iceberg]

2025-02-23 Thread via GitHub
bryanck commented on code in PR #12372: URL: https://github.com/apache/iceberg/pull/12372#discussion_r1966912973 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CommitterImpl.java: ## @@ -57,49 +83,67 @@ public int compare(TopicPartition o1, Topic

Re: [PR] Handling no coordinator and data loss in current design in icr mode [iceberg]

2025-02-23 Thread via GitHub
bryanck commented on code in PR #12372: URL: https://github.com/apache/iceberg/pull/12372#discussion_r1966912973 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CommitterImpl.java: ## @@ -57,49 +83,67 @@ public int compare(TopicPartition o1, Topic

Re: [PR] Arrow: Suppress warning and cache bucket location [iceberg-python]

2025-02-23 Thread via GitHub
Fokko commented on code in PR #1709: URL: https://github.com/apache/iceberg-python/pull/1709#discussion_r1966885810 ## pyiceberg/io/pyarrow.py: ## @@ -414,19 +421,19 @@ def _initialize_oss_fs(self) -> FileSystem: return S3FileSystem(**client_kwargs) def _initiali

Re: [PR] Feature: Write to branches [iceberg-python]

2025-02-23 Thread via GitHub
vinjai commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2677114643 Hey @kevinjqliu I have resolved all comments. Will resolve the merge conflicts once you have gone through these changes (to avoid rework). Let me know once you have revie

Re: [PR] Feature: Write to branches [iceberg-python]

2025-02-23 Thread via GitHub
vinjai commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1966883670 ## tests/table/test_init.py: ## @@ -982,28 +982,43 @@ def test_assert_table_uuid(table_v2: Table) -> None: def test_assert_ref_snapshot_id(table_v2: Table) -> No

Re: [PR] Feature: Write to branches [iceberg-python]

2025-02-23 Thread via GitHub
vinjai commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1966882693 ## pyiceberg/table/__init__.py: ## @@ -1003,22 +1015,27 @@ def overwrite( overwrite_filter: ALWAYS_TRUE when you overwrite all the data,

Re: [PR] Feature: Write to branches [iceberg-python]

2025-02-23 Thread via GitHub
vinjai commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1966881022 ## tests/table/test_init.py: ## @@ -982,28 +982,43 @@ def test_assert_table_uuid(table_v2: Table) -> None: def test_assert_ref_snapshot_id(table_v2: Table) -> No

Re: [I] Spec: The spec about metadata key `schema-id` in manifest file do not match the lib implementation [iceberg]

2025-02-23 Thread via GitHub
github-actions[bot] commented on issue #10927: URL: https://github.com/apache/iceberg/issues/10927#issuecomment-2677206683 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [I] Accessing Minio with Pyiceberg [iceberg]

2025-02-23 Thread via GitHub
github-actions[bot] commented on issue #10709: URL: https://github.com/apache/iceberg/issues/10709#issuecomment-2677206660 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [I] Is dataFiles() Method Retryable? [iceberg]

2025-02-23 Thread via GitHub
github-actions[bot] commented on issue #10750: URL: https://github.com/apache/iceberg/issues/10750#issuecomment-2677206670 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [I] Contribution Proposal: Kafka to Iceberg Tutorial Repo [iceberg]

2025-02-23 Thread via GitHub
github-actions[bot] commented on issue #10933: URL: https://github.com/apache/iceberg/issues/10933#issuecomment-2677206702 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [I] Spec and Doc inconsistency about supported schema evolution for list and map types [iceberg]

2025-02-23 Thread via GitHub
github-actions[bot] commented on issue #11020: URL: https://github.com/apache/iceberg/issues/11020#issuecomment-2677206785 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [I] ICEBERG performance is slow when querying tables with a large number of partitions. [iceberg]

2025-02-23 Thread via GitHub
github-actions[bot] commented on issue #8161: URL: https://github.com/apache/iceberg/issues/8161#issuecomment-2677206628 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] ORC: Fix null map values and list elements in vectorized reads [iceberg]

2025-02-23 Thread via GitHub
github-actions[bot] commented on PR #12030: URL: https://github.com/apache/iceberg/pull/12030#issuecomment-2677206849 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Kafka Connect: Add delta writer support [iceberg]

2025-02-23 Thread via GitHub
github-actions[bot] commented on PR #12070: URL: https://github.com/apache/iceberg/pull/12070#issuecomment-2677206886 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [I] What should be Pyarrow's default buffer size? [iceberg-python]

2025-02-23 Thread via GitHub
github-actions[bot] commented on issue #1058: URL: https://github.com/apache/iceberg-python/issues/1058#issuecomment-2677208867 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the A

Re: [I] Clean up TODOs in the codebase [iceberg-python]

2025-02-23 Thread via GitHub
github-actions[bot] closed issue #1052: Clean up TODOs in the codebase URL: https://github.com/apache/iceberg-python/issues/1052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] What should be Pyarrow's default buffer size? [iceberg-python]

2025-02-23 Thread via GitHub
github-actions[bot] closed issue #1058: What should be Pyarrow's default buffer size? URL: https://github.com/apache/iceberg-python/issues/1058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Core: Checks for Equality Delete when Row Lineage is Enabled - Using Snapshot Summary [iceberg]

2025-02-23 Thread via GitHub
github-actions[bot] commented on PR #12075: URL: https://github.com/apache/iceberg/pull/12075#issuecomment-2677206910 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [I] `expire_snapshots` sudden increase in compute/memory usage [iceberg]

2025-02-23 Thread via GitHub
github-actions[bot] commented on issue #11017: URL: https://github.com/apache/iceberg/issues/11017#issuecomment-2677206743 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [I] Is dataFiles() Method Retryable? [iceberg]

2025-02-23 Thread via GitHub
github-actions[bot] closed issue #10750: Is dataFiles() Method Retryable? URL: https://github.com/apache/iceberg/issues/10750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] Missing records after compaction using `rewrite_data_files` [iceberg]

2025-02-23 Thread via GitHub
github-actions[bot] commented on issue #11014: URL: https://github.com/apache/iceberg/issues/11014#issuecomment-2677206730 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [I] Spec: The spec about metadata key `schema-id` in manifest file do not match the lib implementation [iceberg]

2025-02-23 Thread via GitHub
github-actions[bot] closed issue #10927: Spec: The spec about metadata key `schema-id` in manifest file do not match the lib implementation URL: https://github.com/apache/iceberg/issues/10927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Core: Select for rewriting the files belonging to old partitioning schemes [iceberg]

2025-02-23 Thread via GitHub
github-actions[bot] commented on PR #12083: URL: https://github.com/apache/iceberg/pull/12083#issuecomment-2677206960 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

  1   2   >