xxchan commented on code in PR #987:
URL: https://github.com/apache/iceberg-rust/pull/987#discussion_r1967073476
##########
.github/workflows/ci.yml:
##########
@@ -152,6 +152,8 @@ jobs:
# Some dependencies don't correctly specify a minimal version for
their dependencies and will fail to build.
# So we update these transitive dependencies here.
cargo update tap faststr metainfo linkedbytes
+ # munge 0.4.2 will cause fail to use 1.7.1 so specify the correct
version here.
+ cargo update -p munge --precise 0.4.1
Review Comment:
> “At least three months” refers to either three months after the release of
a new Rust version or three months after our last MSRV update
I believe it should be the former. Or better stated as: "DataFusion's
supports the last 4 stable Rust minor versions released and any such versions
released within the last 4 months."
https://github.com/apache/datafusion#rust-version-compatibility-policy
> Hi, I'm a bit confused why we need this. I remember that we are using
`minimal-version` to generate `Cargo.lock`?
Caused by `cargo update faststr` (you can see the comment in the ci script)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
