xxchan commented on code in PR #987:
URL: https://github.com/apache/iceberg-rust/pull/987#discussion_r1966723174
##########
.github/workflows/ci.yml:
##########
@@ -152,6 +152,8 @@ jobs:
# Some dependencies don't correctly specify a minimal version for
their dependencies and will fail to build.
# So we update these transitive dependencies here.
cargo update tap faststr metainfo linkedbytes
+ # munge 0.4.2 will cause fail to use 1.7.1 so specify the correct
version here.
+ cargo update -p munge --precise 0.4.1
Review Comment:
`munge 0.4.2` uses edition = 2024 now (which is 1.85).
https://github.com/djkoloski/munge/commit/02e7be56edce3e9d64e5da86a5de7c476433818d
BTW we are discussing the MSRV policy here:
https://lists.apache.org/thread/d10ntkzvkbyvh806063jblhhxgvczoth
Currently, datafusion is `1.82`
https://github.com/apache/datafusion/blob/0bd9083a0b8bff6d261449a92dcd4d110976774a/Cargo.toml#L70
Therefore, I think pinning the `munge` version here is the best choice now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
