Xuanwo commented on code in PR #987:
URL: https://github.com/apache/iceberg-rust/pull/987#discussion_r1967084652
##########
.github/workflows/ci.yml:
##########
@@ -152,6 +152,8 @@ jobs:
# Some dependencies don't correctly specify a minimal version for
their dependencies and will fail to build.
# So we update these transitive dependencies here.
cargo update tap faststr metainfo linkedbytes
+ # munge 0.4.2 will cause fail to use 1.7.1 so specify the correct
version here.
+ cargo update -p munge --precise 0.4.1
Review Comment:
Ok, let's fix `tap` / `faststr` / `metainfo` / `linkedbytes` from upstream
instead. Would you like to create an issue to track this and leave it in the
comments? I don't want to maintain too many ` cargo update -p xxx --precise
xxx` in our CI scripts.
That said, I'm open to merging this PR, but I’d like to fix them in a more
maintainable way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
