ZENOTME commented on code in PR #987:
URL: https://github.com/apache/iceberg-rust/pull/987#discussion_r1967070437
##########
.github/workflows/ci.yml:
##########
@@ -152,6 +152,8 @@ jobs:
# Some dependencies don't correctly specify a minimal version for
their dependencies and will fail to build.
# So we update these transitive dependencies here.
cargo update tap faststr metainfo linkedbytes
+ # munge 0.4.2 will cause fail to use 1.7.1 so specify the correct
version here.
+ cargo update -p munge --precise 0.4.1
Review Comment:
> But this still holds, so the current solution in the PR is the best we can
do.
The last MSRV change was 7 months ago, I'm not sure why this holds.🤔 “At
least three months” refers to either three months after the release of a new
Rust version or three months after our last MSRV update?
> Hi, I'm a bit confused why we need this. I remember that we are using
minimal-version to generate Cargo.lock?
But we call `cargo update faststr` later and it will upgrade the munge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
