Fokko merged PR #10778:
URL: https://github.com/apache/iceberg/pull/10778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
Fokko commented on code in PR #962:
URL: https://github.com/apache/iceberg-python/pull/962#discussion_r1690921688
##
pyiceberg/catalog/rest.py:
##
@@ -118,7 +120,8 @@ class Endpoints:
SIGV4 = "rest.sigv4-enabled"
SIGV4_REGION = "rest.signing-region"
SIGV4_SERVICE = "rest.sign
nastra commented on code in PR #10771:
URL: https://github.com/apache/iceberg/pull/10771#discussion_r1690919530
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -512,7 +531,10 @@ private boolean isValidateNamespace(Namespace namespace) {
public
Fokko commented on code in PR #962:
URL: https://github.com/apache/iceberg-python/pull/962#discussion_r1690923706
##
pyiceberg/catalog/rest.py:
##
@@ -290,7 +293,14 @@ def url(self, endpoint: str, prefixed: bool = True,
**kwargs: Any) -> str:
@property
def auth_url(
sdd commented on issue #478:
URL: https://github.com/apache/iceberg-rust/issues/478#issuecomment-2249618894
Thanks for looking at this so quickly @Fokko!
I think we (and the apache_avro crate) should consider some more detailed
error logging for manifest file parse failures as well. I
Xuanwo commented on issue #478:
URL: https://github.com/apache/iceberg-rust/issues/478#issuecomment-2249634931
Agreed. Would you like to raise an issue for this? I do think we need some
logging in iceberg crate.
--
This is an automated message from the Apache Git Service.
To respond to th
sdd commented on issue #477:
URL: https://github.com/apache/iceberg-rust/issues/477#issuecomment-2249649663
I have a local branch where I've modified FileIO to add an OpenDAL `Layer`
that does in-memory caching of the underlying files using the `moka` crate. I
can share the details if you
Fokko commented on PR #963:
URL: https://github.com/apache/iceberg-python/pull/963#issuecomment-2249655208
Hey @sungwy thanks for raising this. Some historical context was added from
the beginning to copy some of the concepts of how it works in Java/Spark, but
to be frank, I don't think it
Vanlightly commented on issue #10720:
URL: https://github.com/apache/iceberg/issues/10720#issuecomment-2249660794
I'm not sure how to test it directly with Spark, given the API does not
allow me to set the validateFromSnapshot, so I created a test to demonstrate
the case, using the lower-le
sdd commented on issue #478:
URL: https://github.com/apache/iceberg-rust/issues/478#issuecomment-2249664181
> Agreed. Would you like to raise an issue for this? I do think we need some
logging in iceberg crate.
I've been thinking this for a long time too. I often sprinkle in
`tracing
Fokko commented on code in PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#discussion_r1690996188
##
site/docs/contribute.md:
##
@@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as
[Github pull requests]
* If a PR is related to an issue, a
Xuanwo commented on issue #477:
URL: https://github.com/apache/iceberg-rust/issues/477#issuecomment-2249693360
That's nice! Please share it to me :heart:
By the way, opendal has native support of moka and mini_moka, maybe also
useful for caching.
--
This is an automated message fr
emkornfield commented on code in PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#discussion_r1691012917
##
site/docs/contribute.md:
##
@@ -207,8 +218,8 @@ public class SnapshotManager implements ManageSnapshots {
// existing code...
@Override
- public Manag
emkornfield commented on code in PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#discussion_r1691014322
##
site/docs/contribute.md:
##
@@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as
[Github pull requests]
* If a PR is related to an is
emkornfield commented on code in PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#discussion_r1691018532
##
site/docs/contribute.md:
##
@@ -207,8 +218,8 @@ public class SnapshotManager implements ManageSnapshots {
// existing code...
@Override
- public Manag
emkornfield opened a new pull request, #10781:
URL: https://github.com/apache/iceberg/pull/10781
* make implementation match definition in interface
* clarify why adding a new interface method breaks compatibility.
--
This is an automated message from the Apache Git Service.
To respond
emkornfield commented on PR #10781:
URL: https://github.com/apache/iceberg/pull/10781#issuecomment-2249719560
@Fokko would you mind taking a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Fokko commented on code in PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#discussion_r1691042870
##
site/docs/contribute.md:
##
@@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as
[Github pull requests]
* If a PR is related to an issue, a
lirui-apache commented on code in PR #10176:
URL: https://github.com/apache/iceberg/pull/10176#discussion_r1691044481
##
core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
emkornfield commented on code in PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#discussion_r1691057611
##
site/docs/contribute.md:
##
@@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as
[Github pull requests]
* If a PR is related to an is
szehon-ho commented on code in PR #10288:
URL: https://github.com/apache/iceberg/pull/10288#discussion_r1691054962
##
api/src/main/java/org/apache/iceberg/actions/ComputeTableStats.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
HonahX opened a new pull request, #964:
URL: https://github.com/apache/iceberg-python/pull/964
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
HonahX commented on PR #963:
URL: https://github.com/apache/iceberg-python/pull/963#issuecomment-2249883371
Thanks for raising the PR! I am also +1 on removing this. This seems
unnecessary and will inevitably lead to the issue as @sungwy mentioned in the
third point:
> identifier_to_
jbonofre commented on code in PR #10752:
URL: https://github.com/apache/iceberg/pull/10752#discussion_r1691138323
##
site/docs/releases.md:
##
@@ -71,6 +71,88 @@ To add a dependency on Iceberg in Maven, add the following
to your `pom.xml`:
...
```
+
+### 1.6.0 release
+Ap
HonahX commented on code in PR #964:
URL: https://github.com/apache/iceberg-python/pull/964#discussion_r1691141095
##
tests/integration/test_writes/test_rest_behavior.py:
##
@@ -0,0 +1,68 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor l
maekchi commented on issue #10765:
URL: https://github.com/apache/iceberg/issues/10765#issuecomment-2249927915
@pvary
I also think this is different than #10526.
I am only appending data.
and perform with `exactly once` mode in Flink.
Because there were other Flink apps, the
shanielh commented on PR #10736:
URL: https://github.com/apache/iceberg/pull/10736#issuecomment-2249962904
Hi, I've applied the changes you suggested within a new fixup commit, please
review and let me know when it's good to squash and rebase.
--
This is an automated message from the Apac
sungwy commented on PR #963:
URL: https://github.com/apache/iceberg-python/pull/963#issuecomment-2249980644
Hi @HonahX and @Fokko thank you for the detailed reviews! Given those
concerns, I think it would make sense to:
1. Introduce the fix @HonahX proposed to address #742 without introdu
desruisseaux commented on issue #10260:
URL: https://github.com/apache/iceberg/issues/10260#issuecomment-2249997624
To summarize:
Next to the _"Coordinate Reference System, ie mapping of how coordinates
refer to precise locations on earth"_ sentences, it may be worth to said that
OGC
Xuanwo commented on PR #355:
URL: https://github.com/apache/iceberg-rust/pull/355#issuecomment-2250010769
Hi, @liurenjie1024, this PR has been open for a while without any progress.
I believe it's ready to be merged and we can continue to make improvements on
it afterward. What do you think
sdd commented on code in PR #373:
URL: https://github.com/apache/iceberg-rust/pull/373#discussion_r1691246764
##
crates/iceberg/src/scan.rs:
##
@@ -197,134 +193,103 @@ impl<'a> TableScanBuilder<'a> {
field_ids.push(field_id);
}
-Ok(TableScan {
+
sungwy commented on code in PR #964:
URL: https://github.com/apache/iceberg-python/pull/964#discussion_r1691348197
##
tests/catalog/test_rest.py:
##
@@ -1226,3 +1226,25 @@ def test_catalog_from_parameters_empty_env(rest_mock:
Mocker) -> None:
catalog = cast(RestCatalog,
findepi merged PR #10767:
URL: https://github.com/apache/iceberg/pull/10767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.a
sungwy commented on PR #964:
URL: https://github.com/apache/iceberg-python/pull/964#issuecomment-2250191429
+1 to this solution for 0.7.0 @HonahX . This is a creative way to mitigate
the issue for the release in the short term. Thank you for taking your time to
put together this solution so
findepi commented on PR #10767:
URL: https://github.com/apache/iceberg/pull/10767#issuecomment-2250192506
@ajantha-bhat thanks for your patience. Looks we're all set.
And this is definitely the best first PR to merge :)
--
This is an automated message from the Apache Git Service.
To r
jbonofre opened a new pull request, #10782:
URL: https://github.com/apache/iceberg/pull/10782
As discussed in another PR @findepi @Fokko @ajantha-bhat 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
nastra commented on PR #10474:
URL: https://github.com/apache/iceberg/pull/10474#issuecomment-2250236029
thanks for working on this @findepi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
nastra merged PR #10474:
URL: https://github.com/apache/iceberg/pull/10474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
jbonofre commented on code in PR #10752:
URL: https://github.com/apache/iceberg/pull/10752#discussion_r1691388502
##
site/docs/releases.md:
##
@@ -71,6 +71,88 @@ To add a dependency on Iceberg in Maven, add the following
to your `pom.xml`:
...
```
+
+### 1.6.0 release
+Ap
jbonofre commented on PR #10752:
URL: https://github.com/apache/iceberg/pull/10752#issuecomment-2250246912
@amogh-jahagirdar as requested by @nastra I added a `Dependencies` section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
sungwy opened a new pull request, #965:
URL: https://github.com/apache/iceberg-python/pull/965
Fixes: https://github.com/apache/iceberg-python/issues/953
This may be a backward incompatible change because it seemingly removes
support for allowing the table name within the parser strin
sungwy commented on issue #953:
URL: https://github.com/apache/iceberg-python/issues/953#issuecomment-2250263129
@cfrancois7 thank you for raising this tricky issue, and @kevinjqliu for
spending the time to step through the issue as well to do the root cause
investigation!
I've put u
bryanck commented on code in PR #10739:
URL: https://github.com/apache/iceberg/pull/10739#discussion_r1691439004
##
kafka-connect/kafka-connect-runtime/docker/docker-compose.yml:
##
@@ -0,0 +1,107 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contri
cfrancois7 commented on issue #953:
URL: https://github.com/apache/iceberg-python/issues/953#issuecomment-2250346701
The first issue regarding the parsing is resolved by the PR.
But the second issue related to the pyarrow command is still there:
`ArrowInvalid: No match for FieldRef.Name(s
fqaiser94 commented on code in PR #475:
URL: https://github.com/apache/iceberg-rust/pull/475#discussion_r1691464398
##
crates/catalog/inmemory/src/catalog.rs:
##
@@ -0,0 +1,1496 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
ndrluis commented on code in PR #962:
URL: https://github.com/apache/iceberg-python/pull/962#discussion_r1691469582
##
pyiceberg/catalog/rest.py:
##
@@ -290,7 +293,14 @@ def url(self, endpoint: str, prefixed: bool = True,
**kwargs: Any) -> str:
@property
def auth_ur
Xuanwo commented on code in PR #475:
URL: https://github.com/apache/iceberg-rust/pull/475#discussion_r1691483403
##
crates/catalog/inmemory/src/catalog.rs:
##
@@ -0,0 +1,1496 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
sungwy commented on issue #953:
URL: https://github.com/apache/iceberg-python/issues/953#issuecomment-2250394041
> The first issue regarding the parsing is resolved by the PR.
>
> But the second issue related to the pyarrow command is still there:
`ArrowInvalid: No match for FieldRef.
fqaiser94 commented on code in PR #481:
URL: https://github.com/apache/iceberg-rust/pull/481#discussion_r1691489187
##
crates/iceberg/src/io/storage_memory.rs:
##
@@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agre
Xuanwo commented on code in PR #481:
URL: https://github.com/apache/iceberg-rust/pull/481#discussion_r1691497746
##
crates/iceberg/src/io/storage.rs:
##
@@ -79,6 +87,16 @@ impl Storage {
) -> crate::Result<(Operator, &'a str)> {
let path = path.as_ref();
m
amogh-jahagirdar commented on PR #10752:
URL: https://github.com/apache/iceberg/pull/10752#issuecomment-2250397068
Thanks @jbonofre !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
amogh-jahagirdar merged PR #10752:
URL: https://github.com/apache/iceberg/pull/10752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
fqaiser94 commented on code in PR #475:
URL: https://github.com/apache/iceberg-rust/pull/475#discussion_r1691464398
##
crates/catalog/inmemory/src/catalog.rs:
##
@@ -0,0 +1,1496 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
jasonf20 commented on PR #9323:
URL: https://github.com/apache/iceberg/pull/9323#issuecomment-2250437040
I rebased this PR again so it's mergable. Would appreciate reviving this PR.
@rdblue Could you please have a look or let me know if there is someone else
who could help?
--
This is a
jbonofre commented on PR #10752:
URL: https://github.com/apache/iceberg/pull/10752#issuecomment-2250457287
@amogh-jahagirdar thanks ! I will do the announcement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
fqaiser94 commented on code in PR #475:
URL: https://github.com/apache/iceberg-rust/pull/475#discussion_r1691550143
##
crates/catalog/inmemory/src/catalog.rs:
##
@@ -0,0 +1,1496 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
fqaiser94 commented on code in PR #475:
URL: https://github.com/apache/iceberg-rust/pull/475#discussion_r1691550143
##
crates/catalog/inmemory/src/catalog.rs:
##
@@ -0,0 +1,1496 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
fqaiser94 commented on code in PR #475:
URL: https://github.com/apache/iceberg-rust/pull/475#discussion_r1691550143
##
crates/catalog/inmemory/src/catalog.rs:
##
@@ -0,0 +1,1496 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
fqaiser94 commented on code in PR #481:
URL: https://github.com/apache/iceberg-rust/pull/481#discussion_r1691486557
##
crates/iceberg/src/io/storage.rs:
##
@@ -79,6 +87,16 @@ impl Storage {
) -> crate::Result<(Operator, &'a str)> {
let path = path.as_ref();
fqaiser94 commented on code in PR #475:
URL: https://github.com/apache/iceberg-rust/pull/475#discussion_r1691550143
##
crates/catalog/inmemory/src/catalog.rs:
##
@@ -0,0 +1,1496 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
fqaiser94 commented on code in PR #475:
URL: https://github.com/apache/iceberg-rust/pull/475#discussion_r1691550143
##
crates/catalog/inmemory/src/catalog.rs:
##
@@ -0,0 +1,1496 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
amogh-jahagirdar commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1691584095
##
open-api/rest-catalog-open-api.yaml:
##
@@ -3647,6 +3818,176 @@ components:
type: integer
description: "List of equality field IDs"
ndrluis commented on PR #962:
URL: https://github.com/apache/iceberg-python/pull/962#issuecomment-2250532227
The deprecated decorator adds a message that does not make sense for the
properties deprecation. I will add a new function and change where is a
property deprecation and are using th
jbonofre opened a new pull request, #10783:
URL: https://github.com/apache/iceberg/pull/10783
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
jbonofre commented on PR #10783:
URL: https://github.com/apache/iceberg/pull/10783#issuecomment-2250548095
@amogh-jahagirdar can you please take a look ? Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
amogh-jahagirdar commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1691584095
##
open-api/rest-catalog-open-api.yaml:
##
@@ -3647,6 +3818,176 @@ components:
type: integer
description: "List of equality field IDs"
enkidulan commented on PR #810:
URL: https://github.com/apache/iceberg-python/pull/810#issuecomment-2250554372
@sungwy #569 was merged last week, so I've updated this PR. Can you glance
over it and say if adding `add_files_overwrite` makes sense to you?
--
This is an automated message fro
amogh-jahagirdar merged PR #10783:
URL: https://github.com/apache/iceberg/pull/10783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
ndrluis commented on PR #962:
URL: https://github.com/apache/iceberg-python/pull/962#issuecomment-2250572751
@Fokko Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
RussellSpitzer commented on code in PR #10737:
URL: https://github.com/apache/iceberg/pull/10737#discussion_r1691611196
##
api/src/main/java/org/apache/iceberg/AddPartitionSpec.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
danielcweeks commented on code in PR #10739:
URL: https://github.com/apache/iceberg/pull/10739#discussion_r1691637442
##
kafka-connect/kafka-connect-runtime/docker/docker-compose.yml:
##
@@ -0,0 +1,107 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more c
Xuanwo commented on code in PR #475:
URL: https://github.com/apache/iceberg-rust/pull/475#discussion_r1691637775
##
crates/catalog/inmemory/src/catalog.rs:
##
@@ -0,0 +1,1496 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
Xuanwo commented on code in PR #475:
URL: https://github.com/apache/iceberg-rust/pull/475#discussion_r1691637775
##
crates/catalog/inmemory/src/catalog.rs:
##
@@ -0,0 +1,1496 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
Xuanwo commented on code in PR #475:
URL: https://github.com/apache/iceberg-rust/pull/475#discussion_r1691637775
##
crates/catalog/inmemory/src/catalog.rs:
##
@@ -0,0 +1,1496 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
nastra commented on PR #9008:
URL: https://github.com/apache/iceberg/pull/9008#issuecomment-2250721645
@amogh-jahagirdar would you like to take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
nastra commented on code in PR #10771:
URL: https://github.com/apache/iceberg/pull/10771#discussion_r1691695766
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -512,7 +531,10 @@ private boolean isValidateNamespace(Namespace namespace) {
public
nastra commented on code in PR #10748:
URL: https://github.com/apache/iceberg/pull/10748#discussion_r1691704734
##
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/reader/LimitableDataIterator.java:
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Found
ajantha-bhat commented on code in PR #10739:
URL: https://github.com/apache/iceberg/pull/10739#discussion_r1691726716
##
kafka-connect/kafka-connect-runtime/docker/docker-compose.yml:
##
@@ -0,0 +1,107 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more c
bryanck commented on code in PR #10739:
URL: https://github.com/apache/iceberg/pull/10739#discussion_r1691728921
##
kafka-connect/kafka-connect-runtime/docker/docker-compose.yml:
##
@@ -0,0 +1,107 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contri
nastra commented on issue #7396:
URL: https://github.com/apache/iceberg/issues/7396#issuecomment-2250791863
@umathivagit you might want to look at the Spark
[config](https://github.com/tabular-io/docker-spark-iceberg/blob/main/spark/spark-defaults.conf#L23-L29
) that the [Spark quickstart
nastra commented on code in PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#discussion_r1691733551
##
site/docs/contribute.md:
##
@@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as
[Github pull requests]
* If a PR is related to an issue,
jbonofre commented on code in PR #10739:
URL: https://github.com/apache/iceberg/pull/10739#discussion_r1691734005
##
kafka-connect/kafka-connect-runtime/docker/docker-compose.yml:
##
@@ -0,0 +1,107 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contr
ajantha-bhat commented on code in PR #10739:
URL: https://github.com/apache/iceberg/pull/10739#discussion_r1691739280
##
kafka-connect/kafka-connect-runtime/docker/docker-compose.yml:
##
@@ -0,0 +1,107 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more c
danielcweeks commented on code in PR #10739:
URL: https://github.com/apache/iceberg/pull/10739#discussion_r1691741295
##
kafka-connect/kafka-connect-runtime/docker/docker-compose.yml:
##
@@ -0,0 +1,107 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more c
jbonofre commented on code in PR #10739:
URL: https://github.com/apache/iceberg/pull/10739#discussion_r1691755922
##
kafka-connect/kafka-connect-runtime/docker/docker-compose.yml:
##
@@ -0,0 +1,107 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contr
jackye1995 commented on PR #947:
URL: https://github.com/apache/iceberg-python/pull/947#issuecomment-2250898833
@HonahX @kevinjqliu any further comments? Could this be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
amogh-jahagirdar commented on code in PR #10771:
URL: https://github.com/apache/iceberg/pull/10771#discussion_r1691797531
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -512,7 +531,10 @@ private boolean isValidateNamespace(Namespace namespace) {
amogh-jahagirdar commented on code in PR #10771:
URL: https://github.com/apache/iceberg/pull/10771#discussion_r1691797531
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -512,7 +531,10 @@ private boolean isValidateNamespace(Namespace namespace) {
amogh-jahagirdar commented on code in PR #10771:
URL: https://github.com/apache/iceberg/pull/10771#discussion_r1691803561
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -512,7 +531,10 @@ private boolean isValidateNamespace(Namespace namespace) {
sungwy commented on issue #953:
URL: https://github.com/apache/iceberg-python/issues/953#issuecomment-2250984811
Hi @cfrancois7 I investigated this a little more, and I think there could be
a limitation on pyarrow in supporting predicate pushdown for nested fields.
Here's a related open iss
fqaiser94 commented on code in PR #475:
URL: https://github.com/apache/iceberg-rust/pull/475#discussion_r1691830743
##
crates/catalog/inmemory/src/catalog.rs:
##
@@ -0,0 +1,1496 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
fqaiser94 commented on code in PR #475:
URL: https://github.com/apache/iceberg-rust/pull/475#discussion_r1691830743
##
crates/catalog/inmemory/src/catalog.rs:
##
@@ -0,0 +1,1496 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
fqaiser94 commented on code in PR #475:
URL: https://github.com/apache/iceberg-rust/pull/475#discussion_r1691830743
##
crates/catalog/inmemory/src/catalog.rs:
##
@@ -0,0 +1,1496 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
Xuanwo commented on code in PR #475:
URL: https://github.com/apache/iceberg-rust/pull/475#discussion_r1691852790
##
crates/catalog/inmemory/src/catalog.rs:
##
@@ -0,0 +1,1496 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
Xuanwo commented on code in PR #475:
URL: https://github.com/apache/iceberg-rust/pull/475#discussion_r1691852790
##
crates/catalog/inmemory/src/catalog.rs:
##
@@ -0,0 +1,1496 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
Xuanwo commented on code in PR #475:
URL: https://github.com/apache/iceberg-rust/pull/475#discussion_r1691852790
##
crates/catalog/inmemory/src/catalog.rs:
##
@@ -0,0 +1,1496 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
kevinjqliu commented on issue #953:
URL: https://github.com/apache/iceberg-python/issues/953#issuecomment-2251045032
Here's something interesting.
I think the `pyarrow_filter`
[here](https://github.com/apache/iceberg-python/blob/9b6503def4f07a70149da07378f4795c3a4b113b/pyiceberg/io/py
amogh-jahagirdar commented on PR #10771:
URL: https://github.com/apache/iceberg/pull/10771#issuecomment-2251075082
Thanks @hussein-awala , and thank you @nastra for reviewing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
amogh-jahagirdar merged PR #10771:
URL: https://github.com/apache/iceberg/pull/10771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
amogh-jahagirdar opened a new pull request, #10784:
URL: https://github.com/apache/iceberg/pull/10784
Co-authored-by: Mathew Fournier
<160646114+tabmatfourn...@users.noreply.github.com>
Refer to #10445 for more details.
This change defines a RepairManifest Action interface wher
1 - 100 of 215 matches
Mail list logo
