HonahX commented on PR #963: URL: https://github.com/apache/iceberg-python/pull/963#issuecomment-2249883371
Thanks for raising the PR! I am also +1 on removing this. This seems unnecessary and will inevitably lead to the issue as @sungwy mentioned in the third point: > identifier_to_tuple_without_catalog is called in all catalog implementations, and is currently crucial in allowing Table to use the long identifier including the catalog_name. However, this function is imperfect, and will result in errors if the the table_namespace uses a hierarchical... if we want to support identifiers with/without catalog's name. However, removing this means we will break the compatibility. > We could put it behind a flag and make it the default behavior on the next version? But it is already rather messy. A flag might help, but it may still be disruptive if users are unaware of the flag and the decision to remove the feature. How about sending an email to the dev-list for further discussion and feedback on this change? This could also help us understand the potential impact of this removal on users. That said, I am inclined to postpone the actual removal to version 0.8.0. There are many updates and excellent new features in version 0.7.0, and I do not want this change to discourage people from upgrading. I understand that it would be beneficial for version 0.7.0 to address https://github.com/apache/iceberg-python/pull/964, so I have also attempted #964 without removing the catalog name from the identifier. I hope this can further mitigate the issue and unblock version 0.7.0. Would love to hear your thoughts on this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
