sungwy commented on code in PR #964:
URL: https://github.com/apache/iceberg-python/pull/964#discussion_r1691348197
##########
tests/catalog/test_rest.py:
##########
@@ -1226,3 +1226,25 @@ def test_catalog_from_parameters_empty_env(rest_mock:
Mocker) -> None:
catalog = cast(RestCatalog, load_catalog("production",
uri="https://other-service.io/api";))
assert catalog.uri == "https://other-service.io/api";
+
+
+def test_commit_table_fail(rest_mock: Mocker, example_table_metadata_v2:
Dict[str, Any]) -> None:
Review Comment:
nit: I find the name of this test confusing as it sounds like we are
expecting the table commit to fail, but it succeeds with a 200 status code
within the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
