Fokko merged PR #101:
URL: https://github.com/apache/iceberg-rust/pull/101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
Fokko merged PR #102:
URL: https://github.com/apache/iceberg-rust/pull/102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
nastra commented on PR #9108:
URL: https://github.com/apache/iceberg/pull/9108#issuecomment-1818542037
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dependabot[bot] opened a new pull request, #9114:
URL: https://github.com/apache/iceberg/pull/9114
Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from
9.4.8 to 9.4.10.
Release notes
Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mkdocs-m
dependabot[bot] commented on PR #9108:
URL: https://github.com/apache/iceberg/pull/9108#issuecomment-1818551723
Superseded by #9114.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
dependabot[bot] closed pull request #9108: Build: Bump mkdocs-material from
9.4.8 to 9.4.9
URL: https://github.com/apache/iceberg/pull/9108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
Fokko commented on code in PR #139:
URL: https://github.com/apache/iceberg-python/pull/139#discussion_r1398847839
##
pyiceberg/table/__init__.py:
##
@@ -350,6 +357,241 @@ class RemovePropertiesUpdate(TableUpdate):
removals: List[str]
+class TableMetadataUpdateContext:
Fokko commented on code in PR #139:
URL: https://github.com/apache/iceberg-python/pull/139#discussion_r1398855771
##
pyiceberg/table/__init__.py:
##
@@ -350,6 +357,241 @@ class RemovePropertiesUpdate(TableUpdate):
removals: List[str]
+class TableMetadataUpdateContext:
+
jbonofre commented on PR #9017:
URL: https://github.com/apache/iceberg/pull/9017#issuecomment-1818750776
Thanks for the report. Let me take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
Fokko merged PR #151:
URL: https://github.com/apache/iceberg-python/pull/151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko commented on code in PR #97:
URL: https://github.com/apache/iceberg-rust/pull/97#discussion_r1398974623
##
crates/catalog/rest/src/catalog.rs:
##
@@ -586,16 +648,46 @@ mod _serde {
pub(super) metadata: TableMetadata,
pub(super) config: Option>,
}
+
+
Fokko commented on PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#issuecomment-1818816616
Looks like we have a sad clippy:
```
```
error: argument to `panic!()` in a const context must have type `&str`
--> crates/catalog/rest/src/catalog.rs:985:13
|
985 |
liurenjie1024 commented on PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#issuecomment-1818822751
The failure is caused by upgrades of `uuid`. You can solve it by fixing
version as [this commit]()
--
This is an automated message from the Apache Git Service.
To respond to the
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1399024202
##
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/reader/ColumnStatsWatermarkExtractor.java:
##
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1399025309
##
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/reader/ColumnStatsWatermarkExtractor.java:
##
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software
Xuanwo commented on code in PR #97:
URL: https://github.com/apache/iceberg-rust/pull/97#discussion_r1399106512
##
crates/catalog/rest/src/catalog.rs:
##
@@ -446,6 +490,24 @@ impl RestCatalog {
Ok(())
}
+
+fn load_file_io(
+&self,
+metadata_loc
ajantha-bhat commented on code in PR #8909:
URL: https://github.com/apache/iceberg/pull/8909#discussion_r1399218687
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -540,4 +630,72 @@ public void close() {
api.close();
}
}
+
+ publ
my-vegetable-has-exploded commented on issue #98:
URL: https://github.com/apache/iceberg-rust/issues/98#issuecomment-1819116596
Sorry for my misunderstanding and thanks for your patience @liurenjie1024.
Without ```option```, UnboundPartitionSpec and UnboundPartitionField may like
this?
dimas-b commented on PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#issuecomment-1819117195
I'm fine with using `ClientSide*` builders for Namespace manipulation.
However, are we not getting the benefit of refactoring catalog code to be
more concise and straight-forward by
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1399328620
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java:
##
@@ -0,0 +1,375 @@
+/*
+ * Licensed to the Apache Softw
huanghanyu-vungle commented on issue #9018:
URL: https://github.com/apache/iceberg/issues/9018#issuecomment-1819237615
` def saveReport(data: DataFrame, targetTable: String, isPublisherReport:
Boolean): Unit = {
val tmpTableName = "__tmp"
data.createOrReplaceTempView(tmpTa
lisirrx commented on issue #9081:
URL: https://github.com/apache/iceberg/issues/9081#issuecomment-1819356677
@nastra Hi, I have read the discussion in #7160 and read some packages which
are already changed to JUnit5. I want to have a try.
--
This is an automated message from the Apache Gi
syun64 commented on PR #8976:
URL: https://github.com/apache/iceberg/pull/8976#issuecomment-1819503960
Incorporated suggested changes @nastra . Thank you for the reviews!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Fokko opened a new pull request, #294:
URL: https://github.com/apache/iceberg-docs/pull/294
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
Fokko merged PR #294:
URL: https://github.com/apache/iceberg-docs/pull/294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
nastra commented on issue #9081:
URL: https://github.com/apache/iceberg/issues/9081#issuecomment-1819705926
@lisirrx great, feel free to go ahead and open a PR once you have something
and tag me for a review
--
This is an automated message from the Apache Git Service.
To respond to the me
ndrluis commented on PR #9090:
URL: https://github.com/apache/iceberg/pull/9090#issuecomment-1819759619
@nastra @ndrluis Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
ndrluis commented on PR #9090:
URL: https://github.com/apache/iceberg/pull/9090#issuecomment-1819760036
@nastra @Fokko Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
nastra merged PR #9114:
URL: https://github.com/apache/iceberg/pull/9114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
jackskmok opened a new issue, #9116:
URL: https://github.com/apache/iceberg/issues/9116
I am trying to testing the create branch feature with the table with AWS
Glue catalog , but hit the error as title. Here is the message:
>>> spark.sql("alter table iceberg.athena_data create branch
aokolnychyi commented on code in PR #8755:
URL: https://github.com/apache/iceberg/pull/8755#discussion_r1399800368
##
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##
@@ -452,6 +454,59 @@ private static void checkSchemaCompatibility(
}
}
+ public static lo
aokolnychyi commented on code in PR #8755:
URL: https://github.com/apache/iceberg/pull/8755#discussion_r1399804623
##
core/src/main/java/org/apache/iceberg/deletes/PositionDeleteIndex.java:
##
@@ -44,4 +44,14 @@ public interface PositionDeleteIndex {
/** Returns true if thi
aokolnychyi commented on code in PR #8755:
URL: https://github.com/apache/iceberg/pull/8755#discussion_r1399806008
##
data/src/main/java/org/apache/iceberg/data/BaseDeleteLoader.java:
##
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
aokolnychyi commented on code in PR #8755:
URL: https://github.com/apache/iceberg/pull/8755#discussion_r1350603878
##
data/src/main/java/org/apache/iceberg/data/DeleteLoader.java:
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
amogh-jahagirdar commented on PR #9115:
URL: https://github.com/apache/iceberg/pull/9115#issuecomment-1819881061
Thanks for reviews @danielcweeks @singhpk234 ! merging since this was a
straightforward backport
--
This is an automated message from the Apache Git Service.
To respond to the
amogh-jahagirdar merged PR #9115:
URL: https://github.com/apache/iceberg/pull/9115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
dependabot[bot] opened a new pull request, #155:
URL: https://github.com/apache/iceberg-python/pull/155
Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from
9.4.8 to 9.4.10.
Release notes
Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mkd
aokolnychyi commented on PR #9101:
URL: https://github.com/apache/iceberg/pull/9101#issuecomment-1819950516
Thanks, @zhongyujiang! Thanks for reviewing, @singhpk234!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
aokolnychyi merged PR #9101:
URL: https://github.com/apache/iceberg/pull/9101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
aokolnychyi commented on code in PR #9117:
URL: https://github.com/apache/iceberg/pull/9117#discussion_r1399860140
##
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##
@@ -245,18 +242,9 @@ private CloseableIterable
applyPosDeletes(CloseableIterable records) {
aokolnychyi commented on code in PR #9117:
URL: https://github.com/apache/iceberg/pull/9117#discussion_r1399860140
##
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##
@@ -245,18 +242,9 @@ private CloseableIterable
applyPosDeletes(CloseableIterable records) {
aokolnychyi commented on PR #9117:
URL: https://github.com/apache/iceberg/pull/9117#issuecomment-1819963551
cc @amogh-jahagirdar @nastra @RussellSpitzer @flyrain @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
aokolnychyi commented on PR #9046:
URL: https://github.com/apache/iceberg/pull/9046#issuecomment-1819964784
cc @pvary @stevenzwu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
github-actions[bot] commented on issue #7640:
URL: https://github.com/apache/iceberg/issues/7640#issuecomment-1820009144
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] closed issue #7463: Spark: inconsistency in rewrite data
and summary
URL: https://github.com/apache/iceberg/issues/7463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
github-actions[bot] commented on issue #7463:
URL: https://github.com/apache/iceberg/issues/7463#issuecomment-1820009219
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
manuzhang commented on PR #8922:
URL: https://github.com/apache/iceberg/pull/8922#issuecomment-1820108319
We have similar requests to set platform level split size to reduce read
RPCs to HDFS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
liurenjie1024 commented on code in PR #97:
URL: https://github.com/apache/iceberg-rust/pull/97#discussion_r1399952745
##
crates/catalog/rest/src/catalog.rs:
##
@@ -1092,4 +1184,375 @@ mod tests {
config_mock.assert_async().await;
rename_table_mock.assert_async(
liurenjie1024 commented on code in PR #97:
URL: https://github.com/apache/iceberg-rust/pull/97#discussion_r1399952861
##
crates/catalog/rest/src/catalog.rs:
##
@@ -1017,31 +1109,31 @@ mod tests {
.with_summary(Summary {
operation: Operation::Append,
liurenjie1024 commented on PR #97:
URL: https://github.com/apache/iceberg-rust/pull/97#issuecomment-1820111558
> As I mentioned earlier, having the REST Docker images would make testing a
lot easier.
I've tracked this in #100, and will do it after this get merged. This pr is
already
irshadcc opened a new issue, #9118:
URL: https://github.com/apache/iceberg/issues/9118
### Feature Request / Improvement
During the snapshot commit process of MergingSnapshotProducer, Iceberg tries
to merge the manifest files to increase the planning performance. During
operations li
aokolnychyi opened a new pull request, #9119:
URL: https://github.com/apache/iceberg/pull/9119
This PR removes synchronization from `BitmapPositionDeleteIndex` added in PR
#8805.
We switched to `ParallelIterable` to parallelize reading of deletes in the
original change. However, mark
aokolnychyi commented on PR #9119:
URL: https://github.com/apache/iceberg/pull/9119#issuecomment-1820181900
@nastra @wypoon, could you check whether my analysis was correct? Let me
know if I missed something.
cc @amogh-jahagirdar @singhpk234 @Fokko as well
--
This is an automated m
aokolnychyi commented on PR #9029:
URL: https://github.com/apache/iceberg/pull/9029#issuecomment-1820198393
Does the data analyst connect to a remote already running cluster? Do we
assume the jar is populated on executors but not supplied by the analyst in the
local shell?
--
This is an
aokolnychyi closed pull request #9119: Core: Remove synchronization from
BitmapPositionDeleteIndex
URL: https://github.com/apache/iceberg/pull/9119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
liurenjie1024 commented on issue #98:
URL: https://github.com/apache/iceberg-rust/issues/98#issuecomment-1820300963
Hi, @my-vegetable-has-exploded I mean I don't want to add `Option` in
current `PartitionSpec`, but it's ok to add it in `UnboundPartitonSpec`.
--
This is an automated messag
my-vegetable-has-exploded commented on issue #98:
URL: https://github.com/apache/iceberg-rust/issues/98#issuecomment-1820337516
> Hi, @my-vegetable-has-exploded I mean I don't want to add `Option` in
current `PartitionSpec`, but it's ok to add it in `UnboundPartitonSpec`.
get it!, tha
ajantha-bhat commented on code in PR #8909:
URL: https://github.com/apache/iceberg/pull/8909#discussion_r1400100247
##
nessie/src/test/java/org/apache/iceberg/nessie/TestNessieViewCatalog.java:
##
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
ajantha-bhat commented on code in PR #8909:
URL: https://github.com/apache/iceberg/pull/8909#discussion_r1400104301
##
nessie/src/test/java/org/apache/iceberg/nessie/BaseTestIceberg.java:
##
@@ -267,4 +306,23 @@ static DataFile makeDataFile(Table icebergTable, String
fileLocati
ajantha-bhat commented on code in PR #8909:
URL: https://github.com/apache/iceberg/pull/8909#discussion_r1400108586
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieViewOperations.java:
##
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
ajantha-bhat commented on code in PR #8909:
URL: https://github.com/apache/iceberg/pull/8909#discussion_r1400110138
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java:
##
@@ -104,12 +96,18 @@ protected void doRefresh() {
content
mobley-trent commented on code in PR #103:
URL: https://github.com/apache/iceberg-rust/pull/103#discussion_r1400115507
##
crates/iceberg/src/spec/values.rs:
##
@@ -554,13 +554,14 @@ impl From<&Literal> for JsonValue {
PrimitiveLiteral::Decimal(_) => todo!(),
amogh-jahagirdar commented on code in PR #9117:
URL: https://github.com/apache/iceberg/pull/9117#discussion_r1400123389
##
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##
@@ -245,18 +242,9 @@ private CloseableIterable
applyPosDeletes(CloseableIterable records)
nastra merged PR #9119:
URL: https://github.com/apache/iceberg/pull/9119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
nastra commented on PR #9119:
URL: https://github.com/apache/iceberg/pull/9119#issuecomment-1820369632
thanks @aokolnychyi for fixing this and @amogh-jahagirdar for reviewing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
nastra commented on issue #9116:
URL: https://github.com/apache/iceberg/issues/9116#issuecomment-1820372169
@jackskmok it appears that you're missing `--conf
spark.sql.extensions=org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions`
--
This is an automated message from the Ap
Fokko opened a new issue, #7463:
URL: https://github.com/apache/iceberg/issues/7463
### Apache Iceberg version
1.2.1 (latest release)
### Query engine
Spark
### Please describe the bug 🐞
Make sure to set the number of partitions to one, to avoid having files
nastra commented on code in PR #8909:
URL: https://github.com/apache/iceberg/pull/8909#discussion_r1400147481
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java:
##
@@ -104,12 +96,18 @@ protected void doRefresh() {
content
68 matches
Mail list logo
