aokolnychyi commented on code in PR #8755:
URL: https://github.com/apache/iceberg/pull/8755#discussion_r1399800368
##########
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##########
@@ -452,6 +454,59 @@ private static void checkSchemaCompatibility(
}
}
+ public static long defaultSize(Types.NestedField field) {
Review Comment:
I think we have 2 options to limit the size of the cache:
- Add ways to limit the size of equality and position delete files to be
loaded.
- Add ways to indicate the maximum cache size in bytes.
The first one is easy but we need to account that delete files may store
extra columns and it will be hard to configure these options correctly cause
users have no idea how much the cached representation will actually occupy.
That's why I went with the estimation approach and let users configure the max
cache size in bytes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
