amogh-jahagirdar commented on code in PR #9117:
URL: https://github.com/apache/iceberg/pull/9117#discussion_r1400123389
##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -245,18 +242,9 @@ private CloseableIterable<T>
applyPosDeletes(CloseableIterable<T> records) {
List<CloseableIterable<Record>> deletes = Lists.transform(posDeletes,
this::openPosDeletes);
- // if there are fewer deletes than a reasonable number to keep in memory,
use a set
Review Comment:
Sweet, this makes sense and appreciate the simplification. I remember
seeing this threshold in the code and was wondering how we got to the 100000
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
