mobley-trent commented on code in PR #103:
URL: https://github.com/apache/iceberg-rust/pull/103#discussion_r1400115507
##########
crates/iceberg/src/spec/values.rs:
##########
@@ -554,13 +554,14 @@ impl From<&Literal> for JsonValue {
PrimitiveLiteral::Decimal(_) => todo!(),
},
Literal::Struct(s) => {
Review Comment:
Hey @liurenjie1024 how should we design this method ? Since the iterator
only return the value instead of the `(id, value, name)` tuple. I'm having
trouble setting up the test for this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
