Re: [PR] Spec: add variant type [iceberg]

ronkorving commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1964622918 ## format/spec.md: ## @@ -182,6 +182,20 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of key-

Re: [PR] Spec: add variant type [iceberg]

sfc-gh-aixu commented on PR #10831: URL: https://github.com/apache/iceberg/pull/10831#issuecomment-2623219808 > Merged, thanks everyone for your thoughtful feedback. Thanks @aihuaxu for the pr. Thanks to @rdblue , @emkornfield , @findepi , @XBaith , and @flyrain for your contributions revie

Re: [PR] Spec: add variant type [iceberg]

RussellSpitzer commented on PR #10831: URL: https://github.com/apache/iceberg/pull/10831#issuecomment-2623055587 Merged, thanks everyone for your thoughtful feedback. Thanks @aihuaxu for the pr. Thanks to @rdblue , @emkornfield , @findepi , @XBaith , and @flyrain for your contributions revi

Re: [PR] Spec: add variant type [iceberg]

RussellSpitzer merged PR #10831: URL: https://github.com/apache/iceberg/pull/10831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1934733942 ## format/spec.md: ## @@ -1208,6 +1223,7 @@ Lists must use the [3-level representation](https://github.com/apache/parquet-fo | **`struct`** | `group`

Re: [PR] Spec: add variant type [iceberg]

emkornfield commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1934723602 ## format/spec.md: ## @@ -1208,6 +1223,7 @@ Lists must use the [3-level representation](https://github.com/apache/parquet-fo | **`struct`** | `group`

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1917457914 ## format/spec.md: ## @@ -182,6 +182,21 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of key-val

Re: [PR] Spec: add variant type [iceberg]

RussellSpitzer commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1915973279 ## format/spec.md: ## @@ -182,6 +182,21 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1915818592 ## format/spec.md: ## @@ -182,6 +182,21 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of key-val

Re: [PR] Spec: add variant type [iceberg]

RussellSpitzer commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1915466398 ## format/spec.md: ## @@ -182,6 +182,21 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1906185106 ## version.txt: ## Review Comment: Thanks for catching that. It was added by accident. :) -- This is an automated message from the Apache Git Service. To res

Re: [PR] Spec: add variant type [iceberg]

emkornfield commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1905854896 ## version.txt: ## Review Comment: this can be removed? -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on PR #10831: URL: https://github.com/apache/iceberg/pull/10831#issuecomment-2575904277 I believe I have addressed the comments and can we move forward to merge the PR? Let me know if I miss anything. cc @RussellSpitzer and @rdblue -- This is an automated message from

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1894436657 ## format/spec.md: ## @@ -182,6 +182,21 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of key-val

Re: [PR] Spec: add variant type [iceberg]

emkornfield commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1894350830 ## format/spec.md: ## @@ -182,6 +182,21 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of key

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1887255745 ## format/spec.md: ## @@ -182,6 +182,21 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of key-val

Re: [PR] Spec: add variant type [iceberg]

emkornfield commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1886156061 ## format/spec.md: ## @@ -182,6 +182,21 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of key

Re: [PR] Spec: add variant type [iceberg]

emkornfield commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1886155000 ## format/spec.md: ## @@ -178,6 +178,21 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of key

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1885094847 ## format/spec.md: ## @@ -182,6 +182,21 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of key-val

Re: [PR] Spec: add variant type [iceberg]

emkornfield commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1882513910 ## format/spec.md: ## @@ -182,6 +182,21 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of key

Re: [PR] Spec: add variant type [iceberg]

XBaith commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1879742066 ## format/spec.md: ## @@ -1208,6 +1224,7 @@ Lists must use the [3-level representation](https://github.com/apache/parquet-fo | **`struct`** | `group`

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1874623947 ## format/spec.md: ## @@ -178,6 +178,21 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of key-val

Re: [PR] Spec: add variant type [iceberg]

findepi commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1871412309 ## format/spec.md: ## @@ -182,6 +182,21 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of key-val

Re: [PR] Spec: add variant type [iceberg]

emkornfield commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1858978402 ## format/spec.md: ## @@ -182,6 +182,21 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of key

Re: [PR] Spec: add variant type [iceberg]

emkornfield commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1858976684 ## format/spec.md: ## @@ -178,6 +178,21 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of key

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1855366984 ## format/spec.md: ## @@ -1154,6 +1169,7 @@ Maps with non-string keys must use an array representation with the `map` logica |**`struct`**|`record`|| |**`list`**|`

Re: [PR] Spec: add variant type [iceberg]

emkornfield commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1854866077 ## format/spec.md: ## @@ -1154,6 +1169,7 @@ Maps with non-string keys must use an array representation with the `map` logica |**`struct`**|`record`|| |**`list`

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1854522786 ## format/spec.md: ## @@ -1436,6 +1457,7 @@ This serialization scheme is for storing single values as individual binary valu | **`struct`** | Not su

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1854383036 ## format/spec.md: ## @@ -444,7 +459,7 @@ Partition field IDs must be reused if an existing partition spec contains an equ | Transform name| Description

Re: [PR] Spec: add variant type [iceberg]

rdblue commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1852748196 ## format/spec.md: ## @@ -1110,6 +1125,7 @@ Maps with non-string keys must use an array representation with the `map` logica |**`struct`**|`record`|| |**`list`**|`a

Re: [PR] Spec: add variant type [iceberg]

rdblue commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1852746749 ## format/spec.md: ## @@ -444,7 +459,7 @@ Partition field IDs must be reused if an existing partition spec contains an equ | Transform name| Description

Re: [PR] Spec: add variant type [iceberg]

rdblue commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1852745191 ## format/spec.md: ## @@ -178,6 +178,21 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of key-valu

Re: [PR] Spec: add variant type [iceberg]

rdblue commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1852745826 ## format/spec.md: ## @@ -444,7 +459,7 @@ Partition field IDs must be reused if an existing partition spec contains an equ | Transform name| Description

Re: [PR] Spec: add variant type [iceberg]

RussellSpitzer commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1829948464 ## format/spec.md: ## @@ -1287,6 +1307,7 @@ Types are serialized according to this table: |**`struct`**|`JSON object: {`  `"type": "struct",`  `"fields": [ {`

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1829792386 ## format/spec.md: ## @@ -1462,6 +1484,7 @@ This serialization scheme is for storing single values as individual binary valu | **`struct`** | **`JSON object b

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1829674025 ## format/spec.md: ## @@ -1110,6 +1125,7 @@ Maps with non-string keys must use an array representation with the `map` logica |**`struct`**|`record`|| |**`list`**|`

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1829687763 ## format/spec.md: ## @@ -1287,6 +1307,7 @@ Types are serialized according to this table: |**`struct`**|`JSON object: {`  `"type": "struct",`  `"fields": [ {``"i

Re: [PR] Spec: add variant type [iceberg]

RussellSpitzer commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1826190048 ## format/spec.md: ## @@ -444,6 +449,9 @@ Sorting floating-point numbers should produce the following behavior: `-NaN` < ` A data or delete file is associa

Re: [PR] Spec: add variant type [iceberg]

RussellSpitzer commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1826184241 ## format/spec.md: ## @@ -1462,6 +1484,7 @@ This serialization scheme is for storing single values as individual binary valu | **`struct`** | **`JSON o

Re: [PR] Spec: add variant type [iceberg]

RussellSpitzer commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1826183315 ## format/spec.md: ## @@ -1436,6 +1457,7 @@ This serialization scheme is for storing single values as individual binary valu | **`struct`** |

Re: [PR] Spec: add variant type [iceberg]

RussellSpitzer commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1826183315 ## format/spec.md: ## @@ -1436,6 +1457,7 @@ This serialization scheme is for storing single values as individual binary valu | **`struct`** |

Re: [PR] Spec: add variant type [iceberg]

RussellSpitzer commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1826181717 ## format/spec.md: ## @@ -1287,6 +1307,7 @@ Types are serialized according to this table: |**`struct`**|`JSON object: {`  `"type": "struct",`  `"fields": [ {`

Re: [PR] Spec: add variant type [iceberg]

RussellSpitzer commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1826179192 ## format/spec.md: ## @@ -1297,54 +1308,56 @@ Example This serialization scheme is for storing single values as individual binary values in the lower and u

Re: [PR] Spec: add variant type [iceberg]

RussellSpitzer commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1826053379 ## format/spec.md: ## @@ -1110,6 +1125,7 @@ Maps with non-string keys must use an array representation with the `map` logica |**`struct`**|`record`|| |**`li

Re: [PR] Spec: add variant type [iceberg]

sfc-gh-rspitzer commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1826050630 ## format/spec.md: ## @@ -1110,6 +1125,7 @@ Maps with non-string keys must use an array representation with the `map` logica |**`struct`**|`record`|| |**`l

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1821196743 ## format/spec.md: ## @@ -444,6 +449,9 @@ Sorting floating-point numbers should produce the following behavior: `-NaN` < ` A data or delete file is associated wit

Re: [PR] Spec: add variant type [iceberg]

RussellSpitzer commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1817325374 ## format/spec.md: ## @@ -444,6 +449,9 @@ Sorting floating-point numbers should produce the following behavior: `-NaN` < ` A data or delete file is associa

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on PR #10831: URL: https://github.com/apache/iceberg/pull/10831#issuecomment-2438757395 > @aihuaxu, I think there are a couple of things missing: > > * The Avro appendix should be updated to state that a Variant is stored as a Record with two fields, a required binar

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1816076539 ## format/spec.md: ## @@ -1025,28 +1033,29 @@ Values should be stored in Parquet using the types and logical type annotations Lists must use the [3-level represe

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1817306749 ## format/spec.md: ## @@ -1297,54 +1308,56 @@ Example This serialization scheme is for storing single values as individual binary values in the lower and upper bo

Re: [PR] Spec: add variant type [iceberg]

rdblue commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1815763069 ## format/spec.md: ## @@ -1297,54 +1308,56 @@ Example This serialization scheme is for storing single values as individual binary values in the lower and upper bou

Re: [PR] Spec: add variant type [iceberg]

rdblue commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1815749080 ## format/spec.md: ## @@ -1025,28 +1033,29 @@ Values should be stored in Parquet using the types and logical type annotations Lists must use the [3-level represen

Re: [PR] Spec: add variant type [iceberg]

rdblue commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1815721928 ## format/spec.md: ## @@ -357,16 +362,16 @@ Partition field IDs must be reused if an existing partition spec contains an equ ### Partition Transforms -| Transfor

Re: [PR] Spec: add variant type [iceberg]

rdblue commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1815741890 ## format/spec.md: ## @@ -178,6 +178,11 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of key-valu

Re: [PR] Spec: add variant type [iceberg]

rdblue commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1815723294 ## format/spec.md: ## @@ -444,6 +449,9 @@ Sorting floating-point numbers should produce the following behavior: `-NaN` < ` A data or delete file is associated with

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1816076539 ## format/spec.md: ## @@ -1025,28 +1033,29 @@ Values should be stored in Parquet using the types and logical type annotations Lists must use the [3-level represe

Re: [PR] Spec: add variant type [iceberg]

rdblue commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1815755187 ## format/spec.md: ## @@ -1025,28 +1033,29 @@ Values should be stored in Parquet using the types and logical type annotations Lists must use the [3-level represen

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1816014740 ## format/spec.md: ## @@ -444,6 +449,9 @@ Sorting floating-point numbers should produce the following behavior: `-NaN` < ` A data or delete file is associated wit

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1816004362 ## format/spec.md: ## @@ -444,6 +449,9 @@ Sorting floating-point numbers should produce the following behavior: `-NaN` < ` A data or delete file is associated wit

Re: [PR] Spec: add variant type [iceberg]

rdblue commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1815764535 ## format/spec.md: ## @@ -1297,54 +1308,56 @@ Example This serialization scheme is for storing single values as individual binary values in the lower and upper bou

Re: [PR] Spec: add variant type [iceberg]

rdblue commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1815771516 ## format/spec.md: ## @@ -1297,54 +1308,56 @@ Example This serialization scheme is for storing single values as individual binary values in the lower and upper bou

Re: [PR] Spec: add variant type [iceberg]

rdblue commented on PR #10831: URL: https://github.com/apache/iceberg/pull/10831#issuecomment-2436457711 Oops. I didn't mean to close this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Spec: add variant type [iceberg]

rdblue commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1815721061 ## format/spec.md: ## @@ -444,6 +449,9 @@ Sorting floating-point numbers should produce the following behavior: `-NaN` < ` A data or delete file is associated with

Re: [PR] Spec: add variant type [iceberg]

rdblue commented on PR #10831: URL: https://github.com/apache/iceberg/pull/10831#issuecomment-2436457533 @aihuaxu, I think there are a couple of things missing: * The Avro appendix should be updated to state that a Variant is stored as a Record with two fields, a required binary `metadata

Re: [PR] Spec: add variant type [iceberg]

rdblue closed pull request #10831: Spec: add variant type URL: https://github.com/apache/iceberg/pull/10831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] Spec: add variant type [iceberg]

rdblue commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1815761335 ## format/spec.md: ## @@ -1133,6 +1142,7 @@ Hash results are not dependent on decimal scale, which is part of the type, not 4. UUIDs are encoded using big endian. Th

Re: [PR] Spec: add variant type [iceberg]

rdblue commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1815761508 ## format/spec.md: ## @@ -1148,28 +1158,29 @@ Schemas are serialized as a JSON object with the same fields as a struct in the Types are serialized according to thi

Re: [PR] Spec: add variant type [iceberg]

rdblue commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1815741890 ## format/spec.md: ## @@ -178,6 +178,11 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of key-valu

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1809284654 ## format/spec.md: ## @@ -444,6 +449,9 @@ Sorting floating-point numbers should produce the following behavior: `-NaN` < ` A data or delete file is associated wit

Re: [PR] Spec: add variant type [iceberg]

flyrain commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1807111582 ## format/spec.md: ## @@ -444,6 +449,9 @@ Sorting floating-point numbers should produce the following behavior: `-NaN` < ` A data or delete file is associated wit

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on PR #10831: URL: https://github.com/apache/iceberg/pull/10831#issuecomment-2423052011 > This needs some notes in `Partition Transforms` , I think explicitly we should disallow identity > > For Appendix B - We should define something or state explicitly we don't de

Re: [PR] Spec: add variant type [iceberg]

RussellSpitzer commented on PR #10831: URL: https://github.com/apache/iceberg/pull/10831#issuecomment-2420252802 And an entry https://github.com/apache/iceberg/blob/main/format/spec.md#parquet -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Spec: add variant type [iceberg]

RussellSpitzer commented on PR #10831: URL: https://github.com/apache/iceberg/pull/10831#issuecomment-2420248887 This needs some notes in `Partition Transforms` , I think explicitly we should disallow identity For Appendix B - We should define something or state explicitly we don't

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1805030809 ## format/spec.md: ## @@ -178,6 +178,8 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of key-valu

Re: [PR] Spec: add variant type [iceberg]

sfc-gh-aixu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1795791601 ## format/spec.md: ## @@ -178,6 +178,8 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of key-

Re: [PR] Spec: add variant type [iceberg]

RussellSpitzer commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1795725057 ## format/spec.md: ## @@ -1317,6 +1319,7 @@ This serialization scheme is for storing single values as individual binary valu ## Appendix E: Format version ch

Re: [PR] Spec: add variant type [iceberg]

RussellSpitzer commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1795723164 ## format/spec.md: ## @@ -178,6 +178,8 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of k

Re: [PR] Spec: add variant type [iceberg]

sfc-gh-aixu commented on PR #10831: URL: https://github.com/apache/iceberg/pull/10831#issuecomment-2263481244 > I do want to make sure we don't do a hostile fork here of the spec from Spark so let's make sure we get support from them to move the spec here before we merge. At the same time w

Re: [PR] Spec: add variant type [iceberg]

RussellSpitzer commented on PR #10831: URL: https://github.com/apache/iceberg/pull/10831#issuecomment-2263354450 I do want to make sure we don't do a hostile fork here of the spec from Spark so let's make sure we get support from them to move the spec here before we merge. At the same time

Re: [PR] Spec: add variant type [iceberg]

flyrain commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1699257350 ## format/variant-shredding-spec.md: ## @@ -0,0 +1,264 @@ +--- +title: "View Spec" +--- + + +# Shredding Overview + +The Spark Variant type is designed to store and p

Re: [PR] Spec: add variant type [iceberg]

flyrain commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1699257350 ## format/variant-shredding-spec.md: ## @@ -0,0 +1,264 @@ +--- +title: "View Spec" +--- + + +# Shredding Overview + +The Spark Variant type is designed to store and p

Re: [PR] Spec: add variant type [iceberg]

flyrain commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1699255366 ## format/spec.md: ## @@ -164,6 +164,8 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of key-valu

Re: [PR] Spec: add variant type [iceberg]

aihuaxu commented on PR #10831: URL: https://github.com/apache/iceberg/pull/10831#issuecomment-2261661113 cc @rdblue, @RussellSpitzer and @flyrain -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to