emkornfield commented on code in PR #10831:
URL: https://github.com/apache/iceberg/pull/10831#discussion_r1854866077


##########
format/spec.md:
##########
@@ -1154,6 +1169,7 @@ Maps with non-string keys must use an array 
representation with the `map` logica
 |**`struct`**|`record`||
 |**`list`**|`array`||
 |**`map`**|`array` of key-value records, or `map` when keys are strings 
(optional).|Array storage must use logical type name `map` and must store 
elements that are 2-field records. The first field is a non-null key and the 
second field is the value.|
+|**`variant`**|`record` with `metadata` and `value` fields. `metadata` and 
`value` must not be assigned field IDs. |Shredding is not supported in Avro.|

Review Comment:
   we should probably be consistent here and make the note that field IDs 
should not be assigned to the fields across all formats?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to