aihuaxu commented on PR #10831: URL: https://github.com/apache/iceberg/pull/10831#issuecomment-2423052011
> This needs some notes in `Partition Transforms` , I think explicitly we should disallow identity > > For Appendix B - We should define something or state explicitly we don't define it for variant. > > Appendix C - We'll need some details on the JSON serialization since that's going to have to define some string representations I think > > Under Sort Orders we should probably note you cannot sort on a Variant? > > Appendix D: Single Value Serialzation needs an entry, we can probably right "Not SUpported" for now, Json needs an entry Thanks @RussellSpitzer I missed those sections and just updated. I mark Partition Transforms, sorting and hashing not supported/allowed for now. For Appendix C, I think it should be just variant, similar to primitive type, since it's Iceberg schema as I understand the section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
