Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2025-02-20 Thread via GitHub
github-actions[bot] commented on PR #11317: URL: https://github.com/apache/iceberg/pull/11317#issuecomment-2673005308 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2025-01-21 Thread via GitHub
RussellSpitzer commented on PR #11317: URL: https://github.com/apache/iceberg/pull/11317#issuecomment-2604912801 Note from our sync where we discussed this: Today we had a little discussion on the Apache Iceberg Catalog Community Sync about DROP and DROP WITH PURGE. Currently the

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2025-01-10 Thread via GitHub
github-actions[bot] commented on PR #11317: URL: https://github.com/apache/iceberg/pull/11317#issuecomment-2584944327 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2024-12-11 Thread via GitHub
rdblue commented on code in PR #11317: URL: https://github.com/apache/iceberg/pull/11317#discussion_r1881174754 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java: ## @@ -365,6 +370,14 @@ public boolean purgeTable(Identifier ident) { String metad

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2024-12-11 Thread via GitHub
rdblue commented on code in PR #11317: URL: https://github.com/apache/iceberg/pull/11317#discussion_r1881170392 ## core/src/main/java/org/apache/iceberg/CatalogProperties.java: ## @@ -78,6 +78,14 @@ private CatalogProperties() {} public static final boolean IO_MANIFEST_CACH

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2024-12-11 Thread via GitHub
RussellSpitzer commented on PR #11317: URL: https://github.com/apache/iceberg/pull/11317#issuecomment-2536685955 https://docs.google.com/document/d/1iPGVCIcr-M0XtAiudOguWAvmqIdVgpYN5vz5ohO8PKw/edit?tab=t.0#heading=h.cr6o1g2rn5hc -- This is an automated message from the Apache Git Service.

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2024-12-11 Thread via GitHub
twuebi commented on PR #11317: URL: https://github.com/apache/iceberg/pull/11317#issuecomment-2536586079 Thanks for bringing it there. Where can I find the calendar for today's Community Sync? I've been looking through the iceberg community page but there's only a calendar having the

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2024-12-11 Thread via GitHub
RussellSpitzer commented on PR #11317: URL: https://github.com/apache/iceberg/pull/11317#issuecomment-2536523984 Bringing this up in Community Sync today to discuss future of the API here -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2024-12-11 Thread via GitHub
nastra commented on code in PR #11317: URL: https://github.com/apache/iceberg/pull/11317#discussion_r1856456560 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestRestDropPurgeTable.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2024-12-09 Thread via GitHub
sfc-gh-rspitzer commented on code in PR #11317: URL: https://github.com/apache/iceberg/pull/11317#discussion_r1876246289 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestRestDropPurgeTable.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2024-12-09 Thread via GitHub
twuebi commented on code in PR #11317: URL: https://github.com/apache/iceberg/pull/11317#discussion_r1875664949 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestRestDropPurgeTable.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2024-11-25 Thread via GitHub
RussellSpitzer commented on code in PR #11317: URL: https://github.com/apache/iceberg/pull/11317#discussion_r1856923945 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestRestDropPurgeTable.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2024-11-25 Thread via GitHub
nastra commented on code in PR #11317: URL: https://github.com/apache/iceberg/pull/11317#discussion_r1856456560 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestRestDropPurgeTable.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2024-11-23 Thread via GitHub
twuebi commented on code in PR #11317: URL: https://github.com/apache/iceberg/pull/11317#discussion_r1855212216 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestRestDropPurgeTable.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2024-11-23 Thread via GitHub
twuebi commented on code in PR #11317: URL: https://github.com/apache/iceberg/pull/11317#discussion_r1855212216 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestRestDropPurgeTable.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2024-11-05 Thread via GitHub
twuebi commented on code in PR #11317: URL: https://github.com/apache/iceberg/pull/11317#discussion_r1829207481 ## core/src/main/java/org/apache/iceberg/CachingCatalog.java: ## @@ -60,6 +60,10 @@ public static Catalog wrap( return new CachingCatalog(catalog, caseSensitive,

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2024-11-05 Thread via GitHub
nastra commented on code in PR #11317: URL: https://github.com/apache/iceberg/pull/11317#discussion_r1828904623 ## core/src/main/java/org/apache/iceberg/CachingCatalog.java: ## @@ -60,6 +60,10 @@ public static Catalog wrap( return new CachingCatalog(catalog, caseSensitive,

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2024-11-05 Thread via GitHub
nastra commented on code in PR #11317: URL: https://github.com/apache/iceberg/pull/11317#discussion_r1828902360 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestRestDropPurgeTable.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2024-11-04 Thread via GitHub
RussellSpitzer commented on code in PR #11317: URL: https://github.com/apache/iceberg/pull/11317#discussion_r1828530333 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestRestDropPurgeTable.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2024-10-25 Thread via GitHub
RussellSpitzer commented on code in PR #11317: URL: https://github.com/apache/iceberg/pull/11317#discussion_r1816909771 ## core/src/main/java/org/apache/iceberg/CatalogProperties.java: ## @@ -78,6 +78,15 @@ private CatalogProperties() {} public static final boolean IO_MANIF

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2024-10-25 Thread via GitHub
RussellSpitzer commented on code in PR #11317: URL: https://github.com/apache/iceberg/pull/11317#discussion_r1816909771 ## core/src/main/java/org/apache/iceberg/CatalogProperties.java: ## @@ -78,6 +78,15 @@ private CatalogProperties() {} public static final boolean IO_MANIF

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2024-10-25 Thread via GitHub
RussellSpitzer commented on code in PR #11317: URL: https://github.com/apache/iceberg/pull/11317#discussion_r1816807747 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java: ## @@ -365,24 +368,35 @@ public boolean purgeTable(Identifier ident) { Str

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2024-10-15 Thread via GitHub
twuebi commented on PR #11317: URL: https://github.com/apache/iceberg/pull/11317#issuecomment-2413354958 > The problem is that table properties will only be respected by clients which know how to use it, so although you may set this property, you have no guarantee clients will follow the pr

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2024-10-14 Thread via GitHub
RussellSpitzer commented on PR #11317: URL: https://github.com/apache/iceberg/pull/11317#issuecomment-2412029752 The problem is that table properties will only be respected by clients which know how to use it, so although you may set this property, you have no guarantee clients will follow

Re: [PR] Spark: add property to disable client-side purging in spark [iceberg]

2024-10-14 Thread via GitHub
twuebi commented on PR #11317: URL: https://github.com/apache/iceberg/pull/11317#issuecomment-2411857801 Hi @RussellSpitzer, thanks for the quick feedback! I changed the property to be read from catalog properties. Regarding your other concern - I'm not sure I follow - in our u